[TA] Remove ExtractKeyPhrasesOptions #21721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maririos
requested review from
tg-msft,
deyaaeldeen,
kinelski,
iscai-msft and
mssfang
ghost
added
the
iscai-msft
approved these changes
Jun 9, 2021
deyaaeldeen
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After API review, we agreed on removing all
xxOptionstypes that are not needed and put the specific properties into eachxxActionclass. What we want to avoid is having too many classes and new method overloads without an actual ask from the customer.To make PRs easier to review, I will do separate PRs for the
xxOptions. This one focuses onExtractKeyPhrasesOptions.It reverts most of #20049 :(
FYI @mssfang as this is the same approach you have in Java
Also, updated sample that shows warnings to set the model version static so sample keeps working.