Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress preview ref warning for Key Vault samples #21883

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

heaths
Copy link
Member

@heaths heaths commented Jun 15, 2021

No description provided.

@heaths heaths requested a review from schaabs as a code owner June 15, 2021 21:04
@heaths heaths requested review from pakrym and weshaggard June 15, 2021 21:04
@ghost ghost added the KeyVault label Jun 15, 2021
@heaths
Copy link
Member Author

heaths commented Jun 15, 2021

Not sure why the samples are all of a sudden being built with release versions - perhaps the pipeline being invoked? - but this seems the easiest way to make the build pass since we don't separate run dotnet build and dotnet pack --no-build (or even dotnet test --no-build - all of which would make pipeline failures easier to diagnose).

@heaths heaths merged commit 1a4ecd4 into Azure:master Jun 15, 2021
@heaths heaths deleted the fix-keyvault-release branch June 15, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants