Feature/storage/blob base client request validation #22136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmcc-msft
requested review from
amishra-dev,
amnguye,
kasobol-msft and
tg-msft
as code owners
ghost
added
the
amnguye
reviewed
Jun 24, 2021
| @@ -1132,6 +1132,12 @@ private void SetNameFieldsIfNull() | |||
|
|
|||
| ResponseWithHeaders<Stream, BlobDownloadHeaders> response; | |||
|
|
|||
| // All BlobRequestConditions are valid. | |||
There was a problem hiding this comment.
if this is the case, is this just here just in case of the future that there are conditions added that are invalid?
kasobol-msft
approved these changes
Jun 24, 2021
| @@ -10,6 +10,7 @@ | |||
| - Added support for OAuth copy sources for synchronous copy operations. | |||
| - Added support for Parquet as an input format in BlockBlobClient.Query(). | |||
| - Added optimization to unwrap encryption key once for DownloadTo and OpenRead when Client Side Encryption is enabled. | |||
| - Added support for RequestConditions parameter validation. If a request condition is set for an API that doesn't support it, and Arguement Exception will be thrown. | |||
There was a problem hiding this comment.
we should mention compat switch in changelog.
|
/azp run net - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.