-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] DataLakeFileClient RequestConditions validation #22150
Merged
seanmcc-msft
merged 6 commits into
Azure:main
from
seanmcc-msft:feature/storage/DataLakeFileSystemClientRequestConditions
Jun 25, 2021
Merged
[Storage] DataLakeFileClient RequestConditions validation #22150
seanmcc-msft
merged 6 commits into
Azure:main
from
seanmcc-msft:feature/storage/DataLakeFileSystemClientRequestConditions
Jun 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmcc-msft
requested review from
amishra-dev,
amnguye,
kasobol-msft and
tg-msft
as code owners
June 24, 2021 18:12
kasobol-msft
approved these changes
Jun 25, 2021
@@ -27,6 +27,7 @@ | |||
<ProjectReference Include="..\..\Azure.Storage.Blobs\src\Azure.Storage.Blobs.csproj" /> | |||
</ItemGroup> | |||
<ItemGroup> | |||
<Compile Include="$(AzureCoreSharedSources)AppContextSwitchHelper.cs" LinkBase="SharedCore" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SharedCore
or Shared\Core
? some links below are not consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the other links besides AuthorizationChallengeParser
are SharedCore
seanmcc-msft
deleted the
feature/storage/DataLakeFileSystemClientRequestConditions
branch
June 25, 2021 14:55
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Feb 6, 2023
release-Sentinel-2023-02-01-preview (Azure#22305) * Adds base for updating Microsoft.SecurityInsights from version preview/2022-12-01-preview to version 2023-02-01-preview * Updates readme * Updates API version in new specs and examples * add microsoft purview information protection connector kind (Azure#22150) * Add triggeredAnalyticsRuleRuns API (Azure#21977) * Add triggeredAnalyticsRuleRuns API * fix examples path * run prettier * fix lint * fix prettier * Update readme.md * draft * draft * fixing comments * fixing nit and param name * adding requires * fixing idention * Update TriggeredAnalyticsRuleRuns.json adding location header * Update TriggeredAnalyticsRuleRuns.json closing headers * Update TriggeredAnalyticsRuleRuns.json fixing warnings * Update TriggeredAnalyticsRuleRuns.json fixing lint warnings pt 2 * Update TriggeredAnalyticsRuleRuns.json fixing flatten position --------- Co-authored-by: Rotemdvir1 <rotemdvir@microsoft.com> Co-authored-by: Rotemdvir1 <95570648+Rotemdvir1@users.noreply.github.com> * MTP data connector- filter alerts by provider (Azure#22245) * MTP data connector- filter alerts by provider * validations --------- Co-authored-by: Alexander Feldsher <66358192+alfeldsh@users.noreply.github.com> Co-authored-by: Laith Hisham <49263932+laithhisham@users.noreply.github.com> Co-authored-by: Rotemdvir1 <rotemdvir@microsoft.com> Co-authored-by: Rotemdvir1 <95570648+Rotemdvir1@users.noreply.github.com> Co-authored-by: sivanguetta <46525261+sivanguetta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.