[MetricsAdvisor] Multiple classes and properties renames #22273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR looks big because of the generated code, but here's an exhaustive list of changes. Class renames are usually accompanied by property renames. Property renames are sometimes accompanied by constructor parameter renames.
Cross-language consistency:
MetricAnomalyAlertConfigurationsOperator
toDetectionConditionOperator
.Architects feedback:
Kind
, notType
. Also, the nameFeedbackKind
is too generic.DataSourceType
toDataSourceKind
.FeedbackType
toMetricFeedbackKind
.PeriodType
toMetricPeriodType
.DataFeed
, renamedAdministratorsEmails
toAdministratorEmails
, andViewersEmails
toViewerEmails
.NotificationHook
, renamedAdministratorsEmails
toAdministratorEmails
.ChangeThresholdCondition
, renamedIsWithinRange
toWithinRange
.Uri
instead ofLink
in .NET.NotificationHook
, renamedExternalLink
toExternalUri
.MetricAnomalyFeedback
, renamedAnomalyDetectionConfigurationId
toDetectionConfigurationId
, andAnomalyDetectionConfigurationSnapshot
toDetectionConfigurationSnapshot
.