[TA] Improve Actions docs and throw when more than one action type #22333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
maririos
commented
Jun 30, 2021
| @@ -3,11 +3,15 @@ | |||
| ## 5.1.0-beta.8 (Unreleased) | |||
| ### New features | |||
| - Added support for service version `3.0`. This can be specified in the `TextAnalyticsClientOptions` object under the `ServiceVersion` enum. By default the SDK targets latest supported service version. | |||
| - Added AAD support for the `StartAnalyzeHealthcareEntities` methods. | |||
There was a problem hiding this comment.
Forgot to add in previous PR
maririos
commented
Jun 30, 2021
| @@ -2408,39 +2396,43 @@ public virtual async Task<AnalyzeActionsOperation> StartAnalyzeActionsAsync(IEnu | |||
|
|
|||
| private AnalyzeActionsOperation StartAnalyzeActions(MultiLanguageBatchInput batchInput, TextAnalyticsActions actions, AnalyzeActionsOptions options = default, CancellationToken cancellationToken = default) | |||
There was a problem hiding this comment.
The diff looks all weird. what I did was:
- Create method
ValidateActionsthat throws if more than one action type is set - Aggregated all transforms from actions to tasks into a method called
CreateTasksthat can be used by bothStartAnalyzeActionsandStartAnalyzeActionsAsyncmethods
maririos
commented
Jun 30, 2021
| @@ -358,7 +358,6 @@ public void AnalyzeOperationWithErrorTest() | |||
| { | |||
| ExtractKeyPhrasesActions = new List<ExtractKeyPhrasesAction>() | |||
| { | |||
| new ExtractKeyPhrasesAction(), | |||
There was a problem hiding this comment.
Had to remove dup action type as it is no longer supported. The purpose of the tests still maintains which is to validate that we get an error when setting an invalid version.
It required re-record
kristapratico
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnalyzeActionsfunctionality