Use .NET-specific Azure subscription signup link #22355
Conversation
scottaddie
requested review from
abhipsaMisra,
ahamad-MS,
AlexanderSher,
AlexGhiondea,
allenjzhang,
amishra-dev,
amnguye,
annelo-msft,
arv100kri,
azabbasi,
barustum,
bikamani,
bleroy,
brjohnstmsft,
chidozieononiwu,
christothes,
danieljurek,
drwill-ms,
fabiocav,
giakas,
heaths,
jamdavi,
jfggdl,
JialinXin,
JoshLove-msft,
jsquire,
kasobol-msft,
kinelski and
Kishp01
as code owners
ghost
added
Event Grid
Event Hubs
IoT
KeyVault
Search
Schema Registry
Storage
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
|
There's a couple README links missing that you may want to consider including:
|
There was a problem hiding this comment.
Thank you! FR, TA, and Document Translator LGTM.
Seems like we are missing Metrics advisor => https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/metricsadvisor/Azure.AI.MetricsAdvisor
Could you add it?
scottaddie
requested review from
aim-for-better,
cijothomas,
idear1203,
rajkumar-rangaraj,
reyang,
TimothyMothra and
vishweshbankwar
as code owners
{AzurePostgresql} fixes Azure/azure-rest-api-specs#22302 fix the regex for serverName property (Azure#22355)
* {AzurePostgresql} fixes Azure/azure-rest-api-specs#22302 fix the regex for serverName property
fixes Azure/azure-rest-api-specs#22302
PR to fix the regex for serverName property
As per [this](https://learn.microsoft.com/en-us/azure/postgresql/single-server/tutorial-design-database-using-azure-portal#create-an-azure-database-for-postgresql) docs, the Postgresql Server Name should have the below pattern:
-Server name must be at least 3 characters and at most 63 characters.
-Server name must only contain lowercase letters, numbers, and hyphens. The server name must not start or end in a hyphen.
-Server name must be available.
Current Regex is incorrect: `^[a-z][a-z0-9]*$` as it doesn't allow the hyphen. The correct Regex pattern should be `^[a-zA-Z0-9]+(-[a-zA-Z0-9]+)*`
* Update common-types.json
Replace the generic Azure subscription signup link with the version .NET Marketing created. Marketing (Beth Massi) uses this link to measure Azure activations amongst .NET customers. Customers will also receive a tailored email nurture if they sign up.