Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TA] Modify library version #22417

Merged
merged 2 commits into from
Jul 2, 2021
Merged

[TA] Modify library version #22417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23e3f86
updates
maririos Jul 2, 2021
e2f6fcb
Update sdk/textanalytics/Azure.AI.TextAnalytics/README.md
maririos Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/textanalytics/Azure.AI.TextAnalytics/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Release History

## 5.1.0-beta.8 (Unreleased)
## 5.1.0 (Unreleased)
### New features
- Added support for service version `3.0`. This can be specified in the `TextAnalyticsClientOptions` object under the `ServiceVersion` enum. By default the SDK targets latest supported service version.
- Added AAD support for the `StartAnalyzeHealthcareEntities` methods.
maririos marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
8 changes: 4 additions & 4 deletions sdk/textanalytics/Azure.AI.TextAnalytics/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ Install the Azure Text Analytics client library for .NET with [NuGet][nuget]:
```PowerShell
dotnet add package Azure.AI.TextAnalytics
```
> Note: This version of the client library defaults to the `v3.1-preview.5` version of the service.
> Note: This version of the client library defaults to the `v3.1` version of the service.

This table shows the relationship between SDK versions and supported API versions of the service:

|SDK version|Supported API version of service
|-|- |
|5.1.0-beta.7 (latest Beta) | 3.0, 3.1-preview.5
|5.0.0 (latest GA) | 3.0
|1.0.0, 1.0.1 | 3.0
|5.1.0 | 3.0, 3.1 (default)
|5.0.0 | 3.0
|1.0.X | 3.0

### Prerequisites
* An [Azure subscription][azure_sub].
Expand Down
1 change: 0 additions & 1 deletion sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeSentimentAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ public AnalyzeSentimentAction(AnalyzeSentimentOptions options)
/// targets of a product or service (also known as Aspect-Based sentiment analysis).
/// If set to true, the returned <see cref="SentenceSentiment.Opinions"/>
/// will contain the result of this analysis.
/// <para>Only available for service version v3.1-preview and up.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to change this to "v3.1 and up" instead of deleting?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already explained a couple of lines below in the <remarks> section: https://github.com/Azure/azure-sdk-for-net/pull/22417/files/23e3f86fece2bd9fcb23f153ad75da8f934ca31c#diff-8413e5add00d145447a22807b999c00d1cf1807d493cf60ccfae056437f682dfR65 I just forgot to clean it :(

/// </summary>
/// <remarks>
/// This property only has value for <see cref="TextAnalyticsClientOptions.ServiceVersion.V3_1"/> and up.
Expand Down
1 change: 0 additions & 1 deletion sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeSentimentOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ internal AnalyzeSentimentOptions(TextAnalyticsRequestOptions options)
/// targets of a product or service (also known as Aspect-Based sentiment analysis).
/// If set to true, the returned <see cref="SentenceSentiment.Opinions"/>
/// will contain the result of this analysis.
/// <para>Only available for service version v3.1-preview and up.</para>
/// </summary>
/// <remarks>
/// This property only has value for <see cref="TextAnalyticsClientOptions.ServiceVersion.V3_1"/> and up.
Expand Down
2 changes: 1 addition & 1 deletion sdk/textanalytics/Azure.AI.TextAnalytics/src/Azure.AI.TextAnalytics.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<Description>Azure Cognitive Services Text Analytics is a cloud service that provides advanced natural language processing over raw text, and features like Language Detection, Sentiment Analysis, Key Phrase Extraction, Named Entity Recognition, Personally Identifiable Information (PII) Recognition, Linked Entity Recognition, Text Analytics for Health, and more.</Description>
<AssemblyTitle>Microsoft Azure.AI.TextAnalytics client library</AssemblyTitle>
<Version>5.1.0-beta.8</Version>
<Version>5.1.0</Version>
<ApiCompatVersion>5.0.0</ApiCompatVersion>
<PackageTags>Microsoft Azure Text Analytics</PackageTags>
<TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
Expand Down