[Search] Update SDK with new REST spec - 7601061b #22455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ce6855af34e9bda71314006d7e8a1bf872cd1ce
Set 2021-04-30-Preview as the supported preview version
Update test session records
ghost
added
the
Mohit-Chakraborty
requested review from
arv100kri,
bleroy,
brjohnstmsft,
KrzysztofCwalina and
tg-msft
as code owners
|
cc: @tg-msft |
tg-msft
reviewed
Jul 7, 2021
sdk/search/Azure.Search.Documents/api/Azure.Search.Documents.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/api/Azure.Search.Documents.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
| public System.Collections.Generic.IList<string> PiiCategories { get { throw null; } } | ||
| } | ||
| [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] | ||
| public readonly partial struct PIIDetectionSkillMaskingMode : System.IEquatable<Azure.Search.Documents.Indexes.Models.PIIDetectionSkillMaskingMode> |
There was a problem hiding this comment.
Why is PII cased differently than PiiDetectionSkill?
There was a problem hiding this comment.
Do we need Skill in this name? Could we just call it PiiDetectionMaskingMode?
There was a problem hiding this comment.
Why is PII cased differently than PiiDetectionSkill?
I renamed PIIDetectionSkill->PiiDetectionSkill to conform to naming guidelines. Missed this other instance. Have changed the other one now too.
There was a problem hiding this comment.
Do we need Skill in this name? Could we just call it PiiDetectionMaskingMode?
It think it helps to tie this to the skill PiiDetectionSkill.
sdk/search/Azure.Search.Documents/api/Azure.Search.Documents.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
| { | ||
| public SearchIndexerDataIdentity() { } | ||
| } | ||
| public partial class SearchIndexerDataNoneIdentity : Azure.Search.Documents.Indexes.Models.SearchIndexerDataIdentity |
There was a problem hiding this comment.
How is this name being constructed? Why are we inserting the None between Data and Identity? It reads kind of weird to me.
There was a problem hiding this comment.
This is from the spec.
There was a problem hiding this comment.
We should really spend some time here before we get anywhere close to GA. I think some of these are really confusing names (i.e., I create an instance of this type to clear the value of a property?) in one of the hardest to understand areas.
There was a problem hiding this comment.
Agree. I could not think of a quick way to improve this part w/o a lot of churn. We should have a follow-up update to this.
| @@ -1702,6 +1790,11 @@ public partial class SearchIndexerDataSourceConnection | |||
| public static bool operator !=(Azure.Search.Documents.Indexes.Models.SearchIndexerDataSourceType left, Azure.Search.Documents.Indexes.Models.SearchIndexerDataSourceType right) { throw null; } | |||
| public override string ToString() { throw null; } | |||
| } | |||
| public partial class SearchIndexerDataUserAssignedIdentity : Azure.Search.Documents.Indexes.Models.SearchIndexerDataIdentity | |||
There was a problem hiding this comment.
Does this correspond to anything in https://apiview.dev/Assemblies/Review/6a40db7f9eeb41dabfe5768f1e796c81? I'd like to normalize terminology if possible because this stuff is so tricky for customers.
There was a problem hiding this comment.
I think these are independent.
There was a problem hiding this comment.
I think this is a user-assigned managed identity and we use things like ManagedIdentityCredential in Azure.Identity. This is another one of those things we don't need to get right today but should revisit when Scott is back from vacation.
Update RoundtripAllSkills test and session records
Rename EntityRecognitionSkillVersion to SkillVersion
tg-msft
reviewed
Jul 8, 2021
| public partial class EntityRecognitionSkill : Azure.Search.Documents.Indexes.Models.SearchIndexerSkill | ||
| { | ||
| public EntityRecognitionSkill(System.Collections.Generic.IEnumerable<Azure.Search.Documents.Indexes.Models.InputFieldMappingEntry> inputs, System.Collections.Generic.IEnumerable<Azure.Search.Documents.Indexes.Models.OutputFieldMappingEntry> outputs) { } | ||
| public EntityRecognitionSkill(System.Collections.Generic.IEnumerable<Azure.Search.Documents.Indexes.Models.InputFieldMappingEntry> inputs, System.Collections.Generic.IEnumerable<Azure.Search.Documents.Indexes.Models.OutputFieldMappingEntry> outputs, Azure.Search.Documents.Indexes.Models.EntityRecognitionSkill.EntityRecognitionSkillVersion skillVersion) { } |
There was a problem hiding this comment.
Do some of these properties only make sense with a given SkillVersion? If so we might need to expose a SkillVersion property so people can interact with returned values correctly.
There was a problem hiding this comment.
That is the purpose of EntityRecognitionSkill.SkillVersion which is public. Or, do you mean something else?
| private readonly object _dummy; | ||
| private readonly int _dummyPrimitive; | ||
| public EntityRecognitionSkillVersion(string value) { throw null; } | ||
| public static Azure.Search.Documents.Indexes.Models.EntityRecognitionSkill.EntityRecognitionSkillVersion Latest { get { throw null; } } |
There was a problem hiding this comment.
Is this a service concept? Or a client concept? If it's a client concept we should make it internal.
There was a problem hiding this comment.
This is a client concept, in that, it does not flow to and from the service, but it allows users to create skills models using the versioned properties in the unified model.
sdk/search/Azure.Search.Documents/src/Indexes/Models/EntityRecognitionSkill.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /// <summary> Version 1 of the <see cref="EntityRecognitionSkill"/>. </summary> | ||
| public static EntityRecognitionSkillVersion V1 { get; } = new EntityRecognitionSkillVersion(V1Value); |
There was a problem hiding this comment.
This feels kind of weird - the extensible enum names are almost always the C# identifier version of the values. I would have expected a "V1" as the string value rather than the OData discriminator. I'm kind of torn on whether it's a good idea. We don't have to block this PR on it though.
There was a problem hiding this comment.
I don't feel strongly about it. I implemented similar to what was reviewed for unified models (with Java code).
The good thing is we are not mixing it with OData type, the values can be changed down the line.
| public OcrSkillLanguage? DefaultLanguageCode { get; set; } = OcrSkillLanguage.En; | ||
|
|
||
| /// <summary> A value indicating to turn orientation detection on or not. Default is <c>false</c>. </summary> | ||
| public bool? ShouldDetectOrientation { get; set; } = false; |
There was a problem hiding this comment.
Why are we setting a default value when it's a nullable type? Shouldn't we leave it null and use the service default?
There was a problem hiding this comment.
I have seen many a times that the defaults that are called out are intended to be passed to the service.
I will take another look.
tg-msft
approved these changes
Jul 8, 2021
Co-authored-by: tg-msft <tg-msft@users.noreply.github.com>
Mohit-Chakraborty
changed the title
ArcturusZhang
added a commit
that referenced
this pull request
Jul 27, 2021
* Add banned apis analyzer (#22414)
* Improve download docs (#22418)
* deprecated api
* improve downloadcontent and download streaming
* wip
* fix banned uri api in storage. (#22419)
* [TA] Modify library version (#22417)
* updates
* Update sdk/textanalytics/Azure.AI.TextAnalytics/README.md
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
* [Search] Avoid storm of error events being logged when running test (#21988)
* Mark EventListener using tests as non-parallelizable
* Adjust test that throws exceptions from indexing action handlers
Reduce number of documents used in the test so that EventSource does not log a very large number of events.
* Do not create proxies from proxies
* Fix more tests to avoid event exceptions
* Use GetOriginal() helper method when creating proxies
* Substitute Uri.ToString() with Uri.AbsoluteUri (#22421)
* Upgrade AKS SDK to 2021-05-01 API (#22382)
* Generate AKS SDK for 2021-05-01 API
* Remove deprecated test
* Update package info
* Update test record
Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com>
* Update blobs migration guide to include GenerateSas; Fix storage migration test bugs (#22380)
* Service Bus: fixed xml comment (#22430)
# All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
- [ ] **Please open PR in `Draft` mode if it is:**
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
- [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
- [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).**
- [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).**
### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines)
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).
### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines)
- [ ] Pull request includes test coverage for the included changes.
### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#sdk-generation-guidelines)
- [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
- [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version.
## Additional management plane SDK specific contribution checklist:
Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]`
- [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/main/eng/mgmt/mgmtmetadata).
- [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.
### Management plane SDK Troubleshooting
- If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer.
- If the check fails at the `Verify Code Generation` step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly.
Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
**Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**:
`dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
### Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.
* Catch TargetInvocationException in interceptor (#22207)
* Change the accessbility to virtual for Resource.Id
* Catch TargetInvocationException in interceptor
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* Commenting out the DataCollectionRulesTests because they are causing failures generating new SDKs (#21765)
* Update DataCollectionRulesTests.cs
commenting out the DataCollectionRulesTests because DataCollectionRules have a different error response format from everything else in AzureMonitor and so they can't be built with this SDK.
* Update DataCollectionRulesTests.cs
Commenting this the DataCollectionRulesTests because DataCollectionRules have a different error response format from everything else in AzureMonitor and so they can't be built with this SDK.
* Add some logging and add Retry attribute (#22428)
* [WebPubSub] Fix banning Uri.ToString(). (#22443)
Fix issue #22413
* Limit number of events stored in TestEventListener (#22263)
* Limit number of events stored in TestEventListener
* Throw exception when events are dropped
Increase default max event count to 1000.
* Dispose the event listener in AzureIdentityEventSourceTests
* Add comments on TestEventListener ctor
* Dispose TestEventListener in a timely manner
* Use method local TestEventListener in Search
* Update generate code
* Fix EventHub extension tests (#22439)
* Add JsonConverter for ResourceIdentity (#22373)
* Add JsonConverter for ResourceIdentity
* Feedback
* Format file
* Revert "Use sparse checkout for Create Release Tag release job (#21789)" (#22471)
This reverts commit d8cc63ad17f73c8a27636c1fc2563d1847a9c782.
* Update to use common rest api for OperationsList (#22343)
* wip changes to add common rest api
* update variable name
* address pr comments
* update recording
* Updating CODEOWNERS for ACS Identity (#22452)
Reason: The ACS SDKs (including Identity) are being handed over to the respective service teams.
* Update CODEOWNERS (#22474)
* Add interop sample (#22473)
* Add interop sample
* File header
* PR FB
* Increment version for core releases (#22478)
Increment package version after release of Azure.Core.Amqp
* Add SubscriptionContainer tests (#22348)
* Use Uri.AbsoluteUri for Key Vault (#22480)
Partial fix for #22413
* Service Bus extension API updates (#22475)
* Service Bus extension API updates
* MaxEventBatchSize
* Add SubscriptionsRestOperations tests (#22482)
* release date (#22481)
* ADO-5881 Move Azure.ResourceManager.Resources Tags objects to Azure.ResourceManager.Core (#21439)
* Initial
* Intial part 2
* Update tests
* Update Tags
* Update operation and container
* Update PreDefinedTags
* Update ResourceIdentifier.cs
* Update at scope Tag
* Create TestUpdateAllTags.json
* Update ResourceGroupOperations.cs
* Update-1
* Update-2
* Update resource type
* Update testing coverage
* Update to use single
* Update tags
* Update-2
* Update-3
* Update-4
* Update for rename and move method
* Update to use replacewith
* Add test coverage
* Update for remove LRO methods
* Update TaggableResourceTests.cs
* minor PR comment fixes
* fix tag resource container ctor
* update generic resource to use new implementation
remove unused test recordings
Co-authored-by: m-nash <prognash@gmail.com>
* Update readme
* Update autorest.md
* Standardize timeouts and remove sync over async in tests (#22375)
* Cancel lock renewal when closing receiver
* Revert and fix tests
* Fix whitespace
* Lower timeouts
* lock duration
* fix
* fix
* Fix sync over async
* revert
* Remove cast
* Fix example
* Fix test
* Fix *ModelFactory namespaces (#22469)
* Fix *ModelFactory namespaces
* Build fix
* Revert TextAnalyticsModelFactory changes
* Undo some incorrect changes
* Revert namespace changes in Azure.Communication
* Revert "Revert namespace changes in Azure.Communication"
This reverts commit c4feed4537d0d2060f73c02e929d0479c25b5310.
* Fix namespaces in Azure.Communication
* Revert change
* Fix autorest.md for timeseriesinsights
* Fix Azure.Communication.Identity build
* [OperationalInsights] - update .NET SDK using autorest (#21995)
* added WorkspaceFeatures.cs
* updated version from .23 to .24
* ran autorest code
* added the .txt file needed for PR
* re ran the generage.ps1 script - so it now includes operationalinsights_resource-manager.txt
* moved DataExport.cs to Customization folder to avoide deletion by autorest.
this file contains a manual change from auto gen code
* made DataExport.cs under Customization folder a partial class that only contains the missing inheritance, left all other autogen code as is
* [Event Hubs] July Release Prep (#22479)
The focus of these changes is to prepare the Event Hubs core package for
the July milestone release.
* Increment version for tables releases (#22488)
Increment package version after release of Azure.Data.Tables
* release date (#22493)
* Fix Media videoAnalyzer Edge Readme issue (#22459)
* update mixed reality sample
* update readme issue
* Delete AssetConversionProcessSample.cs
* update readme
* remove invalid changes
* Prepare Azure.Data.AppConfiguration 1.1.0 release (#22310)
* Migrated Storage to new swagger files (#22468)
* fix samples (#22495)
* Switch ubuntu 18 to ubuntu 20 (#22496)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
* Sync eng/common directory with azure-sdk-tools for PR 1767 (#22422)
* Support building and deploying bicep templates
* Add bicep powershell install aka link to deployment error message
* Write bicep compiled arm templates to temp directory
* Simplify bicep building code/function usage
* Use bicep location for compiled arm templates, and remove them on success
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Increment version for textanalytics releases (#22498)
Increment package version after release of Azure.AI.TextAnalytics
* Increment version for translation releases (#22499)
Increment package version after release of Azure.AI.Translation.Document
* Prepare Azure.Monitor.Query 1.0.0-beta.2 release (#22304)
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
* Increment package version after release of Azure.Messaging.EventHubs (#22502)
* [Event Hubs] Processor Release Preparation (#22501)
The focus of these changes is to prepare the Event Hubs processor package
for the July release.
* Remove extra CL section (#22504)
* Increment version for eventhub releases (#22509)
Increment package version after release of Azure.Messaging.EventHubs.Processor
* Remove usages of Uri.ToString() #22413 (#22506)
* Increment version for appconfiguration releases (#22513)
Increment package version after release of Azure.Data.AppConfiguration
* Prepare for release (#22517)
* Initial QuestionAnsweringClient (#21810)
* Initial QuestionAnsweringClient
* Generate separate LLC for authoring client
* Add cognitivelanugage to CODEOWNERS
* Define Query methods on QuestionAnsweringClient
* Remove QuestionAnsweringProjectsClient
* Add tests for QuestionAnsweringClient
* Remove test resources from deployment template
We're using a set of static resources right now. Will add back once this service version is deployed generally.
* Remove master branch from ci.yml
* Added README for Question Answering client library
* Resolve PR validation errors with URLs
* Resolve feedback and update recordings
The service deployed a fix for the confidenceScoreThreshold to truly be between 0 and 1.
* Add Azure client builder extensions
* Add more QuestionAnsweringClient samples
* Resolve PR feedback
* Added support for API Management (#22332)
* Added support for API Management
* Refactored
* Update sdk/webpubsub/Azure.Messaging.WebPubSub/src/WebPubSubAuthenticationPolicy.cs
Co-authored-by: Pavel Krymets <pavel@krymets.com>
* small cleanup
* Fixed APIM support bug
* PR feedback
* Added mock test for ReverseProxyEndpoint
* removed capture policy for now
Co-authored-by: Pavel Krymets <pavel@krymets.com>
* Add parameterless ctor and adjust README (#22500)
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
* Increment version for servicebus releases (#22520)
Increment package version after release of Azure.Messaging.ServiceBus
* Onboard packages for docs in daily docindex run (#22476)
* Add onboarding (with test)
* Try faster checkout
* Use $(DefaultBranch)
* Review feedback: Add comments to parsing logic, more cleanup in releas pipeline
* Update eng/scripts/Language-Settings.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* [Storage] Fix blob encoding in batch. (#22514)
* fix blob name encoding.
* cl
* [Core] Removes TA dependency and adds fake client (#22519)
* Increment version for monitor releases (#22538)
Increment package version after release of Azure.Monitor.Query
* Update Ubuntu VM version from 18 to 20 (#22484)
* [MetricsAdvisor] Getting ready for release (#22541)
* [Search] Update SDK with new REST spec - 7601061b (#22455)
* Update reference to REST Api spec
7601061bfbb72b2f19cb29c46cbf9a397c2d8893
* Update CHANGELOG with release date
* Update generate code
Set 2021-04-30-Preview as the supported preview version
* Update public API file
* Add tests for QueryCaption
Update test session records
* Update public API file
* Update Changelog
* Update reference to REST Api spec
* Update generate code
* Update public API file
* Unify different versions of EntityRecognitionSkill
* Move skill version types within skill types
* Mark SearchIndexerDataIdentity as abstract
Update RoundtripAllSkills test and session records
* Rename SentimentSkillVersion to SkillVersion
Rename EntityRecognitionSkillVersion to SkillVersion
* Update public API file
* Simplify code to split up QueryCaptionRaw
Co-authored-by: tg-msft <tg-msft@users.noreply.github.com>
* Define comparison operators on skill versions
* Update public API file
Co-authored-by: tg-msft <tg-msft@users.noreply.github.com>
* Guard against NotSupportedException in SetLimits (#22539)
* Fixed bug where 'Segment doesn't have any more events exception' was throw when attempting to resume from a cusor pointed at a segment that had no more events, and newer segments exist in the Change Feed. (#22546)
* Add AI mention to the Azure.Core readme (#22542)
* [MetricsAdvisor] Merge 1.0.0 changes into main (#22547)
* changes to arm core (#22524)
* [Bug Fix] Methods in ResourceGroupContainer.cs in Azure.ResourceManager.Core passes in null params (#22551)
* [BugFix] Methods in ResourceGroupContainer.cs in Azure.ResourceManager.Core passes in null params
* Add root directory to list of sparse checkout paths (#22552)
Explicitly add '/*' '!/*/' to the list of paths so we include
the files in the root of the repo.
Added some extra command logging so we can easily repro locally without
needing to find the code that ran.
Update to '/eng' so that we only get paths that start with eng instead
of every path that has eng as a folder.
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
* Add ResponseExtensions tests (#22553)
* [MetricsAdvisor] Fixing test failures (#22555)
* [MetricsAdvisor] README updates + credential code samples (#22549)
* Update Service Bus dependency (#22548)
* Increment version for servicebus releases (#22559)
Increment package version after release of Microsoft.Azure.WebJobs.Extensions.ServiceBus
* Increment version for eventhub releases (#22560)
Increment package version after release of Microsoft.Azure.WebJobs.Extensions.EventHubs
* regenerate
* Update-1
* Increment version for metricsadvisor releases (#22558)
Increment package version after release of Azure.AI.MetricsAdvisor
* Add ability to close session from processor (#22525)
* Add ability to close session from processor
* PR FB
* Rename to ReleaseSession
* Export API
* Apply suggestions from code review
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
* Add aggregate-reports to codeowners
* [Storage][Function] Fix visibility timeout extension in queues extension. (#22569)
* Fix visibility timeout extension.
* wip
* [Search] Update a broken link in README (#22568)
* Move feature operations to azure.resourcemanager.core (#22570)
* move features operations to core
* update xml docs
* Increment version for search releases (#22577)
Increment package version after release of Azure.Search.Documents
* Remove GetResource() from ResourceOperationsBase (#22571)
* Change the accessbility to virtual for Resource.Id
* Add SubscriptionContainer tests (#22348)
* Remove GetResource() from ResourceOperationsBase
* Remove GetResource() in ResourceGroup
* Remove GetResource() in Feature
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* [Storage] Merge hotifx branch. (#22584)
* [Storage][Function] Fix visibility timeout extension in queues extension. (#22569)
* Fix visibility timeout extension.
* wip
* [Storage] Prep hotfix release. (#22574)
* release prep.
* fix cl
* Increment version for storage releases (#22581)
Increment package version after release of Microsoft.Azure.WebJobs.Extensions.Storage
* Increment version for storage releases (#22582)
Increment package version after release of Microsoft.Azure.WebJobs.Extensions.Storage.Blobs
* Increment version for storage releases (#22583)
Increment package version after release of Microsoft.Azure.WebJobs.Extensions.Storage.Queues
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
* Remove from codeowners. (#22386)
* Update -2
* ADT: Docs: Fix seealso doc tags. (#22586)
* Support integration of IoT Models Repository metadata in preview SDK (#22521)
* Consumes new service metadata capability outlined [here](https://github.com/Azure/iot-plugandplay-models-tools/wiki/Publishing-Metadata).
* Metadata for the global endpoint resides [here](https://devicemodels.azure.com/metadata.json).
* Metadata is optional. Failure in processing repository metadata should not be a terminal failure.
* Simplifies client API surface area:
* Removes model dependency resolution configuration in the `ModelsRepositoryClientOptions` (and the pattern of the client constructor setting a default resolution option).
* Removes `ModelDependencyResolution.TryFromExpanded`. TryFromExpanded becomes an internal processing concept. The metadata of a target repository will indicate if expanded model forms are available.
* Model dependency resolution configuration becomes scoped to the service operation level. The `GetModels[Async]` service operations have their `dependencyResolution` parameter set to `ModelDependencyResolution.Enabled` by default.
* Updates to tests and samples documentation reflecting the prior mentioned changes.
* Resolve PR feedback.
* adding headers and query parms for logging (#22537)
* [NetAppFiles] Update to api-version 2021-04-01 (#22326)
* Update to api-version 2021-04-01
* Added customization for CheckFilenameAvailability backwards compatability
* Added obsolete attrib for visibilty
* Split custom classes in to files add custom interface
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
* Updating code snippets in Samples and Readme (#22518)
* Change the accessbility to virtual for Resource.Id
* Initial setup
* Adding Snippets to tests\Samples
* Generate snippets in markdown files
* Sample 3 code snippets
* Update Sample2_ManagingResourceGroups.cs
* Update Snippets with generator
* Fix Sample2 snippets
* Delete Azure - Backup.ResourceManager.Core.Tests.csproj
* Ignoring dummy subscription id tests
* Adding namespaces to examples
* Modify code snippets in main readme
* Add ignore tags
* Adding Azure.ResourceManager.Core namespace
* Update code snippets
* Adjust indentation
* Removing auto-gen snippets for Sample3
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* [MetricsAdvisor] Enabling test assertion after service fix (#22585)
* release Identity (#22600)
* nibhati-5273-merge location (#22483)
* Change the accessbility to virtual for Resource.Id
* wip
* WIP
* Update ResourceOperationsBase.cs
* wip
* wip
* wip
* wip
* wip
* update loc based on feedback
* update after merge
* update to core framework tests
* update samples after location changes
* update readme based on code changes
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: Nisha Bhatia <nibhati@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* Update AutoRest C# version to 3.0.0-beta.20210711.1 (#22218)
* Release Identity (#22602)
* revert Azure.Core version
* add management object group to core (#22592)
* wip
* Add mgmt group to core
* remove temp files
* update to not have nullable but share the same operations between ManagementGroup and ManagementGroupInfo
* address PR comments
* change location to string to return name instead of display name (#22606)
* update location name and corresponding tests
* update comments
* Increment version for identity releases (#22608)
Increment package version after release of Azure.Identity
* Remove ZWSP (#22601)
* Make the Parent of ResourceContainerBase to be the OperationsBase type (#22589)
* [WebPubSubExtension] Add WebPubSubRequest to improve experience under HttpTrigger (#22033)
### General Description
Add a `WebPubSubRequest` input binding to help pre-process HttpRequest under Web PubSub scenario, so customer don't have to desterilize the request themselves. This is an improvement targeting for Static Web App as it accepts `HttpTrigger` only.
### Usage sample (will be added to sample snippet in another PR)
* csharp
```cs
[FunctionName("message")]
public static async Task<object> Broadcast(
[HttpTrigger(AuthorizationLevel.Anonymous, "post", "options")] HttpRequest req,
[WebPubSubRequest] WebPubSubRequest wpsReq,
[WebPubSub(Hub = "simplechat")] IAsyncCollector<WebPubSubOperation> operations)
{
if (wpsReq.Request is ValidationRequest || wpsReq.Request is InvalidRequest)
{
return wpsReq.Response;
}
if (wpsReq.Request is MessageEventRequest request)
{
await operations.AddAsync(new SendToAll
{
Message = request.Message,
DataType = request.DataType
});
}
return "ack";
}
```
* javascript
`index.js`
```js
module.exports = async function (context, req, wpsReq) {
if (wpsReq.request.isValidationRequest || !wpsRequest.request.valid)
{
return wpsReq.response;
}
else {
context.bindings.webPubSubEvent = {
"operationKind": "sendToAll",
"message": wpsReq.request.message,
"dataType": wpsReq.request.dataType
};
return { body: { from: '[System]', content: 'ack.'} };
}
};
```
`function.json`
```json
{
"disabled": false,
"bindings": [
{
"authLevel": "anonymous",
"type": "httpTrigger",
"direction": "in",
"name": "req"
},
{
"type": "http",
"direction": "out",
"name": "$return"
},
{
"type": "webPubSubRequest",
"name": "wpsReq",
"direction": "in"
},
{
"type": "webPubSub",
"name": "webPubSubEvent",
"hub": "simplechat",
"direction": "out"
}
]
}
```
# All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
- [x] **Please open PR in `Draft` mode if it is:**
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
- [x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
- [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md).**
- [x] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).**
### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md#general-guidelines)
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).
### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md#testing-guidelines)
- [x] Pull request includes test coverage for the included changes.
### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md#sdk-generation-guidelines)
- [x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
- [x] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version.
## Additional management plane SDK specific contribution checklist:
Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]`
- [x] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/master/eng/mgmt/mgmtmetadata).
- [x] Update AzureRP.props to add/remove version info to maintain up to date API versions.
### Management plane SDK Troubleshooting
- If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer.
- If the check fails at the `Verify Code Generation` step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly.
Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
**Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**:
`dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
### Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.
* Update autorest.md
* Update to add list method
* [ServiceBus] fix reference name conflict in comments (#22613)
* Update ACR Docstrings (#22576)
* update docstrings
* more updates
* regen from updated swagger
* update generated API listing
* Update sdk/containerregistry/Azure.Containers.ContainerRegistry/src/ContainerRegistryClient.cs
Co-authored-by: Christopher Scott <chriscott@hotmail.com>
* Update sdk/containerregistry/Azure.Containers.ContainerRegistry/src/Repository/ContainerRepository.cs
Co-authored-by: Christopher Scott <chriscott@hotmail.com>
* pr fb
* update to latest swagger in azure-rest-api-specs repo
* export API
Co-authored-by: Christopher Scott <chriscott@hotmail.com>
* [Smoke Tests] (#22251)
The focus of these changes is to update the dependencies for the smoke
tests to resolve conflicts when the dev feed is used for individual packages
in the solution.
* Updating Azure.Communication.NetworkTraversal to new API version 2021-06-21-preview (#22578)
* Add WritableSubResource tests (#22618)
* Change the accessbility to virtual for Resource.Id
* Add SubscriptionContainer tests (#22348)
* Change SubResource constructors to protected
* Fix a bug in ReferenceType tests
* Add WritableSubResource tests
* Delete not in use class UpdateResourceGroupOperation
* Update unit test
* Update reference type tests
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* [Event Hubs] Client Identifier Option (#22614)
The focus of these changes is to add an option for setting an Identifier
for each Event Hubs client type. The identifier is informational and is
associated with the AMQP links used, allowing the service to provide additional
context in error messages and the SDK logs to provide an additional point
of correlation.
* organize classes - move custom code outside of generated folder - remove duplicate identity (#22626)
* organize classes
move custom code outside of generated folder
remove duplicate identity
* remove unused method
* Add ListExtensions tests (#22628)
* Change the accessbility to virtual for Resource.Id
* Add SubscriptionContainer tests (#22348)
* Add ListExtensions tests
* Add a positive test
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* Sync eng/common directory with azure-sdk-tools for PR 1808 (#22627)
* Add FilterPoliCheckResult.ps1
* Add description to FilterPoliCheckResults.ps1
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
* ADT: eng : Bicep file needs to be fixed to adapt to guidelines of engineering system. (#22619)
* Bicep file needs to be fixed to adapt to guidelines of engineering pipeline
* Update prerequisite readme.md
* Switch from AppendFormat to Append (#22630)
* Add missing sections from the QuickStart to the main Readme (#22634)
* Change the accessbility to virtual for Resource.Id
* Adding missing sections from workshop quickstart
* Adding missing code snippets
* Updating code snippets in main readme
* Small fixes in comments in code snippets
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* remove default location from armclientoptions (#22633)
* organize classes
move custom code outside of generated folder
remove duplicate identity
* remove unused method
* remove defaut location from armclientoptions
* address pr comments
* update arm core version
* remove unneeded abstract property
* Update AutoRest C# version (#22603)
* Update AutoRest C# version to 3.0.0-beta.20210713.3
* Run Export-Api
Co-authored-by: Matt Ellis <matell@microsoft.com>
* Update VaultOperationsTests.cs
* Update tests
* [Event Hubs] Avoid Possible Allocation (#22632)
The focus of these changes is to alter the approach used for copying an
AMQP message section dictionary to avoid a possible allocation of the `Keys`
collection of the source dictionary when no items are present.
* add guid validation (#22535)
* fix 304 (#22647)
* enable test and recorded data (#22625)
* Rerecord tests for Key Vault 7.3-preview (#22646)
* merge Azure.ResourceManager.Core into main (#22507)
* initial checkin for core / tests (#18968)
* initial checkin for core / tests
* Add readme.md file
* Fix header in readme
* remove autorest until we convert off hand written types
* update azure.core reference
remove sets to tags
ignore tests which require credentials for now
* Add the proto client which will be used until the autogen work is complete
* Add missing readmes for proto client
* update to require linq 4.0.0 so that don't have to upgrade bcl
* add changlog for CI
* change system.linq.async to update
* update to use source vs binary for the temporary generation of Azure.ResourceManager.Authorization
* Add changelog for azure.resourcemanager.authorization and update version to be beta
* update typos in readme
* update name of proto client sln
* merge in changes from proto repo this week
* fixed unit test failures
missed a few files from the merge from proto repo
updated compute and network sdk version to use latest azure.core with readonly list types
* ignore tests which require live azure until 5122 is closed
* Update failing scenario test
* Subnet Container list still returns SubnetOperations and not Subnet #5584 (#19109)
* 5584
* Update async test
* Test
* WIP: test
* Update Proto.Authorization.csproj
* Update Proto.Authorization.csproj
* Update Proto.Authorization.csproj
* Update Proto.Authorization.csproj
* add param checking to resource (#19134)
* Adding parameter check for track 2 Azure.ResourceManager.core (#19162)
* initial checkin
* adding test cases
* nibhati-5142-add Params and testing for ApiVersionBase.cs (#19193)
* add tests for ApiVersionBase
* update methods
* nibhati - 5142 - add tests for ArmBuilder.cs (#19231)
* add tests for ArmBuilder
* Update ArmBuilderTests.cs
* Update SubscriptionContainer.cs
* Update test project to consume framework for recorded tests (#19171)
* Update test project to consume framework for recorded tests
* Changes required to get instrumentation working for the new armClient
added support for session recording for onetimesetup and onetimeteardown
* move unit test files
* update tests to not use username for prefix
* update targets to separate existing track 2 libraries from new core until autorest changes are finished
* merge in armbuildertest and update to use new framework
* remove necessity on session files if no onetimesetup
* Address review comments
* Move ApiVersionOverrides to ARMClientOptions class (#19358)
* Rename list operations (#19386)
* tenant resource sample (#19195)
* WIP: tenant resource
* WIP: updates
* Update ResourceIdentifier.cs
* Update ResourceIdentifier.cs
* Update ResourceType.cs
* WIP update check
* WIP
* Add readme for billing
* Stylecop
* WIP
* Remove style
* wip: update
* WIP: updates
* WIP
* WIP: update
* WIP
* Updates
* WIP: updates
* Update
* WIP: updates
* WIP
* Update tests
* WIP: updates
* Remove reference for Azure.Identity (#19434)
* Remove reference for Azure.Identity
* fixing ArmClient construction in proto client
* resync and fix build error
* 5521 - Rename TryGetValue to TryGet/TryGetAsync (#19478)
* Rename TryGetValue to TryGet/TryGetAsync
* Update ContainerBase.cs
* Update ContainerBase.cs
* Update TryGet method and test class
* Update CheckResourceExists.cs
* Rename TryGetValue to TryGet/TryGetAsync
* Update ContainerBase.cs
* Update ContainerBase.cs
* Update TryGet method and test class
* Update CheckResourceExists.cs
* Update ContainerBaseTest.cs
* Update TryGet Test
* Update tests
* Update tests and framework to instrument all clients recursively (#19443)
* Framework changes
* Azure.ResourceManager.Core changes to support client interceptors
* Test changes
* proto client changes
* updates after merge
* Address review comments
* WIP
* updates after WIP
* Update the implicit operator (#19720)
* Remove System.Linq.Async dependency. (#19745)
* Change the accessibility to virtual for Resource.Id (#19804)
* Sku Serialization (#19819)
* Sku Serialization
* Divide Sku class
* Update Sku
* Add lookup mechanism for ID to apiversion (#19437)
* WIP: updates
* WIP: updates
* Update test
* Update ResourceListOperationsTest.cs
* Update CreateSingleVmExample.cs
* Update CreateSingleVmExample.cs
* Update CreateSingleVmExample.cs
* Update CreateSingleVmExample.cs
* WIP: Updates
* Add extra line
* Update
* WIP:
* WIP: updates
* WIp: updates
* Remove API version extensions
* WIP: updates
* Updates
* Update test
* WIP updates
* Updates
* WIP
* Remove blank lines
* Update filtering
* Updates
* Update
* WIP: updates
* WIP: updates
* Add space
* Remove debug
* Updates
* WIP: updates
* WIP
* Change the accessbility to virtual for Resource.Id
* WIP: updates
* WIP Updates
* WIP updates
* WIP
* WIP
* WIP:
* revert
* WIP: updates
* WIP: updates
* WIP: updated
* WIP
Co-authored-by: YalinLi0312 <yall@microsoft.com>
* Resource Identifier changes (#19636)
* Resource Identifier changes
* Adapting Container classes to base class change in Id property
* Fixing xml documentation comments for ResourceType
* Cleaning up resource id ToStrign() and fixing ListLocations client creation
* Adjusting new tenant resource operations for resource id scheme
* Responding to review comments
* Add test coverage, retain string reresentation of resource id
* Fixing additional merge issues
* Updating comparison tests to use concrete variable types
* Plan Serialization (#19820)
* Plan Serialization
* Divide Plan class
* Update Plan
* Mnash 5705 rename container (#19932)
* Change the accessbility to virtual for Resource.Id
* rename ArmClient, ArmClientOptions, Get[Resource]Container
* updates after merge
* missing one file for rename
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
* 2 missing renames (#19952)
* Change the accessbility to virtual for Resource.Id
* rename ArmClient, ArmClientOptions, Get[Resource]Container
* updates after merge
* missing one file for rename
* Missed 2 renames
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
* nibhati - 5191 - add ClientContext.cs (#19602)
* WIP
* WIP
* Update ResourceOperationsBase.cs
* update for tenant extensions
* update csproj
* Update Azure.ResourceManager.Network.csproj
* update csproj
* update csproj
* WIP
* WIP
* update csproj
* update csproj
* update csproj
* add tests
* update test
* update
* fix test cases to use the diagnostics case fix a missing mocking constructor
* WIP
* update framework for tests
* Update Azure.Test.Perf.csproj
* merge
* revert list json files
* revert
* WIP
* fix ci
* Update Program.cs
* update proto
* fix test
* Update ClientContextTests.cs
* update proto
* Update Azure.ResourceManager.Billing.csproj
* update version
* update ci
* Update Azure.ResourceManager.EventHubs.csproj
* add packable
Co-authored-by: m-nash <prognash@microsoft.com>
* GenericResource Serialization (#19898)
* Resource Serialization
* Plan Serialization
* Divide Plan class
* Divide Resource class
* Update writer
* Update Plan
* TrackedResource Serialization
* Update GenericResource
* Clean Up
* Update GenericResource
* Remove read only
* Update tests
* TrackedResource Serialization (#19855)
* Resource Serialization
* Divide Resource class
* Update writer
* TrackedResource Serialization
* Update Deserialization
* Update Test
* Update Tests
* Update Tracked Resource
* Fix PR
* Remove readonly
* Remove the Get[Resource]Operations methods except for client extensions (#20136)
* Change the accessbility to virtual for Resource.Id
* wip
* ignore test temporarily
* update to remove Get[Resource]Operations
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
* nibhati - 5572 - make Credentials and Options internal (#20243)
* Change the accessbility to virtual for Resource.Id
* add transport
* update test
* add jsons
* add json
* remove transport
Co-authored-by: YalinLi0312 <yall@microsoft.com>
* Remove ignore on tests that were failing due to faulted tasks in interceptor (#20341)
* Change the accessbility to virtual for Resource.Id
* remove ignore on tests and update intrumentation to handle faulted tasks
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <micnash@microsoft.com>
* Make the Reference type generic (#20358)
* Change the accessbility to virtual for Resource.Id
* Make the reference type generic
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* nibhati 5401 - add CancellationToken to GetResource() (#20396)
* Change the accessbility to virtual for Resource.Id
* add token
Co-authored-by: YalinLi0312 <yall@microsoft.com>
* JonathanCrd 5574 - remove system.collections.immutable (#20437)
* Change the accessbility to virtual for Resource.Id
* Removing package reference to System.Collections.Immutable
* Removing use of ImmutableList
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* JonathanCrd 5003 - comparison methods for ResourceIdentifier (#20456)
* Change the accessbility to virtual for Resource.Id
* Operators == and != overloads in ResourceIdentifier
* Added EqualsToString Tests and TestCases
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* update constructors for reference types (#20477)
* update constructors for reference types
* fix stylecop issue
* fixes after merge
* add two way implicit for autorest deserialization (#20557)
* update constructors for reference types
* fix stylecop issue
* add two way implicit for autorest deserialization
* Add a common definition for sub-resource (#20524)
* add SubResource
* serialization of the two classes
* protected internal; full subresource namespace
Co-authored-by: Yeming Liu <yeliu@microsoft.com>
* Add default constructors to resource classes (#20583)
* update constructor signatures for autogen (#20607)
* update constructors for reference types
* fix stylecop issue
* add two way implicit for autorest deserialization
* update constructor signatures for autogen
* Remove ProxyResource since its intended to be used any longer (#20608)
* adding reference constructors attributes (#20611)
* update constructors for reference types
* fix stylecop issue
* add two way implicit for autorest deserialization
* update constructor signatures for autogen
* add attributes to define ctor types for autogen
* Cache the creation of HTTP pipeline in ArmClient (#20636)
* Remove create from container base; remove ArmBuilder abstract class (#20684)
* Remove create from container base; remove ArmBuilder abstract class
* UnTypedContainer->Container; fix doc issues
* make createAsync() virtual
Co-authored-by: Yeming Liu <yeliu@microsoft.com>
* fixes after merge
* adding singleton pattern in Arm.Core and Proto (#20591)
* adding initial singleton base classs and proto code
* PR comment fix.
* Completed singleton VMSS test case.
* Fix merge issue around ArmBuilder removal
* Fix build issue.
* Fixing test failure
* CR comment.
* Flattend the builder to partial classes.
* CR fix
* Update arm response types to match current Azure.Core pattern (#20738)
* WIP
* wip
* Change the accessbility to virtual for Resource.Id
* update strawman for operation changes
* finalize changes before testing
* update ph overloads
* move pipeline creation into armoperation
* wip
* updates based on new OperationInternals
* address PR comments
* update test classes to use new pattern
* final fixes for arm core tests
* use mock response instead of null
* updates to proto code
* add null check around basetype
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
* Fix a bug in ArmClient (#20897)
* Move generic resource from resources to core (#20927)
* initial changes to move generic resource items over
* wip updating tests
* more work on test cases
* updates to adapt the operation changes
* remove arm response / operation
* remove unused classes now and finish move resource test
* update resourcegroup operation tests
* update tests for genericresource operations
* add genericresource container tests
* update proto solution
* update proto comments
* address naming comments
* update comments which no longer have inheritance
address wildcard comment in csproj
* update ResourceContainerBase (#20981)
Co-authored-by: Yeming Liu <yeliu@microsoft.com>
* updates to subresource type (#21010)
clean up extensions meant for Operation now
* VM image, extension image (edgezone not included as it is new not in Compute sdk yet) (#20971)
* update reference types and add unit tests to validate (#21031)
* updates to subresource type
clean up extensions meant for Operation now
* need protected internal serialization constructor for reference types, added unit tests to validate for future
* updates after merge
* update policy copying for clone and convert (#21069)
* 5771 - GetGenericResourceOperations in ArmClient (#21066)
* Change the accessbility to virtual for Resource.Id
* GetGenericResourceOperations extension method implementation
* Create ArmClientTests.cs
* Scenario Tests
* GetGenericResourceOperations for single ID
* Single ID tests
* Addressing comments
* Tests recordings
* Tests recordings
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* 5844 Rename SubResourceWritable to WritableSubResource (#21092)
* Rename symbol
* Rename class
* Rename serialization class
* Merge Azure.ResourceManager.Resources.Models.Subscription with Azure.ResourceManager.Core.SubscriptionData (#20751)
* Initial
* Merge
* Update SubscriptionOperations.cs
* Fix error
* Update using
* Update test
* Fix tests
* Update json
* Update ClientContextTests.cs
* update based on comments
* Add get test
* Remove unnecessary file
* Update LocationListResult.cs
* Update ClientContextTests.cs
* Update operation class & add tests
* move models to model folder
Co-authored-by: m-nash <prognash@gmail.com>
* remove id type from container base to match operation base (#21150)
* remove id type from container base to match operation base
* update proto references
* add support for root resource Id container (#21175)
* remove id type from container base to match operation base
* update proto references
* add support for root resource Id container
* Merge ResourceGroup model in Resources with ResourceGroupData in Core (#20904)
* Change the accessbility to virtual for Resource.Id
* Merge ResourceGroup model in Resources with Core ResourceGroupData
* Add and update scenario tests
* Resolve merge conflicts
* Update scenario tests
* Record ResourceGroupContainerTests
* Initialize Tags in base class
* Update ResourceGroupOperationsTests and re-record
* Fix the errors in Proto.Client scenario tests
* Move some files in Generated folder back
* Address review comments
* Add records
* Fix the failing test StartExportTemplate
* Address comments
* Change tag lro operations to return its lro type
* Change rg CreateOrUpdate lro operations to return its lro object
* Update CreateOrUpdate lro object
* Run tests
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* Delete PhTaskDeferringAsyncPageable.cs (#21183)
* Remove PhArmResponse (#21139)
* Remove PhArmResponse part 1
* Remove PhArmResponse part 2
* Delete PhArmResponse.cs
Co-authored-by: m-nash <prognash@gmail.com>
* Remove PhArmOperation (#21290)
* Remove PhArmOperation
* Disable TestResourceTypeFilterParamCheck Test
* Disable SA warning
* remove unused file
Co-authored-by: m-nash <prognash@gmail.com>
* 5841 - Update List methods from proto clients. (#21314)
* Remove List methods with inner Get() call in Compute
* Remove List methods with inner Get() call in Network
* Removing scenario tests referencing deleted List() methods
* Add lambda wrapper in armclient for getting container objects in othe… (#21390)
* Add lambda wrapper in armclient for getting container objects in other RPs
* update xml comments
* 5285 Remove TrackedResource<TIdentifier, TModel> class. (#21376)
* Delete TrackedResource.cs
* Removed class from Core added to individual Proto Libraries
* Removing imported class in Proto.Client
* Add missing new lines
* update to allow external access to a constructor that doesn't have an operation base (#21395)
* Add lambda wrapper in armclient for getting container objects in other RPs
* update xml comments
* update to add externally accesible constructor that doesn't have an operation base like armclient as the parent
* Move Azure.ResourceManager.Resources Tenants objects to Azure.ResourceManager,Core (#21413)
* Change the accessbility to virtual for Resource.Id
* Move Azure.ResourceManager.Resources Tenants objects to Azure.ResourceManager.Core
* Resolve conflicts
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* Templetize SubResource and WritableSubResource classes, and added unit tests (#21397)
* Change the accessbility to virtual for Resource.Id
* Sub resource template and tests
* public class , public constructor
* some PR comments
* PR comments and phonecall around silent errors and casting
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* Remove the suppression for namespace in mgmt sdks (#21534)
* remove no warn AZC0001
* remove the namespace warn suppression from mgmt plane sdks
* remove old todo
* update tenant and subscription list resource hooks to follow the same pattern (#21568)
* fix the attribute of subresource (#21685)
* fix the attribute of writableSubResource (#21688)
* Add ArmClient tests (#21620)
* Change the accessbility to virtual for Resource.Id
* Add tests for ArmClient
* Address review comment
* Update recordings
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* Add GenericResourceContainer tests (#21759)
* Change the accessbility to virtual for Resource.Id
* Add CreateOrUpdate tests
* Add StartCreateOrUpdate tests
* Add Get tests
* Add GetApiVersion and ListByResourceGroup tests
* Update test records
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* Bug System.ArgumentOutOfRangeException thrown in ResourceIdentifier - 5879 - nibhati (#21537)
* add list resources apis to resourceGroupOperations (#21809)
* [Azure.ResourceManager.Core] Introduce the `UseClientContext` to `SubscriptionOperations` and `ResourceGroupOperations` (#21811)
* introduce the useClientContext to subscriptionOperations and ResourceGroupOperations
* resolve comments
* resolve comments
* fix compile errors in other solutions
* Add ResourceGroupContainer tests (#21832)
* Change the accessbility to virtual for Resource.Id
* Add ResourceGroupContainer tests
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* remove ph classes (#21852)
* remove ph classes
* add temp files to proto
* change Parent in ContainerBase to OperationsBase type (#21872)
* Add GenericResourceOperations tests (#21828)
* Change the accessbility to virtual for Resource.Id
* Add GenericResourceOperations tests
* Merge GenericResourceOperationsTests and GenericResourceTests
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* Add ResourceGroupOperations tests (#21893)
* Change the accessbility to virtual for Resource.Id
* Add ResourceGroupOperations tests
* Remove parallelizable tag
* Update session records
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* update to be inside core namespace (#21892)
* update to be inside core namespace
* update proto references to removed namespace
* remove references from test proj
* remove unused interfaces (#21898)
* update to be inside core namespace
* update proto references to removed namespace
* remove unused interfaces
* Add ResourceGroupBuilder tests (#21897)
* Change the accessbility to virtual for Resource.Id
* Add ResourceGroupBuilder tests
* Address comment
* Extract the test for Build() to a seperate method
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* Update Track 2 Mgmt Plane Template (#21876)
* Update Track 2 Mgmt Plane Template
* Moving the package ref into the actual project file
* Fixing Management tests and updating sln to include missed project
* Update build for core.test and invert the mgmt shared test code include.
* Fix CI
* Add ResourceGroupDeleteOperation tests (#21927)
* 5966 sync code coverage fix (#21925)
* consolidate test classes
* update interceptors to get code coverage on sync methods for LRO responses
* Remove ArmResponse since that is no longer needed
* update test cases that moved with recordings
* remove TA dependency on core sln
* put back ai dependency which we should remove
* update to cover .net 5 case
* consolidate code
* remove extension sub classes since they aren't needed (#21945)
rename some parameters
* Mnash apiview cleanup (#21952)
* remove extension sub classes since they aren't needed
rename some parameters
* update instrumentation for generic resource and tenant
* remove Get() from ResourceOperationsBase (#21963)
Co-authored-by: Yeming Liu <yeliu@microsoft.com>
* update to use zero wait on playback (#22066)
* update to use zero wait on playback
* update resourcemanager ci to run when shared files change
* one more mgmt shared folder
* Update sub resource CC to 94%. (#22117)
* Add ResourceGroupsRestOperations tests (#21981)
* Added support for implicit provider resource type ResourceIdentifier p… (#22142)
* Added support for impicit provider resource type ResourceIdentifier parsing
* Update clearer list name based on CR comment
* Azure.ResourceManager.Core readmes and samples (#21858)
* Change the accessbility to virtual for Resource.Id
* Readme and sample files
* Fixing links
* Fixing links
* Fixing links
* Delete OLD README.md
* Migrating to new SDK
* samples rename
* Update ManagingResourceGroups.md
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
* Addressing comments in Managing Resource Groups example
* Hello World added
* Update Sample1_HelloWorld.md
* Delete README.md
* Create README.md
* Addressing HelloWorld comments
* Apply suggestions from code review
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
* Addressing comments in readme
* Commenting relative links
* Fix CI Link errors
* Fixing CI errors
* Snippets IDs deleted
* Changing Prerequisites and Auth info
* Don't use .Construct in rg example
* Migration guides in future PR
* Fix CI
* Prerequisites
* Remove Links comments temporarily
* Typo in Readme
* Apply suggestions from code review
Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>
* Changing all links to absolute links
* Spelling
* Commenting not existing links
* Fix CI
* Typo
* Update Sample1_HelloWorld.md
* Apply suggestions from code review
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>
* Move Providers and ProviderOperations from Azure.ResourceManager.Resources into Azure.ResourceManager.Core-nibhati-5862 (#21337)
* Change the accessbility to virtual for Resource.Id
* WIP
* WIP
* WIP
* wip
* Update TenantOperations.cs
* wip
* WIP
* wip
* wip
* wip
* wip
* fix formatting
* wip
* Update ProviderContainer.cs
* Update ProviderContainer.cs
* wip
* wip
* Update ProviderContainerTests.cs
* wip
* wip
* update to interceptor to handle targetinvocation on a failed task
* remove expand parameter from LoadApiVersion methods
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* remove need to copy policies (#22280)
* Add ResourceListOperations tests (#22279)
* Change the accessbility to virtual for Resource.Id
* Add ResourceListOperations tests
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* remove proto (#22282)
* Follow up PR - 5593 Azure.ResourceManager.Core Readme (#22262)
* Change the accessbility to virtual for Resource.Id
* Changing temporary links to absolute ones.
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* Add PropertyReferenceType attribute in ResourceIdentity (#22255)
* Add PropertyReferenceTypeAttribute attribute in ResourceIdentity
* Feedback
* remove resources dependency (#22293)
* wip
* remove remaining references to azure.resourcemanager.resources
* update tests to handle new changes
* update summary for gets or sets
* Updating GenericResource.Lists to return GenericResourceExpanded. (#22284)
* Updating GenericResourceList to return GenericResourceExpanded
* Added missing expand and related test cases.
* Adding missing test recordings.
* cleanup the warnings that were supressed (#22318)
* fix CA1036
* remove CA1067
* remove CA1065
* remove SA1028
* Exposing expand on ListAtContext as well in preparation to expose that in each of the generated ListAsGeneric methods in autorest (#22351)
* Updating GenericResourceList to return GenericResourceExpanded
* Added missing expand and related test cases.
* Adding missing test recordings.
* Exposing expand on ListAtContext as well in preparation to expose that in each of the generated ListAsGeneric methods in autorest
* Catch TargetInvocationException in interceptor (#22207)
* Change the accessbility to virtual for Resource.Id
* Catch TargetInvocationException in interceptor
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* Add JsonConverter for ResourceIdentity (#22373)
* Add JsonConverter for ResourceIdentity
* Feedback
* Format file
* Update to use common rest api for OperationsList (#22343)
* wip changes to add common rest api
* update variable name
* address pr comments
* update recording
* Add SubscriptionContainer tests (#22348)
* Add SubscriptionsRestOperations tests (#22482)
* ADO-5881 Move Azure.ResourceManager.Resources Tags objects to Azure.ResourceManager.Core (#21439)
* Initial
* Intial part 2
* Update tests
* Update Tags
* Update operation and container
* Update PreDefinedTags
* Update ResourceIdentifier.cs
* Update at scope Tag
* Create TestUpdateAllTags.json
* Update ResourceGroupOperations.cs
* Update-1
* Update-2
* Update resource type
* Update testing coverage
* Update to use single
* Update tags
* Update-2
* Update-3
* Update-4
* Update for rename and move method
* Update to use replacewith
* Add test coverage
* Update for remove LRO methods
* Update TaggableResourceTests.cs
* minor PR comment fixes
* fix tag resource container ctor
* update generic resource to use new implementation
remove unused test recordings
Co-authored-by: m-nash <prognash@gmail.com>
* changes to arm core (#22524)
* [Bug Fix] Methods in ResourceGroupContainer.cs in Azure.ResourceManager.Core passes in null params (#22551)
* [BugFix] Methods in ResourceGroupContainer.cs in Azure.ResourceManager.Core passes in null params
* Add ResponseExtensions tests (#22553)
* Move feature operations to azure.resourcemanager.core (#22570)
* move features operations to core
* update xml docs
* Remove GetResource() from ResourceOperationsBase (#22571)
* Change the accessbility to virtual for Resource.Id
* Add SubscriptionContainer tests (#22348)
* Remove GetResource() from ResourceOperationsBase
* Remove GetResource() in ResourceGroup
* Remove GetResource() in Feature
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* Updating code snippets in Samples and Readme (#22518)
* Change the accessbility to virtual for Resource.Id
* Initial setup
* Adding Snippets to tests\Samples
* Generate snippets in markdown files
* Sample 3 code snippets
* Update Sample2_ManagingResourceGroups.cs
* Update Snippets with generator
* Fix Sample2 snippets
* Delete Azure - Backup.ResourceManager.Core.Tests.csproj
* Ignoring dummy subscription id tests
* Adding namespaces to examples
* Modify code snippets in main readme
* Add ignore tags
* Adding Azure.ResourceManager.Core namespace
* Update code snippets
* Adjust indentation
* Removing auto-gen snippets for Sample3
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* nibhati-5273-merge location (#22483)
* Change the accessbility to virtual for Resource.Id
* wip
* WIP
* Update ResourceOperationsBase.cs
* wip
* wip
* wip
* wip
* wip
* update loc based on feedback
* update after merge
* update to core framework tests
* update samples after location changes
* update readme based on code changes
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: Nisha Bhatia <nibhati@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
* add management object group to core (#22592)
* wip
* Add mgmt group to core
* remove temp files
* update to not have nullable but share the same operations between ManagementGroup and ManagementGroupInfo
* address PR comments
* change location to string to return name instead of display name (#22606)
* update location name and corresponding tests
* update comments
* Make the Parent of ResourceContainerBase to be the OperationsBase type (#22589)
* Add WritableSubResource tests (#22618)
* Change the accessbility to virtual for Resource.Id
* Add SubscriptionContainer tests (#22348)
* Change SubResource const…
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REST spec -