Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetResource() from ResourceOperationsBase #22571

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
10f6ad0
Change the accessbility to virtual for Resource.Id
YalinLi0312 Mar 24, 2021
ccc17c7
merge from usptream
Apr 5, 2021
5060f5c
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash Apr 12, 2021
9a9a651
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash Apr 21, 2021
7764cb5
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
YalinLi0312 Apr 23, 2021
832483a
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
YalinLi0312 Apr 28, 2021
3066cd2
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
YalinLi0312 May 6, 2021
9597dc7
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
YalinLi0312 May 6, 2021
86547b0
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash May 10, 2021
4fa650c
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash May 10, 2021
6f858c5
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash May 17, 2021
fb80156
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash May 25, 2021
737171b
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash Jun 2, 2021
4f1408d
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
YalinLi0312 Jun 4, 2021
c5d5790
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash Jun 7, 2021
0bcb9e4
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
YalinLi0312 Jun 7, 2021
2a78d80
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
YalinLi0312 Jun 11, 2021
23eca40
Merge branch 'mgmt-track2' of https://github.com/AME-Redmond/azure-sd…
m-nash Jun 16, 2021
2bddb0e
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash Jun 16, 2021
26e907c
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash Jun 23, 2021
3786863
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash Jun 23, 2021
96fef0c
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash Jul 6, 2021
1d1ebdc
Add SubscriptionContainer tests (#22348)
YalinLi0312 Jul 6, 2021
77abf4b
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
YalinLi0312 Jul 6, 2021
aed679c
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
YalinLi0312 Jul 9, 2021
889dfba
Remove GetResource() from ResourceOperationsBase
YalinLi0312 Jul 9, 2021
165832a
Remove GetResource() in ResourceGroup
YalinLi0312 Jul 9, 2021
db62698
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
YalinLi0312 Jul 9, 2021
d0adf4f
Merge branch 'mgmt-track2' into yall-6022-RemoveGetResource
YalinLi0312 Jul 9, 2021
149511d
Remove GetResource() in Feature
YalinLi0312 Jul 9, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -92,25 +92,6 @@ internal ResourceOperationsBase(ClientContext clientContext, ResourceIdentifier
/// <returns> A <see cref="Task"/> that on completion returns a response with the <see cref="Response{TOperations}"/> operation for this resource. </returns>
public abstract Task<Response<TOperations>> GetAsync(CancellationToken cancellationToken = default);

/// <summary>
/// Get details for this resource from the service or can be overriden to provide a cached instance.
/// </summary>
/// <returns> A TOperations operation for this resource. </returns>
protected virtual TOperations GetResource(CancellationToken cancellationToken = default)
{
return Get(cancellationToken).Value;
}

/// <summary>
/// Get details for this resource from the service or can be overriden to provide a cached instance.
/// </summary>
/// <param name="cancellationToken"> A token to allow the caller to cancel the call to the service. The default value is <see cref="CancellationToken.None" />. </param>
/// <returns> A <see cref="Task"/> that on completion returns a TOperations operation for this resource. </returns>
protected virtual async Task<TOperations> GetResourceAsync(CancellationToken cancellationToken = default)
{
return (await GetAsync(cancellationToken).ConfigureAwait(false)).Value;
}

/// <summary>
/// Lists all available geo-locations.
/// </summary>
Expand Down