Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some unit tests #23046

Merged
merged 1 commit into from
Aug 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ public async Task<PublicIPAddress> CreateDefaultPublicIpAddress(string name, str
Operation<PublicIPAddress> putPublicIpAddressOperation = await publicIPAddressContainer.StartCreateOrUpdateAsync(name, publicIp);
Response<PublicIPAddress> putPublicIpAddressResponse = await WaitForCompletionAsync(putPublicIpAddressOperation);
Assert.AreEqual("Succeeded", putPublicIpAddressResponse.Value.Data.ProvisioningState.ToString());
Response<PublicIPAddress> getPublicIpAddressResponse = await publicIPAddressContainer.GetAsync(resourceGroupName, name);
Response<PublicIPAddress> getPublicIpAddressResponse = await publicIPAddressContainer.GetAsync(name);

return getPublicIpAddressResponse;
}
Expand All @@ -326,7 +326,7 @@ public async Task<NetworkInterface> CreateNetworkInterface(string name, string r
{
Name = ipConfigName,
PrivateIPAllocationMethod = IPAllocationMethod.Dynamic,
//Subnet = new SubnetData() { Id = subnetId }
Subnet = new SubnetData() { Id = subnetId }
}
}
};
Expand All @@ -339,7 +339,7 @@ public async Task<NetworkInterface> CreateNetworkInterface(string name, string r
// Test NIC apis
var networkInterfaceContainer = GetResourceGroup(resourceGroupName).GetNetworkInterfaces();
await networkInterfaceContainer.StartCreateOrUpdateAsync(name, nicParameters);
Response<NetworkInterface> getNicResponse = await networkInterfaceContainer.GetAsync(resourceGroupName, name);
Response<NetworkInterface> getNicResponse = await networkInterfaceContainer.GetAsync(name);
Assert.AreEqual(getNicResponse.Value.Data.Name, name);

// because its a single CA nic, primaryOnCA is always true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,9 @@ public async Task ExpandResourceTest()
await WaitForCompletionAsync(createOrUpdateOperation3);

// Get Nics
await networkInterfaceContainer.GetAsync(resourceGroupName, nic1name);
await networkInterfaceContainer.GetAsync(resourceGroupName, nic2name);
await networkInterfaceContainer.GetAsync(resourceGroupName, nic3name);
await networkInterfaceContainer.GetAsync(nic1name);
await networkInterfaceContainer.GetAsync(nic2name);
await networkInterfaceContainer.GetAsync(nic3name);

// Get lb with expanded nics from nat rules
getLoadBalancer = await loadBalancerContainer.GetAsync(lbName, "InboundNatRules/backendIPConfiguration");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ public async Task AvailablePrivateEndpointTypeTest()
public async Task AvailablePrivateEndpointInResourceGroupTypeTest()
{
var resourceGroup = (await createResourceGroup()).Value;
var types = await ArmClient.DefaultSubscription.GetAvailablePrivateEndpointTypesByResourceGroupAsync(TestEnvironment.Location, resourceGroup.Data.Name).ToEnumerableAsync();
var types = await ArmClient.DefaultSubscription.GetAvailablePrivateEndpointTypesByResourceGroupAsync( resourceGroup.Data.Name, TestEnvironment.Location).ToEnumerableAsync();
Assert.IsNotEmpty(types);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public async Task CleanupResourceGroup()
await CleanupResourceGroupsAsync();
}

private const string Filter_Commmunity = "12076:51004";
private const string Filter_Commmunity = "12076:51006";

[Test]
public async Task RouteFilterApiTest()
Expand Down