Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit tests #23124

Merged
merged 3 commits into from
Aug 5, 2021
Merged

Update unit tests #23124

merged 3 commits into from
Aug 5, 2021

Conversation

dvbb
Copy link
Contributor

@dvbb dvbb commented Aug 5, 2021

update the usage logic of resourceGroup to avoid NullPointerException

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@dvbb
Update unit tests
293211e 
update the usage logic of resourceGroup to avoid NullPointerException
@ghost ghost added Azure.Core customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Aug 5, 2021
@ghost
Copy link

ghost commented Aug 5, 2021

Thank you for your contribution @dvbb! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label Aug 5, 2021
archerzz
archerzz approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with the comments resolved.

@archerzz archerzz merged commit cc89d33 into Azure:feature/mgmt-track2-network Aug 5, 2021
m-nash added a commit that referenced this pull request Aug 31, 2021
@archerzz @m-nash
@bquantump @nisha-bhatia @allenjzhang @YalinLi0312 @HarveyLink @markcowl @JonathanCrd @isra-fel @gearama @ArcturusZhang @fengzhou-msft @scottaddie @ShivangiReja @dvbb
Network mgmt track 2 library (#23049)
85e5e1e 
* initial checkin for core / tests (#18968)

* initial checkin for core / tests

* Add readme.md file

* Fix header in readme

* remove autorest until we convert off hand written types

* update azure.core reference
remove sets to tags
ignore tests which require credentials for now

* Add the proto client which will be used until the autogen work is complete

* Add missing readmes for proto client

* update to require linq 4.0.0 so that don't have to upgrade bcl

* add changlog for CI

* change system.linq.async to update

* update to use source vs binary for the temporary generation of Azure.ResourceManager.Authorization

* Add changelog for azure.resourcemanager.authorization and update version to be beta

* update typos in readme

* update name of proto client sln

* merge in changes from proto repo this week

* fixed unit test failures
missed a few files from the merge from proto repo
updated compute and network sdk version to use latest azure.core with readonly list types

* ignore tests which require live azure until 5122 is closed

* Update failing scenario test

* Subnet Container list still returns SubnetOperations and not Subnet #5584 (#19109)

* 5584

* Update async test

* Test

* WIP: test

* Update Proto.Authorization.csproj

* Update Proto.Authorization.csproj

* Update Proto.Authorization.csproj

* Update Proto.Authorization.csproj

* add param checking to resource (#19134)

* Adding parameter check for track 2 Azure.ResourceManager.core (#19162)

* initial checkin

* adding test cases

* nibhati-5142-add Params and testing for ApiVersionBase.cs (#19193)

* add tests for ApiVersionBase

* update methods

* nibhati - 5142 -  add tests for ArmBuilder.cs (#19231)

* add tests for ArmBuilder

* Update ArmBuilderTests.cs

* Update SubscriptionContainer.cs

* Update test project to consume framework for recorded tests (#19171)

* Update test project to consume framework for recorded tests

* Changes required to get instrumentation working for the new armClient
added support for session recording for onetimesetup and onetimeteardown

* move unit test files

* update tests to not use username for prefix

* update targets to separate existing track 2 libraries from new core until autorest changes are finished

* merge in armbuildertest and update to use new framework

* remove necessity on session files if no onetimesetup

* Address review comments

* Move ApiVersionOverrides to ARMClientOptions class (#19358)

* Rename list operations (#19386)

* tenant resource sample (#19195)

* WIP: tenant resource

* WIP: updates

* Update ResourceIdentifier.cs

* Update ResourceIdentifier.cs

* Update ResourceType.cs

* WIP update check

* WIP

* Add readme for billing

* Stylecop

* WIP

* Remove style

* wip: update

* WIP: updates

* WIP

* WIP: update

* WIP

* Updates

* WIP: updates

* Update

* WIP: updates

* WIP

* Update tests

* WIP: updates

* Remove reference for Azure.Identity (#19434)

* Remove reference for Azure.Identity

* fixing ArmClient construction in proto client

* resync and fix build error

* 5521 - Rename TryGetValue to TryGet/TryGetAsync (#19478)

* Rename TryGetValue to TryGet/TryGetAsync

* Update ContainerBase.cs

* Update ContainerBase.cs

* Update TryGet method and test class

* Update CheckResourceExists.cs

* Rename TryGetValue to TryGet/TryGetAsync

* Update ContainerBase.cs

* Update ContainerBase.cs

* Update TryGet method and test class

* Update CheckResourceExists.cs

* Update ContainerBaseTest.cs

* Update TryGet Test

* Update tests

* Update tests and framework to instrument all clients recursively (#19443)

* Framework changes

* Azure.ResourceManager.Core changes to support client interceptors

* Test changes

* proto client changes

* updates after merge

* Address review comments

* WIP

* updates after WIP

* Update the implicit operator (#19720)

* Remove System.Linq.Async dependency. (#19745)

* Change the accessibility to virtual for Resource.Id (#19804)

* Sku Serialization (#19819)

* Sku Serialization

* Divide Sku class

* Update Sku

* Add lookup mechanism for ID to apiversion (#19437)

* WIP: updates

* WIP: updates

* Update test

* Update ResourceListOperationsTest.cs

* Update CreateSingleVmExample.cs

* Update CreateSingleVmExample.cs

* Update CreateSingleVmExample.cs

* Update CreateSingleVmExample.cs

* WIP: Updates

* Add extra line

* Update

* WIP:

* WIP: updates

* WIp: updates

* Remove API version extensions

* WIP: updates

* Updates

* Update test

* WIP updates

* Updates

* WIP

* Remove blank lines

* Update filtering

* Updates

* Update

* WIP: updates

* WIP: updates

* Add space

* Remove debug

* Updates

* WIP: updates

* WIP

* Change the accessbility to virtual for Resource.Id

* WIP: updates

* WIP Updates

* WIP updates

* WIP

* WIP

* WIP:

* revert

* WIP: updates

* WIP: updates

* WIP: updated

* WIP

Co-authored-by: YalinLi0312 <yall@microsoft.com>

* Resource Identifier changes (#19636)

* Resource Identifier changes

* Adapting Container classes to base class change in Id property

* Fixing xml documentation comments for ResourceType

* Cleaning up resource id ToStrign() and fixing ListLocations client creation

* Adjusting new tenant resource operations for resource id scheme

* Responding to review comments

* Add test coverage, retain string reresentation of resource id

* Fixing additional merge issues

* Updating comparison tests to use concrete variable types

* Plan Serialization (#19820)

* Plan Serialization

* Divide Plan class

* Update Plan

* Mnash 5705 rename container (#19932)

* Change the accessbility to virtual for Resource.Id

* rename ArmClient, ArmClientOptions, Get[Resource]Container

* updates after merge

* missing one file for rename

Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>

* 2 missing renames (#19952)

* Change the accessbility to virtual for Resource.Id

* rename ArmClient, ArmClientOptions, Get[Resource]Container

* updates after merge

* missing one file for rename

* Missed 2 renames

Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>

* nibhati - 5191 - add ClientContext.cs (#19602)

* WIP

* WIP

* Update ResourceOperationsBase.cs

* update for tenant extensions

* update csproj

* Update Azure.ResourceManager.Network.csproj

* update csproj

* update csproj

* WIP

* WIP

* update csproj

* update csproj

* update csproj

* add tests

* update test

* update

* fix test cases to use the diagnostics case fix a missing mocking constructor

* WIP

* update framework for tests

* Update Azure.Test.Perf.csproj

* merge

* revert list json files

* revert

* WIP

* fix ci

* Update Program.cs

* update proto

* fix test

* Update ClientContextTests.cs

* update proto

* Update Azure.ResourceManager.Billing.csproj

* update version

* update ci

* Update Azure.ResourceManager.EventHubs.csproj

* add packable

Co-authored-by: m-nash <prognash@microsoft.com>

* GenericResource Serialization (#19898)

* Resource Serialization

* Plan Serialization

* Divide Plan class

* Divide Resource class

* Update writer

* Update Plan

* TrackedResource Serialization

* Update GenericResource

* Clean Up

* Update GenericResource

* Remove read only

* Update tests

* TrackedResource Serialization (#19855)

* Resource Serialization

* Divide Resource class

* Update writer

* TrackedResource Serialization

* Update Deserialization

* Update Test

* Update Tests

* Update Tracked Resource

* Fix PR

* Remove readonly

* Remove the Get[Resource]Operations methods except for client extensions (#20136)

* Change the accessbility to virtual for Resource.Id

* wip

* ignore test temporarily

* update to remove Get[Resource]Operations

Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>

* nibhati - 5572 - make Credentials and Options internal (#20243)

* Change the accessbility to virtual for Resource.Id

* add transport

* update test

* add jsons

* add json

* remove transport

Co-authored-by: YalinLi0312 <yall@microsoft.com>

* Remove ignore on tests that were failing due to faulted tasks in interceptor (#20341)

* Change the accessbility to virtual for Resource.Id

* remove ignore on tests and update intrumentation to handle faulted tasks

Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <micnash@microsoft.com>

* Make the Reference type generic (#20358)

* Change the accessbility to virtual for Resource.Id

* Make the reference type generic

Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* nibhati 5401 - add CancellationToken to GetResource() (#20396)

* Change the accessbility to virtual for Resource.Id

* add token

Co-authored-by: YalinLi0312 <yall@microsoft.com>

* JonathanCrd 5574 - remove system.collections.immutable (#20437)

* Change the accessbility to virtual for Resource.Id

* Removing package reference to System.Collections.Immutable

* Removing use of ImmutableList

Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* JonathanCrd 5003 - comparison methods for ResourceIdentifier (#20456)

* Change the accessbility to virtual for Resource.Id

* Operators == and != overloads in ResourceIdentifier

* Added EqualsToString Tests and TestCases

Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* update constructors for reference types (#20477)

* update constructors for reference types

* fix stylecop issue

* fixes after merge

* add two way implicit for autorest deserialization (#20557)

* update constructors for reference types

* fix stylecop issue

* add two way implicit for autorest deserialization

* Add a common definition for sub-resource (#20524)

* add SubResource

* serialization of the two classes

* protected internal; full subresource namespace

Co-authored-by: Yeming Liu <yeliu@microsoft.com>

* Add default constructors to resource classes (#20583)

* update constructor signatures for autogen (#20607)

* update constructors for reference types

* fix stylecop issue

* add two way implicit for autorest deserialization

* update constructor signatures for autogen

* Remove ProxyResource since its intended to be used any longer (#20608)

* adding reference constructors attributes (#20611)

* update constructors for reference types

* fix stylecop issue

* add two way implicit for autorest deserialization

* update constructor signatures for autogen

* add attributes to define ctor types for autogen

* Cache the creation of HTTP pipeline in ArmClient (#20636)

* Remove create from container base; remove ArmBuilder abstract class (#20684)

* Remove create from container base; remove ArmBuilder abstract class

* UnTypedContainer->Container; fix doc issues

* make createAsync() virtual

Co-authored-by: Yeming Liu <yeliu@microsoft.com>

* fixes after merge

* adding singleton pattern in Arm.Core and Proto (#20591)

* adding initial singleton base classs and proto code

* PR comment fix.

* Completed singleton VMSS test case.

* Fix merge issue around ArmBuilder removal

* Fix build issue.

* Fixing test failure

* CR comment.

* Flattend the builder to partial classes.

* CR fix

* Update arm response types to match current Azure.Core pattern (#20738)

* WIP

* wip

* Change the accessbility to virtual for Resource.Id

* update strawman for operation changes

* finalize changes before testing

* update ph overloads

* move pipeline creation into armoperation

* wip

* updates based on new OperationInternals

* address PR comments

* update test classes to use new pattern

* final fixes for arm core tests

* use mock response instead of null

* updates to proto code

* add null check around basetype

Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>

* Fix a bug in ArmClient (#20897)

* Move generic resource from resources to core (#20927)

* initial changes to move generic resource items over

* wip updating tests

* more work on test cases

* updates to adapt the operation changes

* remove arm response / operation

* remove unused classes now and finish move resource test

* update resourcegroup operation tests

* update tests for genericresource operations

* add genericresource container tests

* update proto solution

* update proto comments

* address naming comments

* update comments which no longer have inheritance
address wildcard comment in csproj

* update ResourceContainerBase (#20981)

Co-authored-by: Yeming Liu <yeliu@microsoft.com>

* updates to subresource type (#21010)

clean up extensions meant for Operation now

* VM image, extension image (edgezone not included as it is new not in Compute sdk yet) (#20971)

* update reference types and add unit tests to validate (#21031)

* updates to subresource type
clean up extensions meant for Operation now

* need protected internal serialization constructor for reference types, added unit tests to validate for future

* updates after merge

* update policy copying for clone and convert (#21069)

* 5771 - GetGenericResourceOperations in ArmClient (#21066)

* Change the accessbility to virtual for Resource.Id

* GetGenericResourceOperations extension method implementation

* Create ArmClientTests.cs

* Scenario Tests

* GetGenericResourceOperations for single ID

* Single ID tests

* Addressing comments

* Tests recordings

* Tests recordings

Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* 5844 Rename SubResourceWritable to WritableSubResource (#21092)

* Rename symbol

* Rename class

* Rename serialization class

* Merge Azure.ResourceManager.Resources.Models.Subscription with Azure.ResourceManager.Core.SubscriptionData (#20751)

* Initial

* Merge

* Update SubscriptionOperations.cs

* Fix error

* Update using

* Update test

* Fix tests

* Update json

* Update ClientContextTests.cs

* update based on comments

* Add get test

* Remove unnecessary file

* Update LocationListResult.cs

* Update ClientContextTests.cs

* Update operation class & add tests

* move models to model folder

Co-authored-by: m-nash <prognash@gmail.com>

* remove id type from container base to match operation base (#21150)

* remove id type from container base to match operation base

* update proto references

* add support for root resource Id container (#21175)

* remove id type from container base to match operation base

* update proto references

* add support for root resource Id container

* Merge ResourceGroup model in Resources with ResourceGroupData in Core  (#20904)

* Change the accessbility to virtual for Resource.Id

* Merge ResourceGroup model in Resources with Core ResourceGroupData

* Add and update scenario tests

* Resolve merge conflicts

* Update scenario tests

* Record ResourceGroupContainerTests

* Initialize Tags in base class

* Update ResourceGroupOperationsTests and re-record

* Fix the errors in Proto.Client scenario tests

* Move some files in Generated folder back

* Address review comments

* Add records

* Fix the failing test StartExportTemplate

* Address comments

* Change tag lro operations to return its lro type

* Change rg CreateOrUpdate lro operations to return its lro object

* Update CreateOrUpdate lro object

* Run tests

Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* Delete PhTaskDeferringAsyncPageable.cs (#21183)

* Remove PhArmResponse (#21139)

* Remove PhArmResponse part 1

* Remove PhArmResponse part 2

* Delete PhArmResponse.cs

Co-authored-by: m-nash <prognash@gmail.com>

* Remove PhArmOperation (#21290)

* Remove PhArmOperation

* Disable TestResourceTypeFilterParamCheck Test

* Disable SA warning

* remove unused file

Co-authored-by: m-nash <prognash@gmail.com>

* 5841 - Update List methods from proto clients. (#21314)

* Remove List methods with inner Get() call in Compute

* Remove List methods with inner Get() call in Network

* Removing scenario tests referencing deleted List() methods

* Add lambda wrapper in armclient for getting container objects in othe… (#21390)

* Add lambda wrapper in armclient for getting container objects in other RPs

* update xml comments

* 5285 Remove TrackedResource<TIdentifier, TModel> class. (#21376)

* Delete TrackedResource.cs

* Removed class from Core added to individual Proto Libraries

* Removing imported class in Proto.Client

* Add missing new lines

* update to allow external access to a constructor that doesn't have an operation base (#21395)

* Add lambda wrapper in armclient for getting container objects in other RPs

* update xml comments

* update to add externally accesible constructor that doesn't have an operation base like armclient as the parent

* Move Azure.ResourceManager.Resources Tenants objects to Azure.ResourceManager,Core (#21413)

* Change the accessbility to virtual for Resource.Id

* Move Azure.ResourceManager.Resources Tenants objects to Azure.ResourceManager.Core

* Resolve conflicts

Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* Templetize SubResource and WritableSubResource classes, and added unit tests (#21397)

* Change the accessbility to virtual for Resource.Id

* Sub resource template and tests

* public class , public constructor

* some PR comments

* PR comments and phonecall around silent errors and casting

Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* Remove the suppression for namespace in mgmt sdks (#21534)

* remove no warn AZC0001

* remove the namespace warn suppression from mgmt plane sdks

* remove old todo

* update tenant and subscription list resource hooks to follow the same pattern (#21568)

* fix the attribute of subresource (#21685)

* fix the attribute of writableSubResource (#21688)

* Add ArmClient tests (#21620)

* Change the accessbility to virtual for Resource.Id

* Add tests for ArmClient

* Address review comment

* Update recordings

Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* Add GenericResourceContainer tests (#21759)

* Change the accessbility to virtual for Resource.Id

* Add CreateOrUpdate tests

* Add StartCreateOrUpdate tests

* Add Get tests

* Add GetApiVersion and ListByResourceGroup tests

* Update test records

Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* Bug System.ArgumentOutOfRangeException thrown in ResourceIdentifier - 5879 - nibhati (#21537)

* add list resources apis to resourceGroupOperations (#21809)

* [Azure.ResourceManager.Core] Introduce the `UseClientContext` to `SubscriptionOperations` and `ResourceGroupOperations` (#21811)

* introduce the useClientContext to subscriptionOperations and ResourceGroupOperations

* resolve comments

* resolve comments

* fix compile errors in other solutions

* Add ResourceGroupContainer tests (#21832)

* Change the accessbility to virtual for Resource.Id

* Add ResourceGroupContainer tests

Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* remove ph classes (#21852)

* remove ph classes

* add temp files to proto

* change Parent in ContainerBase to OperationsBase type (#21872)

* Add GenericResourceOperations tests (#21828)

* Change the accessbility to virtual for Resource.Id

* Add GenericResourceOperations tests

* Merge GenericResourceOperationsTests and GenericResourceTests

Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* Add ResourceGroupOperations tests (#21893)

* Change the accessbility to virtual for Resource.Id

* Add ResourceGroupOperations tests

* Remove parallelizable tag

* Update session records

Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* update to be inside core namespace (#21892)

* update to be inside core namespace

* update proto references to removed namespace

* remove references from test proj

* remove unused interfaces (#21898)

* update to be inside core namespace

* update proto references to removed namespace

* remove unused interfaces

* Add ResourceGroupBuilder tests (#21897)

* Change the accessbility to virtual for Resource.Id

* Add ResourceGroupBuilder tests

* Address comment

* Extract the test for Build() to a seperate method

Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* Update Track 2 Mgmt Plane Template (#21876)

* Update Track 2 Mgmt Plane Template

* Moving the package ref into the actual project file

* Fixing Management tests and updating sln to include missed project

* Update build for core.test and invert the mgmt shared test code include.

* Fix CI

* Add ResourceGroupDeleteOperation tests (#21927)

* 5966 sync code coverage fix (#21925)

* consolidate test classes

* update interceptors to get code coverage on sync methods for LRO responses

* Remove ArmResponse since that is no longer needed

* update test cases that moved with recordings

* remove TA dependency on core sln

* put back ai dependency which we should remove

* update to cover .net 5 case

* consolidate code

* remove extension sub classes since they aren't needed (#21945)

rename some parameters

* Mnash apiview cleanup (#21952)

* remove extension sub classes since they aren't needed
rename some parameters

* update instrumentation for generic resource and tenant

* remove Get() from ResourceOperationsBase (#21963)

Co-authored-by: Yeming Liu <yeliu@microsoft.com>

* update to use zero wait on playback (#22066)

* update to use zero wait on playback

* update resourcemanager ci to run when shared files change

* one more mgmt shared folder

* Update sub resource CC to 94%. (#22117)

* Add ResourceGroupsRestOperations tests (#21981)

* Added support for implicit provider resource type ResourceIdentifier p… (#22142)

* Added support for impicit provider resource type ResourceIdentifier parsing

* Update clearer list name based on CR comment

* Azure.ResourceManager.Core readmes and samples (#21858)

* Change the accessbility to virtual for Resource.Id

* Readme and sample files

* Fixing links

* Fixing links

* Fixing links

* Delete OLD README.md

* Migrating to new SDK

* samples rename

* Update ManagingResourceGroups.md

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

* Addressing comments in Managing Resource Groups example

* Hello World added

* Update Sample1_HelloWorld.md

* Delete README.md

* Create README.md

* Addressing HelloWorld comments

* Apply suggestions from code review

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

* Addressing comments in readme

* Commenting relative links

* Fix CI Link errors

* Fixing CI errors

* Snippets IDs deleted

* Changing Prerequisites and Auth info

* Don't use .Construct in rg example

* Migration guides in future PR

* Fix CI

* Prerequisites

* Remove Links comments temporarily

* Typo in Readme

* Apply suggestions from code review

Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>

* Changing all links to absolute links

* Spelling

* Commenting not existing links

* Fix CI

* Typo

* Update Sample1_HelloWorld.md

* Apply suggestions from code review

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>

* Move Providers and ProviderOperations from Azure.ResourceManager.Resources into Azure.ResourceManager.Core-nibhati-5862  (#21337)

* Change the accessbility to virtual for Resource.Id

* WIP

* WIP

* WIP

* wip

* Update TenantOperations.cs

* wip

* WIP

* wip

* wip

* wip

* wip

* fix formatting

* wip

* Update ProviderContainer.cs

* Update ProviderContainer.cs

* wip

* wip

* Update ProviderContainerTests.cs

* wip

* wip

* update to interceptor to handle targetinvocation on a failed task

* remove expand parameter from LoadApiVersion methods

Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* remove need to copy policies (#22280)

* Add ResourceListOperations tests (#22279)

* Change the accessbility to virtual for Resource.Id

* Add ResourceListOperations tests

Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* remove proto (#22282)

* feat(network): initial track2 mgmt sdk preview

* update version information

* feat(network): update track2 codes according to latest autorest.csharp

* update according to the latest change in autorest.csharp

* update test base

* modify target runtime framework

* update test case base to use the new redesigned base class

* update mgmt-track2-network 2021-08-02 (#23042)

* Follow up PR - 5593 Azure.ResourceManager.Core Readme (#22262)

* Change the accessbility to virtual for Resource.Id

* Changing temporary links to absolute ones.

Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* Add PropertyReferenceType attribute in ResourceIdentity (#22255)

* Add PropertyReferenceTypeAttribute attribute in ResourceIdentity

* Feedback

* remove resources dependency (#22293)

* wip

* remove remaining references to azure.resourcemanager.resources

* update tests to handle new changes

* update summary for gets or sets

* Updating GenericResource.Lists to return GenericResourceExpanded. (#22284)

* Updating GenericResourceList to return GenericResourceExpanded

* Added missing expand and related test cases.

* Adding missing test recordings.

* cleanup the warnings that were supressed (#22318)

* fix CA1036

* remove CA1067

* remove CA1065

* remove SA1028

* Exposing expand on ListAtContext as well in preparation to expose that in each of the generated ListAsGeneric methods in autorest (#22351)

* Updating GenericResourceList to return GenericResourceExpanded

* Added missing expand and related test cases.

* Adding missing test recordings.

* Exposing expand on ListAtContext as well in preparation to expose that in each of the generated ListAsGeneric methods in autorest

* update according to latest autorest.csharp

1. update package reference of `Azure.ResourceManager` to latest
2. generate codes according to latest autorest.csharp
3. fix test cases

AB#6018

Co-authored-by: Jonathan Cárdenas <JonathanCrd@users.noreply.github.com>
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com>
Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>
Co-authored-by: Allen Zhang <allenzhang@live.com>

* fix some unit tests (#23046)

1. incorrect parameter sequence in `NetworkClientTestBase`, `ExpandRouteTests` and `PrivateEndpointTests`
2. update `Filter_Commmunity ` for `RouteFilterTests`

* refactor(network): update autorest.md for preview

1. update `require` and `use` directives to point to online assets
2. update `$ref` value in the model transform directive for `DdosProtectionPlan` to work around a limitation: Azure/autorest#4237
3. set up a local swagger definition tag `package-track2-preview`, since 4 definitions are excluded from this release

* Update unit tests (#23124)

* Update unit tests
  * update the usage logic of resourceGroup to avoid NullPointerException
* Update ManagementInterceptor.cs
* Update ExpandResourceTests.cs

* test(network): update tests of 6 PRs (#23126)

update test cases for the following resources:
- ApplicationSecurityGroup
- PublicIpPrefix
- RouteFilter
- NetworkWatcher
- DDosProtectionPlan
- PrivateEndpoint

changes are:
- add missing `[RecordedTest]` annotation
- use `DefaultSubscription.ResourceGroups().CreateOrUpdateAsync` to create resource groups
- fix `RouteFilterTests` in generating assets names
- update test records for the impacted tests accordingly
- clean up some dead commented codes

* test(network): update unit tests

* Replace synchronous calls to asynchronous calls to avoid NPE
* Update the usage logic of resourceGroup to avoid NullPointerException
* Update ManagementInterceptor.cs
* Update ExpandResourceTests.cs
* Format some tests

* test(network): re-generate codes after disabling playload flattening

1. Remove the following properties from `csproj` files. Those are not necessary and could cause potential maintenance issues.
  * TargetFrameworks
  * ExcludeMgmtCoreShared
  * IsMgmtSubLibrary
  * NoWarn
  * Package reference to `Azure.ResourceManager`
2. Update `autorest.md`:
  * disable playload flattening in `autorest.md`
  * remove `use` directive to use the latest one version (right now it's `20210804.1`) of autorest.csharp
  * remove workaround for `DDosProtectionPlan` in ADO 6068
3. Regenerate codes and update broken test cases due to interface changes

AB#6068

* update to use new compute package and no longer depend on old track 2

* test(network): clean up some broken test cases (#23265)

* Follow up PR - 5593 Azure.ResourceManager.Core Readme (#22262)

* Change the accessbility to virtual for Resource.Id

* Changing temporary links to absolute ones.

Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>

* Add PropertyReferenceType attribute in ResourceIdentity (#22255)

* Add PropertyReferenceTypeAttribute attribute in ResourceIdentity

* Feedback

* remove resources dependency (#22293)

* wip

* remove remaining references to azure.resourcemanager.resources

* update tests to handle new changes

* update summary for gets or sets

* Updating GenericResource.Lists to return GenericResourceExpanded. (#22284)

* Updating GenericResourceList to return GenericResourceExpanded

* Added missing expand and related test cases.

* Adding missing test recordings.

* cleanup the warnings that were supressed (#22318)

* fix CA1036

* remove CA1067

* remove CA1065

* remove SA1028

* Exposing expand on ListAtContext as well in preparation to expose that in each of the generated ListAsGeneric methods in autorest (#22351)

* Updating GenericResourceList to return GenericResourceExpanded

* Added missing expand and related test cases.

* Adding missing test recordings.

* Exposing expand on ListAtContext as well in preparation to expose that in each of the generated ListAsGeneric methods in autorest

* test(network): clean up some broken test cases

## Update the depending libraries:
- update `Azure.ResourceManager` to version `1.0.0-alpha.20210804.1`
- remove `Azure.ResourceManager.Resource`
  - we should restore to use the new release later
- remove `Azure.ResourceManager.Storage`
  - we should change to use `Azure.ResourceManager` later
- update `Azure.ResourceManager.Compute` to latest dev build version
  - we should change to use `Azure.ResourceManager.Resource` later

## Disable test cases
disable the following storage related test cases which are not required for preview, but we may restore them afterwards.
- FlowLogTests
- TroubleshootTests

## Other Changes
- Implement `CreateWindowsVM` and `CreateLinuxVM` using compute SDK
- Change return value of `CreateResourceGroup` to `Task<ResourceGroup>`
- Fix some broken API due to removal of `ResourceGroupsOperations`
- Fix synchronous invocation in `NextHopTests`

AB#6018

Co-authored-by: Jonathan Cárdenas <JonathanCrd@users.noreply.github.com>
Co-authored-by: YalinLi0312 <yall@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com>
Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>
Co-authored-by: Allen Zhang <allenzhang@live.com>

* Revert "Merge branch 'main' into feature/mgmt-track2-network"

This reverts commit 4fc3468, reversing
changes made to 9bd9e69.

* build(network): fix missing commit id in md file url

The `autorest.md` file URL in `require:` directive doesn't contain the commit id.
This commit will add the specific commit ID, so as not to fail the build.

* test(network): remove dependency on `Compute`

1. replace compute api with generic api to manage compute resources
2. remove references to compute sdk in project

AB#6018

* Revert "Revert "Merge branch 'main' into feature/mgmt-track2-network""

This reverts commit f7a2ef5.

# Conflicts:
#	sdk/batch/Microsoft.Azure.Batch/CHANGELOG.md
#	sdk/batch/Microsoft.Azure.Batch/src/Microsoft.Azure.Batch.csproj
#	sdk/keyvault/Azure.Security.KeyVault.Administration/CHANGELOG.md
#	sdk/keyvault/Azure.Security.KeyVault.Certificates/CHANGELOG.md
#	sdk/keyvault/Azure.Security.KeyVault.Keys/CHANGELOG.md
#	sdk/keyvault/Azure.Security.KeyVault.Secrets/CHANGELOG.md
#	sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/HttpHelper.cs
#	sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Tests/HttpHelperTests.cs
#	sdk/servicebus/Azure.Messaging.ServiceBus/CHANGELOG.md

* test(network): adopt latest autorest.csharp

1. use latest version `20210812.2` of autorest.csharp to re-generate the codes
2. update test cases according to the latest interface
3. update dependency

AB#6018

* upgrade autorest.csharp to `3.0.0-beta.20210812.2`

* update API

* test(network): add application gateway test case

* Update unit tests

update the usage logic of resourceGroup to avoid NullPointerException

* Update ManagementInterceptor.cs

* Update ExpandResourceTests.cs

* test(network): Update unit tests

1. Update some tests to avoid NPE
2. Formatting some tests

* test(network): Update test cases

1. Reconstruct case of AppGateway
2. Update TestBase.cs

* Update NetworkServiceClientTestBase.cs

* Update ApplicationGatewayTests.cs

* docs(network): samples for track2 network mgmt sdk (#23360)

1. change version to `1.0.0-preview.3`
2. update `README.md` and `CHANGELOG.md`
3. add sample test cases and docs with code snippets

AB#5578

* feat(network): udpate according to latest code gen

- re-generate based on the latest `autorest.csharp`
- update test case accordingly
- remove hard-coded dependency on `Azure.Core` 1.18-alpha
- fix some test case errors

AB#6018

* feat(network): update according to latest code gen

- re-generate the codes according to the latest `autorest.csharp` version `3.0.0-beta.20210822.2`
- remove version override of `autorest.csharp` in test project
- fix compilation errors due to constructor interface change in `GenericResourceData`

AB#6018

* test(network): remove unused teardown

- remove all commented teardown methods
- remove teardown methods that only delete resources within resource group, which is not necessary since deleting a resource group will delete all belonging resources

AB#6018

* test(network): re-record some tests after re-gen codes

- ApplicationSecurityGroupTests
- DdosProtectionPlanTests
- GatewayOperationsTests
- LoadBalancerTests
- NetworkInterfaceTests
- NetworkSecurityGroupTests
- NetworkWatcherTests
- PublicIpAddressTests
- PublicIpPrefixTests
- RouteFilterTests
- RouteTableTests
- RouteTests
- SecurityRuleTests
- SubnetTests
- UsageTests
- VirtualNetworkPeeringTests
- VirtualNetworkTests

AB#6018

* test(network): fix access privilege of setup methods of sample tests

Change for `private` to `protected`

AB#6018

* docs(network): update samples after re-gen code

* test(network): add `Azure.Identity` in dependency

`Azure.Identity` is required for sample tests.

* feat(network): update export interface after re-gen

* test(network): update cases (#23492)

1. update VnetGateway test case
2. resolve review comments
3. add record file

* test(network): update tests to verify some ado fixes

- uncommet some previous commented test codes due to the following ADO:
  - 6030
  - 6080
  - 6005
- comment some test codes due to ado 5975
- record some tests

AB#6018

* test(network): fix some broken tests

- comment out problematic test codes and leave corresponding ADO
- add missing `[RecordedTest]`
- update recording

AB#6018

* feat(network): re-generate according to latest `Azure.ResourceManager` and `autorest.csharp`

AB#6018

* test(network): update test cases and recording

- record some test cases again
- fix some test cases due to known issues

AB#6018

* remove `Azure.ResourceManager.Core`

For some reason unkown, it's not removed. And it breaks release pipeline due to invalid URL links.

* docs(network): change version of initial network track2 mgmt library to `beta.1`

- change the version from `preview.3` to `beta.1`
- update chnage logs accordingly

AB#5578

* feat(network): re-generate codes

Re-generate the codes according to the latest `Azure.ResourceManager` and `autorest.csharp`.

* feat(network): update export API

* test(network): update tests after re-gen

- disable some test codes due to ADO issues
- record some test cases again

AB#6018

* feat(network): bump version in common package props to `1.0.0-alpha.20210827.3`

bump version of `Azure.ResourceManager.Network` to `1.0.0-alpha.20210827.3`

* test(appconfiguration): adopt network mgmt track2 preview library

- replace old `NetworkManagementClient` with `ArmClient`
- replace old network operations with mgmt track2 preview api
- update test recording

* test(eventhubs): adopt network mgmt track2 preview library

- replace old `NetworkManagementClient` and `ResourceManagementClient` with `ArmClient`
- replace old network/resource operations with mgmt track2 preview SDK
- update test recording

* test(eventhub): comment out failure test step due to sanitized recording

Comment out some test steps due to the following error **in playback mode only**:
> Error Message:
     Expected: not equal to "Sanitized"
  But was:  "Sanitized"

Those could be due to the fact that test framework will sanitize some content it thinks
senstivie during recording. So in the plyaback mode, the tests will fail.

* feat(network): adopt resoure manager 1.0.0-beta.2

- pull in `main` branch for resource manager 1.0.0-beta.2 and other changes
- re-generate the codes
- fix broken test cases due to interface change

* feat(network): bump version to 1.0.0-alpha.20210830.2

* feat(eventhub, appconfiguration): adopt resource manager 1.0.0-beta.2

update test cases to fix the borken interface

* build(sdk): enlarge memory of nodejs vm

`network` has 50 swagger files which will cause out-of-memory error in autorest.
Accoring to [autorest faq], we can enlarge the memory through environment variable.
Adding `memory` in autorest config doesn't work, because either release pipeline is not using the latest version of autorest, or the change is not in latest version yet.

* updates for release

Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>
Co-authored-by: bquantump <53361486+bquantump@users.noreply.github.com>
Co-authored-by: nisha-bhatia <67986960+nisha-bhatia@users.noreply.github.com>
Co-authored-by: Allen Zhang <allenzhang@live.com>
Co-authored-by: Yalin Li <yall@microsoft.com>
Co-authored-by: Minghao Chen <30464227+HarveyLink@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: m-nash <prognash@microsoft.com>
Co-authored-by: m-nash <prognash@gmail.com>
Co-authored-by: m-nash <micnash@microsoft.com>
Co-authored-by: Jonathan Cárdenas <JonathanCrd@users.noreply.github.com>
Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com>
Co-authored-by: Yeming Liu <yeliu@microsoft.com>
Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com>
Co-authored-by: Arcturus <dapzhang@microsoft.com>
Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com>
Co-authored-by: Tier Ruan <61542202+dvbb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archerzz archerzz archerzz approved these changes

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@m-nash m-nash Awaiting requested review from m-nash

@pakrym pakrym Awaiting requested review from pakrym

@yungezz yungezz Awaiting requested review from yungezz

Assignees
No one assigned
Labels
Azure.Core Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvbb @archerzz