Public API spell check #23150
Merged
Public API spell check #23150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
weshaggard
reviewed
Aug 6, 2021
|
To keep track of the opted-out ones, could you make sure the list here is updated? |
danieljurek
force-pushed
the
djurek/spellcheck-public-api-opt-out
branch
from
ece84a9 to
9a75e0c
Compare
…move. Opt out agrifood which has some false positives.
…om the opt-out list
…tly necessary in aggregate-reports.yml, in that case it is meant to make invocation of cspell consistent
danieljurek
force-pushed
the
djurek/spellcheck-public-api-opt-out
branch
from
9a75e0c to
b1fb6e8
Compare
danieljurek
requested review from
AlexGhiondea,
chidozieononiwu and
maririos
as code owners
This was referenced Aug 6, 2021
This was referenced Aug 6, 2021
weshaggard
approved these changes
Aug 9, 2021
pakrym
reviewed
Aug 10, 2021
chidozieononiwu
approved these changes
Aug 10, 2021
…to the list of words so Core has zero spelling errors
…t is handled in cspell.json
…ell checking. The previous pattern was including tests folders unnecessarily
|
@danieljurek I assume you still need to go through the issues and update them with the new instructions. At least the one I randomly checked #23172 still had the old instructions. |
|
Instructions are updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opted out (has spelling errors in public api):
Opted in (no change to
ci.yml):