Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BatchAccountIdentity constructor breaking change #23633

Closed
wants to merge 14 commits into from
Closed

BatchAccountIdentity constructor breaking change #23633

wants to merge 14 commits into from

Conversation

paterasMSFT
Copy link
Contributor

@paterasMSFT paterasMSFT commented Aug 29, 2021 •
edited
Loading

The previous release introduced a breaking type ambiguity to BatchAccountIdentity's constructor. This PR corrects that.

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the Batch label Aug 29, 2021
@paterasMSFT paterasMSFT changed the title Mipatera/batchaccountidentityfix Fix BatchAccountIdentity breaking change Aug 29, 2021
@paterasMSFT paterasMSFT changed the title Fix BatchAccountIdentity breaking change BatchAccountIdentity constructor breaking change Aug 29, 2021
@paterasMSFT paterasMSFT force-pushed the mipatera/batchaccountidentityfix branch 4 times, most recently from 8c4e48d to 1a876ec Compare August 31, 2021 22:25
@paterasMSFT paterasMSFT marked this pull request as ready for review September 24, 2021 17:35
@paterasMSFT paterasMSFT force-pushed the mipatera/batchaccountidentityfix branch from 4e4cc5f to 9bb932c Compare September 26, 2021 17:53
paterasMSFT and others added 4 commits October 26, 2021 10:40
@paterasMSFT
Fixed BatchAccountIdentity constructor breaking change.
5215e0f 
Changed test location for CloudService test.

Update changelog and version.

Added more legacy constructors.

Fixed constructor and test
@paterasMSFT
Updated session records
8a69cdd 
Session records
@dpwatrous @paterasMSFT
Add another 2 argument constructor for BatchAccountIdentity
9a861ae
@dpwatrous @paterasMSFT
Mark legacy identity class and related constructor as obsolete
d8f01d8
@paterasMSFT paterasMSFT force-pushed the mipatera/batchaccountidentityfix branch from 9bb932c to d8f01d8 Compare October 26, 2021 14:40
paterasMSFT and others added 5 commits October 26, 2021 14:48
@paterasMSFT
Revert "Added nuget config to fix package build order issue."
4c74400 
This reverts commit b59ade3.
@paterasMSFT
Updated batch version
86a050d
@dpwatrous @paterasMSFT
Mark legacy identity class and related constructor as obsolete
a1ac493 
Added nuget config to fix package build order issue.

Revert "Added nuget config to fix package build order issue."

This reverts commit b59ade3.

Updated batch version

Revert "Updated batch version"

This reverts commit 86a050d.
@paterasMSFT
Updated package version
0fbd7e6
@paterasMSFT
Merge branch 'mipatera/batchaccountidentityfix' of https://github.com…
fcbcebb 
…/Azure/azure-sdk-for-net into mipatera/batchaccountidentityfix
@paterasMSFT
Revert "Merge branch 'mipatera/batchaccountidentityfix' of https://gi…
a966cb0 
…thub.com/Azure/azure-sdk-for-net into mipatera/batchaccountidentityfix"

This reverts commit fcbcebb, reversing
changes made to 0fbd7e6.
wiboris
wiboris approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@wiboris wiboris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good

@paterasMSFT paterasMSFT marked this pull request as draft October 27, 2021 18:34
@paterasMSFT
Removed GeneratePackageOnBuild
4c66346 
Revert "Set RestorePackagePath"

This reverts commit f69ea24ed26d600c35d2df438804a8e7f121b731.

Removed GeneratePackageOnBuild

This resolved a packing issue. See [here](dotnet/sdk#10335) for more information.
@paterasMSFT paterasMSFT force-pushed the mipatera/batchaccountidentityfix branch from f69ea24 to 4c66346 Compare October 27, 2021 19:12
@paterasMSFT paterasMSFT marked this pull request as ready for review October 27, 2021 21:32
@paterasMSFT
Updated session recordings.
7310ca0 
Updated location filter value to fix scenario test.
@paterasMSFT paterasMSFT force-pushed the mipatera/batchaccountidentityfix branch from 1c831e3 to 7310ca0 Compare November 1, 2021 17:02
@paterasMSFT
Copy link
Contributor Author

paterasMSFT commented Nov 1, 2021 •
edited
Loading

Creating new PR from a new branch to clean up commit history which involved merges.

@paterasMSFT paterasMSFT closed this Nov 1, 2021
@jsquire jsquire deleted the mipatera/batchaccountidentityfix branch July 15, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@dpwatrous dpwatrous dpwatrous approved these changes

@wiboris wiboris wiboris approved these changes

@archerzz archerzz Awaiting requested review from archerzz archerzz is a code owner

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@Yao725 Yao725 Awaiting requested review from Yao725

@bgklein bgklein Awaiting requested review from bgklein

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@danieljurek danieljurek Awaiting requested review from danieljurek

Assignees

@dpwatrous dpwatrous

Labels
Batch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paterasMSFT @dpwatrous @weshaggard @wiboris