Add provisioner OID to initial MHSM admins #23929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary after Azure/azure-sdk-tools#1983 is merged.
ghost
added
the
jsquire
approved these changes
Sep 10, 2021
| "provisionerApplicationOid": { | ||
| "type": "string", | ||
| "metadata": { | ||
| "description": "The provisioner OID to grant access to test resources." |
There was a problem hiding this comment.
Should we note that this is used as the admin for any resources that require one?
There was a problem hiding this comment.
I don't think it necessary. Honestly, adding these descriptions was more for me and future maintainers, for which you can just look where they are used anyway. The description here is still technically accurate, as - as an admin - they do have permissions to do almost anything in the MHSM.
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
May 19, 2023
[PostgreSQL] Allow network property to be updated during PG flexible server update (Azure#23929) * Allow entwork property to be updated during PG flexible server update * Updated description to explicitly specify when delegatedSubnetResourceId and privateDnsZoneArmResourceId are required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary after Azure/azure-sdk-tools#1983 is merged.