Initial set of API changes for Schema Registry #24285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLove-msft
requested review from
KrzysztofCwalina and
tg-msft
as code owners
ghost
added
the
JoshLove-msft
requested review from
jsquire,
conniey,
yunhaoling,
swathipil and
deyaaeldeen
|
API changes have been detected in this PR. You can review API changes here |
jsquire
approved these changes
Sep 28, 2021
sdk/schemaregistry/Azure.Data.SchemaRegistry/src/Generated/SchemaRestClient.cs
Show resolved
Hide resolved
sdk/schemaregistry/Azure.Data.SchemaRegistry/tests/Samples/Sample01_ReadmeSnippets.cs
Outdated
Show resolved
Hide resolved
|
API changes have been detected in this PR. You can review API changes here |
deyaaeldeen
reviewed
Sep 28, 2021
| @@ -90,7 +90,7 @@ Register a schema to be stored in the Azure Schema Registry. When registering a | |||
|
|
|||
| ```C# Snippet:SchemaRegistryRegisterSchema | |||
| string name = "employeeSample"; | |||
| SerializationType type = SerializationType.Avro; | |||
| SchemaFormat format = SchemaFormat.Avro; | |||
There was a problem hiding this comment.
I still see mentions of serialization type & content in the readme outside the code snippets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #24035