-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests for resourcemanager version update #24872
Conversation
Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>
…hou-msft/azure-sdk-for-net into remove_defaultSubscription_fix_RPs
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
Release machinelearningservices microsoft.machine learning services 2023 08 01 preview (Azure#24762) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-06-01-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * MFE 2023-08-01-preview mfe.json (Azure#24764) * add mfe.json * labeling jobs update descriptions * add examples for ServerlessEndpoint * update labelingjob examples * label job examples remove additional properties * adding sku to patch * add identity to patch * add in operationresult to examples --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * Adding Resources at sweep level (Azure#25090) Co-authored-by: Anubha98 <anubhajain@microsoft.com> * HoboVM Preview Features (Azure#24769) * Update Pricesheet properties for savingsPlan (Azure#24708) * Update consumption.json * Update PriceSheet.json * Update consumption.json * Update PriceSheet.json * Update consumption.json * Update PriceSheet.json * Update consumption.json * Update consumption.json * Update consumption.json * Update PriceSheet.json * elasticsan preview refresh microsoft.elasticsan 2022-12-01-preview (Azure#24494) * Adds base for updating Microsoft.ElasticSan from version preview/2021-11-20-preview to version 2022-12-01-preview * Updates readme * Updates API version in new specs and examples * Added PE related changes * Added Private Link resource API * Nit change to correct the path for privateLinkResource API * Updated Lint errors * prettier check * resolved comments & added publicNetworkAccess * removed publicNetworkAccess & NIT changes * Updated the list operations * resolved lintDiff * proper value for examples and removed value from PECollections * resolved comments * spell check resolved * removing volumeCreateParameter * [Hub Generated] Publish private branch 'InbalZim-storagemover-Microsoft.StorageMover-RPSaaSMaster-2023-07-01-preview' (Azure#24390) * add or modify files * Updated `credentials` models according to PR Azure#24318 + reverted unwanted changes to `readme.md` * Removed URI format from SMB credentials to support it receiving empty string in order to clean-up their value * Removed extra hierarchy of `AzureStorageFileShareEndpointBaseProperties` * improve NR Examples (Azure#24636) * improve NR Examples * addressing AutoRun Errors * Fixing Prettier Issue * Adding NextLink in Max Examples * Formatting Azure Resource Id * Updating Format of azure subscriptionIds * update code owner (Azure#24754) * Update readme.python.md (Azure#24758) * [TypeSpecValidation] Refactor package.json (Azure#24756) - Improves upon Azure#24745 - Creates eng/tools/package.json for all EngSys tools - Moves "postinstall" to eng/tools/TypeSpecValidation/package.json - Technically incorrect if the package were ever to be published to a registry - In practice, the best way I have found so far to use source-based tools in a TypeScript repo * Add resize APIs * workflow-bot comments: update breaking changes alternative C to point to alternative B (Azure#24770) * Add properties for os patching (Azure#24775) Co-authored-by: Chris Jiang <chrjia@microsoft.com> * [Communication] Job Router Public Preview v2022-07-18 (Azure#23804) * Updated JR swagger with maxNumberOfJobs * job scheduling swagger changes * Enforce DistributionMode.kind to be read-only * retry with removing Required tag from abstract property for DistributionMode * WorkerState stopped showing up in generated swagger * Add reofferTimeUtc to decline offer API * Prettier * Prettier * rename WorkerState to RouterWorkerState * more fixes in polymorphic types * Rename decline offer request * prettier fix * add example for scheduled job * cpsell fix * fix response schema validation error * address review feedback item round 1 * SDK review changes * More API changes * Update distribution mode required properties * Renamings * job matching mode added * prettier fixes * fix examples refs * update ref examples * update swagger spec * fix enum mismatch * change operator to labelOperator in classification policy get and update ops example * Update specification/communication/data-plane/JobRouter/preview/2022-07-18-preview/communicationservicejobrouter.json Co-authored-by: Liangying.Wei <lianwei@microsoft.com> * hide redundant communicationerror and communicationerrorresponse during codegen * revert commit * fix typo * test whether removing kind from request works * revert removing kind from request * make kind read-only * run prettier * try adding properties to empty classes --------- Co-authored-by: Rajarshi Sarkar 🦄 <rsarkar@microsoft.com> Co-authored-by: Rajarshi Sarkar <73562869+sarkar-rajarshi@users.noreply.github.com> Co-authored-by: Liangying.Wei <lianwei@microsoft.com> * [OpenAI] Rename properties for Java (Azure#24596) * renames * more renames * testing on the deploymentOrModelName * revert for no breaking changes * [TypeSpec] Upgrade to 0.46.0 (Azure#24776) * Release quota on stop (Azure#24778) * Release quota on stop * add ReleaseQuotaOnStop to computeinstance properties * update * rm * [OpenAI] Update generated autorest (Azure#24788) - Continuation of Azure#24596 * Dynatrace.Observability merge to public repo (Azure#24101) * Initial Commit * Updating version in all files * Removed version from readme * removing version which are not available from readme * Resolving PR comments (Azure#24205) * Features/users/abhargava/merge to public repo (Azure#24230) * Resolving PR comments * Features/users/abhargava/merge to public repo (Azure#24233) * Resolving PR comments * Responding to the comment in PR review * Fixed typo * Features/users/abhargava/merge to public repo (Azure#24253) * Resolving PR comments * Responding to the comment in PR review * Fixed typo * Added a suppression for Avacado issue * Adding the required field * Updating suppression reason * Updating path for suppression * Adding suppression for deprecated API * suppression * suppress * Update specification/dynatrace/resource-manager/readme.md Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * updating path in suppression * updating suppression * updating suppression * Update specification/dynatrace/resource-manager/readme.md: WIP: fixing suppressions Iteratively work on fixing suppressions * Update readme.md: update suppressions * Update readme.md: update suppressions * Update readme.md: remove Avocado suppressions --------- Co-authored-by: kanupriyasinghh <113429657+kanupriyasinghh@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> * Double Header Fix (Azure#24760) * [OpenAI.Inference] Adding content filter support (Azure#24652) * first-pass adding annotation * FilterResult definitions * move Filter definitions to common * cleaning up naming and imports * adding version headers * added descriptions to objects * correct self_harm JSON projection * Correct to "prompt_annotations" * "prompt_annotations" for chat, too * Update specification/cognitiveservices/OpenAI.Inference/models/completions.common.tsp Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> * Add per-choice content_filter_results to /completions * tsp compile after merge * recompile with 0.46.0 after today's update --------- Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com> Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> * Update OpenAI PR assignment (Azure#24794) * Update OpenAI PR assignment * Update pull_request_assignment.yml * [typespec-ci] Automatically detect spec folders to validate (Azure#24629) * [fist] mgmt, update service name (Azure#24781) * [typespec-pr] Add pipeline (Azure#24802) * [typespec-ci] Remove path wildcard (Azure#24804) * Update engsys CODEOWNERS (Azure#24808) * Align optionality of content filter categories (Azure#24819) * Add spec ARM PR review workflow diagram to ARM PR description template. (Azure#24823) * Add spec PR review workflow diagram to ARM PR description template. * Update control_plane_template.md: fix link to diagram (Azure#24828) * Added generator config for OpenAI `Functions` for the Java SDK (Azure#24765) * Remove repeatability support for token revocation endpoint (Azure#24589) * Update clientTYpe (Azure#24503) * [Hub Generated] Publish private branch 'dev-maintenance-Microsoft.Maintenance-2023-04-01' (#24048) * Revert "Revert "[Hub Generated] Publish private branch 'dev-maintenance-Microsoft.Maintenance-2023-04-01' (Azure#23832)" (Azure#23923)" This reverts commit e6c0e188a74d051a3a44728ce058e85447553392. * Removed 202 and Async supression. * Update documentation. * Updated documentation --------- Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com> * [package-lock.json] Add names to local dependencies (Azure#24846) - Command "npm update" removes these names, but "npm install" adds them - It's probably better to keep the names, since users are more likely to run "npm install" * Update ci-fix.md: add API Doc Preview TSG (Azure#24843) * Update ci-fix.md: add API Doc Preview TSG * Remove unsupported SQL Pool Rename/move operation (Azure#24517) * Add enableOSPatching and address comments (Azure#24849) * Updated text for property isSoftDeleteFeatureStateEditable (Azure#24713) * Updating folder structure for Microsoft.Migrate (Azure#24550) * folders restructure and update readme * revert removed offazure in readme * Removing readonly flag from top level object (Azure#24848) * [ACS JobRouter] Add misssing descriptions (#24842) * Updated JR swagger with maxNumberOfJobs * sync with upstream main * add descriptions * prettier fix * add more missing descriptions * add more description fixes --------- Co-authored-by: williamzhao87 <williamzhao87@gmail.com> * a couple of representation tweaks for codegen (Azure#24847) * Removed pricing not relevant to CI * Added Resizing state * Change targetVMSize name * Revert "Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs into teom-hobovm08-01-preview" This reverts commit 47adff637482e53956bcde7a4331f0638a1ddfbc, reversing changes made to 4b9165da959a09109ecf96e7e70a940ec3989732. * Resolve comments for os patching (Azure#24872) * Add properties for os patching * resolve comments * remove autorestartafterupdates * update description * rename property --------- Co-authored-by: Chris Jiang <chrjia@microsoft.com> * Rename osPatchingStatus to upper case (Azure#24954) * Add properties for os patching * resolve comments * remove autorestartafterupdates * update description * rename property * Change property osPatchingStatus to upper case * rename osPatchingStatus to upper case --------- Co-authored-by: Chris Jiang <chrjia@microsoft.com> * Fix some minor issues * Fix comments * Minor changes * Fix more builds * 200 and nextLink * Remove nextlink * Try 204 not 200 * Change GET call to POST * Remove 204 * Add 200 response * Change example state * Add enum for patch status (Azure#25208) * Add properties for os patching * resolve comments * remove autorestartafterupdates * update description * rename property * Change property osPatchingStatus to upper case * rename osPatchingStatus to upper case * add enum for patch status * add enum for patch status --------- Co-authored-by: Chris Jiang <chrjia@microsoft.com> * LRO does not return 200 * Format readme * Format readme * Format readme * Fix readme * Rename enum for patchStatus (Azure#25257) * Add properties for os patching * resolve comments * remove autorestartafterupdates * update description * rename property * Change property osPatchingStatus to upper case * rename osPatchingStatus to upper case * add enum for patch status * add enum for patch status * rename enum's name * rename enum --------- Co-authored-by: Chris Jiang <chrjia@microsoft.com> --------- Co-authored-by: Jayati Tehri <72947097+jayati-tehri@users.noreply.github.com> Co-authored-by: PreetPRG <31791038+PreetPRG@users.noreply.github.com> Co-authored-by: InbalZim <48387592+InbalZim@users.noreply.github.com> Co-authored-by: VIPRAY JAIN <118152689+vipray-ms@users.noreply.github.com> Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Teo Magnino Chaban <teom@microsoft.com> Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> Co-authored-by: Chris Jiang <hust.crystal@gmail.com> Co-authored-by: Chris Jiang <chrjia@microsoft.com> Co-authored-by: williamzhao87 <williamzhao87@users.noreply.github.com> Co-authored-by: Rajarshi Sarkar 🦄 <rsarkar@microsoft.com> Co-authored-by: Rajarshi Sarkar <73562869+sarkar-rajarshi@users.noreply.github.com> Co-authored-by: Liangying.Wei <lianwei@microsoft.com> Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> Co-authored-by: mqwang <mewan@microsoft.com> Co-authored-by: abhargavams <91880511+abhargavams@users.noreply.github.com> Co-authored-by: kanupriyasinghh <113429657+kanupriyasinghh@users.noreply.github.com> Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com> Co-authored-by: Brandon Miller <42854725+brandom-msft@users.noreply.github.com> Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com> Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Albert Cheng <38804567+ckairen@users.noreply.github.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Jose Alvarez <jpalvarezl@users.noreply.github.com> Co-authored-by: Maxim Rytych <99686729+maximrytych-ms@users.noreply.github.com> Co-authored-by: Daniel Hu <dhu5432@gmail.com> Co-authored-by: Kalpesh Chavan <18593210+KalpeshChavan12@users.noreply.github.com> Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com> Co-authored-by: kashyap-kunal <72463758+kashyap-kunal@users.noreply.github.com> Co-authored-by: ishanjindalms <96572678+ishanjindalms@users.noreply.github.com> Co-authored-by: athulvijayanmsft <134380821+athulvijayanmsft@users.noreply.github.com> Co-authored-by: Thomas Ricci <thricci@microsoft.com> Co-authored-by: williamzhao87 <williamzhao87@gmail.com> * Adding new query param on list job api (Azure#25375) Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * Remove list materialization jobs api (Azure#25372) * Update mfe.json * prettify swagger * Remove example * Update readme.md * Update readme.md * Add backfill api contract changes * Fixing json * Add property bag * Modifying example --------- Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * sweep over pipeline component (Azure#25616) * Add SSO and RootAccess (Azure#25754) Co-authored-by: Teo Magnino Chaban <teom@microsoft.com> * add EnvironmentVariables in sparkjob (Azure#25814) * Add model monitor 2023-08-01-preview changes (Azure#25785) * Add model monitor 2023-08-01-preview changes * update * run prettier * update comments * add * Add WS Vnet properties for Serverless GA (Azure#25780) * add serverless ws vnet properties * add to workspace update properties * update format * update description --------- Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * Resource to ProxyResource for preview version (Azure#25906) Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * August-2023-preview fix circular reference (Azure#25870) * TriggerType->ComputeTriggerType * RecurrenceFrequency->ComputeRecurrenceFrequency * RecurrenceSchedule->ComputeRecurrenceSchedule --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * Update ServerlessEndpoints design (Azure#25593) * first draft redesign of ServerlessEndpoints * add getStatus.json * update examples * add LRO location header to example * add CapacityReservationGroups API * spellcheck fix * example fix * capacity reservation groups should be under resource groups * fix examples * inferenceUri -> uri * CapacityReservation -> ServerlessEndpointCapacityReservation * update description * remove ExcessCapacityReservation concept * remove parentGroupId concept * rename /status api to /getStatus * label metrics as readOnly * lintdiff GET fix * more fixes * add listBySubscription * add/fix examples * add suppression for lint error (Azure#25941) * minor fixes (Azure#25940) * Update 2023-08-01-preview swagger for workspaceRP (Azure#25532) * Update swagger * Bug fix * update * Update testconnection and example * Fix format * update custom words and example * Update missing custom words * reflect comment remove LRO opetions * make metadata a string dictionary * reflect comment * Revert "reflect comment" This reverts commit 9b85252250fd442dd891b27509f5d2e315d8aa2a. * Update with managedNetwork change included * Update managed network schema * revert metadata change * remove the RBAC properties related with shared connection * Update readme * Update suppression reason * Updated preview API to add Kernel Config (Azure#25361) * Updated preview API to add Kernel Config and LRO Headers * Fixing formatting issue * Updated as per comments * Updated as per comments * Reverting changes * Reverted header changes * Reverting change * Reverting example * Added version parameter and removed addition properties as per guidelines --------- Co-authored-by: Srivatsa Sinha <srsinha@microsoft.com> * Thtodoro/serverless endpoints 2023 08 01 preview fix (Azure#25993) * Capacity Reservation Groups is not an async resource, and thus does not have 202 as a response type * PATCH response must have same resource as GET/PUT APIs * add missing description * Adding Inference Pools, Groups and Endpoints recreated for Azure/azure-rest-api-specs#25783 for rebased issue (Azure#25819) * Adding Inference Pools, Groups and Endpoints * PR comments * remove EventLog and change data * remove EventLog and change data * moving endpoint as sibling to group * Moving back to the tracked resources * force change * fix the missing field --------- Co-authored-by: Raushan Kumar <raushank@microsoft.com> * Make suppression more specific (Azure#26031) Co-authored-by: Teo Magnino Chaban <teom@microsoft.com> * add serverless compute settings (Azure#26007) Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: Anubha Jain <41411445+Anubha98@users.noreply.github.com> Co-authored-by: Anubha98 <anubhajain@microsoft.com> Co-authored-by: teochaban <teochaban@hotmail.com> Co-authored-by: Jayati Tehri <72947097+jayati-tehri@users.noreply.github.com> Co-authored-by: PreetPRG <31791038+PreetPRG@users.noreply.github.com> Co-authored-by: InbalZim <48387592+InbalZim@users.noreply.github.com> Co-authored-by: VIPRAY JAIN <118152689+vipray-ms@users.noreply.github.com> Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Teo Magnino Chaban <teom@microsoft.com> Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> Co-authored-by: Chris Jiang <hust.crystal@gmail.com> Co-authored-by: Chris Jiang <chrjia@microsoft.com> Co-authored-by: williamzhao87 <williamzhao87@users.noreply.github.com> Co-authored-by: Rajarshi Sarkar 🦄 <rsarkar@microsoft.com> Co-authored-by: Rajarshi Sarkar <73562869+sarkar-rajarshi@users.noreply.github.com> Co-authored-by: Liangying.Wei <lianwei@microsoft.com> Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> Co-authored-by: mqwang <mewan@microsoft.com> Co-authored-by: abhargavams <91880511+abhargavams@users.noreply.github.com> Co-authored-by: kanupriyasinghh <113429657+kanupriyasinghh@users.noreply.github.com> Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com> Co-authored-by: Brandon Miller <42854725+brandom-msft@users.noreply.github.com> Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com> Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Albert Cheng <38804567+ckairen@users.noreply.github.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Jose Alvarez <jpalvarezl@users.noreply.github.com> Co-authored-by: Maxim Rytych <99686729+maximrytych-ms@users.noreply.github.com> Co-authored-by: Daniel Hu <dhu5432@gmail.com> Co-authored-by: Kalpesh Chavan <18593210+KalpeshChavan12@users.noreply.github.com> Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com> Co-authored-by: kashyap-kunal <72463758+kashyap-kunal@users.noreply.github.com> Co-authored-by: ishanjindalms <96572678+ishanjindalms@users.noreply.github.com> Co-authored-by: athulvijayanmsft <134380821+athulvijayanmsft@users.noreply.github.com> Co-authored-by: Thomas Ricci <thricci@microsoft.com> Co-authored-by: williamzhao87 <williamzhao87@gmail.com> Co-authored-by: shail2208 <59747407+shail2208@users.noreply.github.com> Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> Co-authored-by: ghsutirtha <87542976+ghsutirtha@users.noreply.github.com> Co-authored-by: ycheng35xo <90874573+ycheng35xo@users.noreply.github.com> Co-authored-by: Mathieu St-Louis <81435026+mastloui-msft@users.noreply.github.com> Co-authored-by: ac923 <aahelic@yahoo.com> Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> Co-authored-by: Teddy Todorov <thtodoro@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: srivatsasinha <102133347+srivatsasinha@users.noreply.github.com> Co-authored-by: Srivatsa Sinha <srsinha@microsoft.com> Co-authored-by: Raushan Kumar <44377286+raushan2016@users.noreply.github.com> Co-authored-by: Raushan Kumar <raushank@microsoft.com>
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.