-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gallery 2021-10-01 release #26658
Merged
Merged
Gallery 2021-10-01 release #26658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* save * add test for community gallery publishing * update
ghost
added
the
Compute
label
Jan 28, 2022
This pull request is protected by Check Enforcer. |
grizzlytheodore
commented
Jan 28, 2022
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/GalleriesOperations.cs
Show resolved
Hide resolved
grizzlytheodore
commented
Jan 28, 2022
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/IGalleriesOperations.cs
Show resolved
Hide resolved
grizzlytheodore
commented
Jan 28, 2022
....Azure.Management.Compute/src/Generated/Models/GalleryApplicationVersionPublishingProfile.cs
Show resolved
Hide resolved
grizzlytheodore
requested review from
archerzz,
ArcturusZhang,
ArthurMa1978,
fengzhou-msft,
m-nash and
Yao725
as code owners
February 9, 2022 15:48
archerzz
approved these changes
Feb 10, 2022
@grizzlytheodore Looks good. Do you want to merge this PR? Or is there any work you need to finish? |
@archerzz ready for merging ! |
Done |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Nov 14, 2023
[ACS JobRouter][GA] Change discriminators to enum instead of string for all polymorphic base class (Azure#26658) * change discriminators to enum instead of string * Mark list methods as internal * update examples * update typespec-ts option * update examples * Suppress DISCRIMINATOR_NOT_REQUIRED and INVALID_DISCRIMINATOR_TYPE * Update projected list method names for csharp * Revert * add missing package-dir in tspconfig --------- Co-authored-by: williamzhao87 <williamzhao87@gmail.com> Co-authored-by: Mike Harder <mharder@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
For Gallery 2021-10-01 release. Swagger PR: Azure/azure-rest-api-specs#17548
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.