Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery 2021-10-01 release #26658

Merged
merged 13 commits into from
Feb 11, 2022
Merged

Gallery 2021-10-01 release #26658

merged 13 commits into from
Feb 11, 2022

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Jan 28, 2022

All SDK Contribution checklist:

For Gallery 2021-10-01 release. Swagger PR: Azure/azure-rest-api-specs#17548

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the Compute label Jan 28, 2022
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

@grizzlytheodore grizzlytheodore marked this pull request as ready for review February 9, 2022 15:48
@grizzlytheodore grizzlytheodore changed the title Feature/cplat 2021 10 01 Gallery 2021-10-01 release Feb 9, 2022
@archerzz
Copy link
Member

@grizzlytheodore Looks good. Do you want to merge this PR? Or is there any work you need to finish?

@grizzlytheodore
Copy link
Member Author

@archerzz ready for merging !

@archerzz archerzz merged commit 9abbd3e into main Feb 11, 2022
@archerzz archerzz deleted the feature/cplat-2021-10-01 branch February 11, 2022 02:00
@archerzz
Copy link
Member

@archerzz ready for merging !

Done

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Nov 14, 2023
[ACS JobRouter][GA] Change discriminators to enum instead of string for all polymorphic base class (Azure#26658)

* change discriminators to enum instead of string

* Mark list methods as internal

* update examples

* update typespec-ts option

* update examples

* Suppress DISCRIMINATOR_NOT_REQUIRED and INVALID_DISCRIMINATOR_TYPE

* Update projected list method names for csharp

* Revert

* add missing package-dir in tspconfig

---------

Co-authored-by: williamzhao87 <williamzhao87@gmail.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants