-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Lab Services 2021-11-15-preview mangement api minor version bump to 4.1.0 #29396
Merged
ArthurMa1978
merged 8 commits into
Azure:main
from
kthatipally:AzureLabServices-Minor-Version-update-2
Jul 12, 2022
Merged
Azure Lab Services 2021-11-15-preview mangement api minor version bump to 4.1.0 #29396
ArthurMa1978
merged 8 commits into
Azure:main
from
kthatipally:AzureLabServices-Minor-Version-update-2
Jul 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esClient now exposes public constructor
kthatipally
requested review from
ArthurMa1978,
m-nash,
markcowl,
fengzhou-msft,
archerzz,
ArcturusZhang and
Yao725
as code owners
June 21, 2022 17:59
This pull request is protected by Check Enforcer. |
fengzhou-msft
previously approved these changes
Jun 22, 2022
...ces/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj
Outdated
Show resolved
Hide resolved
sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
…o AzureLabServices-Minor-Version-update-2
...ces/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj
Outdated
Show resolved
Hide resolved
sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
...ces/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj
Show resolved
Hide resolved
…o AzureLabServices-Minor-Version-update-2
…1 to 4.1.0-beta.1
sdk/labservices/Microsoft.Azure.Management.LabServices/CHANGELOG.md
Outdated
Show resolved
Hide resolved
ArthurMa1978
approved these changes
Jul 12, 2022
…o AzureLabServices-Minor-Version-update-2
zhihaoxue
pushed a commit
to zhihaoxue/azure-sdk-for-net
that referenced
this pull request
Jul 27, 2022
…p to 4.1.0 (Azure#29396) * Azure Lab Services Minor version update to 4.1.0: Bug fix - LabServicesClient now exposes public constructor * Azure Lab Services: updated assemblyVersion * Updates to address PR comments * Updates to address PR comments to change the version from 1.0.0-beta.1 to 4.1.0-beta.1 * Updates to address PR comments - removed extra space
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
…p to 4.1.0 (Azure#29396) * Azure Lab Services Minor version update to 4.1.0: Bug fix - LabServicesClient now exposes public constructor * Azure Lab Services: updated assemblyVersion * Updates to address PR comments * Updates to address PR comments to change the version from 1.0.0-beta.1 to 4.1.0-beta.1 * Updates to address PR comments - removed extra space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
This PR has the changes to get the new swagger spec with the below setting which makes the LabServicesClient constructors as public and bump up to a minor version from 4.0.0 to 4.1.0
Bug Summary:
Customers were unable to create client to use AzureLabServices SDK as LabServicesClient doesn’t expose a public parameter that handles the ServiceClientCredentials. All the constructors exposed were internal and now has been fixed in this PR.
Azure Rest API Spec - Swagger Updated spec PR: Azure/azure-rest-api-specs#19402
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.