Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Lab Services 2021-11-15-preview mangement api minor version bump to 4.1.0 #29396

Merged

Conversation

kthatipally
Copy link
Contributor

Contributing to the Azure SDK

This PR has the changes to get the new swagger spec with the below setting which makes the LabServicesClient constructors as public and bump up to a minor version from 4.0.0 to 4.1.0

Bug Summary:

Customers were unable to create client to use AzureLabServices SDK as LabServicesClient doesn’t expose a public parameter that handles the ServiceClientCredentials. All the constructors exposed were internal and now has been fixed in this PR.
Azure Rest API Spec - Swagger Updated spec PR: Azure/azure-rest-api-specs#19402

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

fengzhou-msft
fengzhou-msft previously approved these changes Jun 22, 2022
@fengzhou-msft fengzhou-msft dismissed their stale review June 22, 2022 08:04

needs approval from Arthur

@kthatipally kthatipally requested a review from ArthurMa1978 July 12, 2022 04:02
@ArthurMa1978 ArthurMa1978 merged commit c431dd2 into Azure:main Jul 12, 2022
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this pull request Jul 27, 2022
…p to 4.1.0 (Azure#29396)

* Azure Lab Services Minor version update to 4.1.0: Bug fix - LabServicesClient now exposes public constructor

* Azure Lab Services: updated assemblyVersion

* Updates to address PR comments

* Updates to address PR comments to change the version from 1.0.0-beta.1 to 4.1.0-beta.1

* Updates to address PR comments - removed extra space
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
…p to 4.1.0 (Azure#29396)

* Azure Lab Services Minor version update to 4.1.0: Bug fix - LabServicesClient now exposes public constructor

* Azure Lab Services: updated assemblyVersion

* Updates to address PR comments

* Updates to address PR comments to change the version from 1.0.0-beta.1 to 4.1.0-beta.1

* Updates to address PR comments - removed extra space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants