Update AutoRest C# version #30268
Update AutoRest C# version #30268
Conversation
azure-sdk
requested review from
chidozieononiwu,
weshaggard,
benbp,
m-nash,
fengzhou-msft,
archerzz,
ArcturusZhang,
Yao725,
ArthurMa1978,
seanmcc-msft,
amnguye,
jaschrep-msft and
tg-msft
as code owners
ghost
added
the
azure-sdk
force-pushed
the
auto-update-autorest
branch
4 times, most recently
from
0b61c93 to
2f1ae38
Compare
azure-sdk
requested review from
christothes,
wonner,
annelo-msft,
nisha-bhatia,
Kishp01,
ahamad-MS,
jfggdl,
JoshLove-msft,
kinelski and
heaths
as code owners
azure-sdk
force-pushed
the
auto-update-autorest
branch
from
2f1ae38 to
f53e922
Compare
sdk/anomalydetector/Azure.AI.AnomalyDetector/src/Generated/AnomalyDetectorModelFactory.cs
Show resolved
Hide resolved
|
/check-enforcer override |
| /// <returns> A new <see cref="Models.ErrorResponse"/> instance for mocking. </returns> | ||
| public static ErrorResponse ErrorResponse(string code = null, string message = null) | ||
| { | ||
| if (code == null) |
There was a problem hiding this comment.
You should use the Argument helper class in Azure.Core shared source: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/src/Shared/Argument.cs
There was a problem hiding this comment.
Do you mean the generator should do this? This is generated code.
There was a problem hiding this comment.
I may be biased since I wrote Argument, but I used to think the same thing: the generator should use it. However, it was created mostly for dev productivity and as it's grown over the years, think it's fine if the generator does what we see here now. If a project doesn't otherwise link Argument.cs why impact the assembly size unnecessarily? Just my $0.02.
There was a problem hiding this comment.
I would tend to agree with you - we don't really need to worry about the productivity of the generator 😄
| /// <returns> A new <see cref="Conversations.ConversationTasksState"/> instance for mocking. </returns> | ||
| public static ConversationTasksState ConversationTasksState(ConversationTasksStateTasks tasks = null) | ||
| { | ||
| if (tasks == null) |
There was a problem hiding this comment.
I realize this is already merged, but:
- Why not just let the constructor throw appropriately rather than duplicating logic?
- Even if we duplicate logic, if indeed this is a required parameter why do we still declare it as optional?
* Update AutoRest C# version to 3.0.0-beta.20220804.2 * remove hdinsight * regenerate hdinsight * remove trafficmanager * regenerate trafficmanager Co-authored-by: Arcturus Zhang <dapzhang@microsoft.com>
Update AutoRest C# version to 3.0.0-beta.20220802.1