Add attach statsbeat dimensions #30522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/Statsbeat.cs
Outdated
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/Statsbeat.cs
Outdated
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/Statsbeat.cs
Outdated
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/Statsbeat.cs
Show resolved
Hide resolved
…/Statsbeat/Statsbeat.cs Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>
…/Statsbeat/Statsbeat.cs Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>
…m/Azure/azure-sdk-for-net into vibankwa/add-statsbeat-dimensions
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/Statsbeat.cs
Show resolved
Hide resolved
…/Statsbeat/Statsbeat.cs Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/Statsbeat.cs
Outdated
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/Statsbeat.cs
Outdated
Show resolved
Hide resolved
vishweshbankwar
requested review from
cijothomas,
reyang and
TimothyMothra
as code owners
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/Statsbeat.cs
Outdated
Show resolved
Hide resolved
rajkumar-rangaraj
approved these changes
Aug 16, 2022
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/VmMetadataResponse.cs
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/Statsbeat.cs
Show resolved
Hide resolved
cijothomas
reviewed
Aug 23, 2022
| new("rpId", s_resourceProviderId), | ||
| new("attach", "sdk"), | ||
| new("cikey", Customer_Ikey), | ||
| new("runtimeVersion", s_runtimeVersion), |
There was a problem hiding this comment.
is this .net runtime version?
cijothomas
reviewed
Aug 23, 2022
| return new(1, new("cikey", Customer_Ikey), new("language", "dotnet")); | ||
| if (s_resourceProvider == null) | ||
| { | ||
| SetResourceProviderDetails(); |
There was a problem hiding this comment.
protect with try.catch.
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
* add attach statsbeat dimensions * refactor * Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/Statsbeat.cs Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com> * Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/Statsbeat.cs Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com> * rmv vmId * Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/Statsbeat.cs Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com> * refactor * refactor * refactor * resolve PR comments Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional dimensions for Attach Statsbeat
rp: the name of a resource provider, e.g., appsvc, vm, functions, aks, and unknown,
rpId : the unique identifier of the resource provider,
attach: codeless or sdk (only sdk supported for now)
runtimeVersion: runtime version of a specific platform.
version: version of the application insights SDK/Agent