Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CRP 2022-11-01 version #32504

Merged
merged 18 commits into from
Jan 10, 2023
Merged

Adding CRP 2022-11-01 version #32504

merged 18 commits into from
Jan 10, 2023

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Nov 16, 2022 •
edited
Loading

SDK PR for Swagger CRP 2022-11-01 version
Azure/azure-rest-api-specs#21571

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@ghost ghost added the Compute label Nov 16, 2022
Theodore Chang and others added 14 commits November 15, 2022 20:49
merge main to this branch
2a88e80
generated with version
e433f6d
re-recorded tests
e40cb6c
test recordings
ead0255
@srcharug
Reimage support for single VM (#32825)
461ed65
@csassasin
Addition of user Data property in RestorePointSourceMetadata class fo…
fd2317b 
…r restore points (#32027)

* SDK for userData property addition

SDK for user Data property addition

* Updated based on spec changes

* Updated description

Co-authored-by: Ashwani Tiwari <ashwtiwari@microsoft.com>
@johnzhang-microsoft @grizzlytheodore
Generate new compute import for SDK. Includes OS Image profile and ma…
89bba62 
…xSurge in Microsoft.Compute (#32880)

* add reimage notification

* add scenario test

* add max surge

* fix grammar, add release note, take release version back

* add successful test record

* updated csproj

* not sure why merge conflict not resolving

* add maxsurge test

* Update TestVMScaleSetScenarioOperations_ScheduledEvents.json

* passing max surge test

Co-authored-by: Theodore Chang <thchan@microsoft.com>
@avaiyanggarg
Adding requireGuestProvisionSignal and constrainedMaximumCapacity mis…
8538313 
…sing properties (#32921)

Co-authored-by: Avaiyang Garg <avaiyanggarg@micrososft.com>
@avaiyanggarg
Add serviceArtifactReference property (#32933)
13eaf90 
Co-authored-by: Avaiyang Garg <avaiyanggarg@micrososft.com>
@RajalakshmiSwaminathan
SDK generated from Swagger for Image Deprecation related changes (#32660
3336184 
)

* SDK generated from Swagger for Image Deprecation related changes

* Regenerated SDK for swagger changes

* Added tests for ImageDeprecationStatus
@sds6 @grizzlytheodore
SDK for rollbackFailedInstancesOnPolicyBreach (#32894)
a000e77 
* add test and generated file.

* TestVMScaleSetRollingUpgrade.json session record

Co-authored-by: Sachin Doddaiah Shylaja <sadoddai@microsoft.com>
Co-authored-by: Theodore Chang <thchan@microsoft.com>
merge main
79aeb32
fix conflict errors
4749a00
release infos
ef979a0
@grizzlytheodore grizzlytheodore marked this pull request as ready for review January 4, 2023 19:06
@grizzlytheodore grizzlytheodore changed the title generated using 2022-11-01 tag Adding CRP 2022-11-01 versions Jan 4, 2023
@grizzlytheodore grizzlytheodore changed the title Adding CRP 2022-11-01 versions Adding CRP 2022-11-01 version Jan 4, 2023
archerzz
archerzz reviewed Jan 5, 2023
View reviewed changes
Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grizzlytheodore Is this just a code update or you want to publish a new release? Note that you need to update AssemblyInfo.cs if you want to publish a new release.

@grizzlytheodore
Copy link
Member Author

Hello @archerzz, assemblyInfo is not being changed in this PR, because we had a SDK PR for 2022-09-04 CloudService release merged a couple weeks ago which updates the version to 60.0.0, but we did not publish that version because we wanted to publish with this new CRP version.

you can see here
 the latest version published is 59.0.0 and the main branch has 60.0.0

please merge !

@archerzz
Copy link
Member

Hello @archerzz, assemblyInfo is not being changed in this PR, because we had a SDK PR for 2022-09-04 CloudService release merged a couple weeks ago which updates the version to 60.0.0, but we did not publish that version because we wanted to publish with this new CRP version.

you can see here the latest version published is 59.0.0 and the main branch has 60.0.0

please merge !

Thanks. Merging

@archerzz archerzz merged commit dc7c728 into main Jan 10, 2023
@archerzz archerzz deleted the feature/cplat-2022-11-01 branch January 10, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archerzz archerzz archerzz approved these changes

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@markcowl markcowl Awaiting requested review from markcowl

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@Yao725 Yao725 Awaiting requested review from Yao725

Assignees

@archerzz archerzz

Labels
Compute
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@grizzlytheodore @archerzz @srcharug @csassasin @johnzhang-microsoft @avaiyanggarg @RajalakshmiSwaminathan @sds6