Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network SDK issue https://github.com/Azure/azure-sdk-for-net/issues/34094 #34227

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Fix network SDK issue https://github.com/Azure/azure-sdk-for-net/issues/34094 #34227

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f930442
initial attempt
ArcturusZhang Feb 16, 2023
d63866b
mitigate the breaking change
ArcturusZhang Feb 16, 2023
e22d8cf
resolve comments
ArcturusZhang Feb 22, 2023
a5e0baa
update changelog
ArcturusZhang Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/network/Azure.ResourceManager.Network/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Bugs Fixed

- Fixed issue https://github.com/Azure/azure-sdk-for-net/issues/34094. Please use `EffectiveNetworkSecurityGroup.TagDict` instead of `EffectiveNetworkSecurityGroup.TagMap`.

### Other Changes

## 1.1.1 (2023-02-13)
Expand Down
3 changes: 3 additions & 0 deletions ...network/Azure.ResourceManager.Network/api/Azure.ResourceManager.Network.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6319,6 +6319,9 @@ internal EffectiveNetworkSecurityGroup() { }
public Azure.ResourceManager.Network.Models.EffectiveNetworkSecurityGroupAssociation Association { get { throw null; } }
public System.Collections.Generic.IReadOnlyList<Azure.ResourceManager.Network.Models.EffectiveNetworkSecurityRule> EffectiveSecurityRules { get { throw null; } }
public Azure.Core.ResourceIdentifier NetworkSecurityGroupId { get { throw null; } }
public System.Collections.Generic.IReadOnlyDictionary<string, System.Collections.Generic.IList<string>> TagDict { get { throw null; } }
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
[System.ObsoleteAttribute("This property is obsolete and might be removed in a future version, please use TagDict instead", false)]
public string TagMap { get { throw null; } }
}
public partial class EffectiveNetworkSecurityGroupAssociation
Expand Down
18 changes: 18 additions & 0 deletions ...k/Azure.ResourceManager.Network/src/Customization/Models/EffectiveNetworkSecurityGroup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

#nullable disable

using System;
using System.ComponentModel;

namespace Azure.ResourceManager.Network.Models
{
public partial class EffectiveNetworkSecurityGroup
{
/// <summary> Mapping of tags to list of IP Addresses included within the tag. </summary>
[EditorBrowsable(EditorBrowsableState.Never)]
[Obsolete("This property is obsolete and might be removed in a future version, please use TagDict instead", false)]
public string TagMap { get; }
}
}
21 changes: 18 additions & 3 deletions ...sourceManager.Network/src/Generated/Models/EffectiveNetworkSecurityGroup.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions ...twork/Azure.ResourceManager.Network/src/Generated/Models/EffectiveNetworkSecurityGroup.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions sdk/network/Azure.ResourceManager.Network/src/autorest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ rename-mapping:
EndpointType: ConnectionMonitorEndpointType
ConnectionState: NetworkConnectionState
ApplicationGatewayAvailableSslOptions: ApplicationGatewayAvailableSslOptionsInfo
EffectiveNetworkSecurityGroup.tagMap: tagDict

format-by-name-rules:
'tenantId': 'uuid'
Expand Down Expand Up @@ -382,6 +383,9 @@ directive:
transform: >
$.ResourceNavigationLinkFormat.properties.link['x-ms-format'] = 'arm-id';
$.ServiceAssociationLinkPropertiesFormat.properties.link['x-ms-format'] = 'arm-id';
- from: networkInterface.json # a temporary fix for issue https://github.com/Azure/azure-sdk-for-net/issues/34094
where: $.definitions.EffectiveNetworkSecurityGroup.properties.tagMap.type
transform: return "object";
```

### Tag: package-track2-preview
Expand Down