Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text Translation] Replace async examples with synchronous code. #38386

Merged
merged 8 commits into from
Sep 7, 2023
Merged

[Text Translation] Replace async examples with synchronous code. #38386

merged 8 commits into from
Sep 7, 2023

Conversation

rangothedog
Copy link
Contributor

[Text Translation] Replace async examples with synchronous code. Readme.MD and sample.MD files all updated with snippet update tool. From the translation service directory:

....\eng\scripts\Update-Snippets.ps1 translation

Rango Meadows and others added 7 commits June 7, 2023 08:04
…ppets

Update Readme.md snippets to be populated by tool, added SampleSnippe…
* Updating sample C# snippets and code.

* Use explicit type instead of var, remove blank lines from #if

* Finished change to use explicit type instead of var

---------

Co-authored-by: Rango Meadows <v-rameadows@microsoft.com>
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@joseharriaga joseharriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Once @MikeyMCZ approves, I can merge them. 🙂

@joseharriaga joseharriaga merged commit e340b46 into Azure:main Sep 7, 2023
yaotongms pushed a commit to yaotongms/azure-sdk-for-net that referenced this pull request Oct 12, 2023
…re#38386)

* Update Readme.md snippets to be populated by tool, added SampleSnippets.cs file as source.

* Fixing missing double quote on region identifier.

* Updating sample C# snippets and code (Azure#2)

* Updating sample C# snippets and code.

* Use explicit type instead of var, remove blank lines from #if

* Finished change to use explicit type instead of var

---------

Co-authored-by: Rango Meadows <v-rameadows@microsoft.com>

* Replace async samples with synchronous code

* Corrected reference to async samples in README.md

---------

Co-authored-by: Rango Meadows <v-rameadows@microsoft.com>
Co-authored-by: Michal Materna <michal.materna@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants