-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Text Translation] Replace async examples with synchronous code. #38386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts.cs file as source.
…ppets Update Readme.md snippets to be populated by tool, added SampleSnippe…
* Updating sample C# snippets and code. * Use explicit type instead of var, remove blank lines from #if * Finished change to use explicit type instead of var --------- Co-authored-by: Rango Meadows <v-rameadows@microsoft.com>
API change check API changes are not detected in this pull request. |
MikeyMCZ
reviewed
Sep 5, 2023
joseharriaga
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Once @MikeyMCZ approves, I can merge them. 🙂
MikeyMCZ
approved these changes
Sep 6, 2023
yaotongms
pushed a commit
to yaotongms/azure-sdk-for-net
that referenced
this pull request
Oct 12, 2023
…re#38386) * Update Readme.md snippets to be populated by tool, added SampleSnippets.cs file as source. * Fixing missing double quote on region identifier. * Updating sample C# snippets and code (Azure#2) * Updating sample C# snippets and code. * Use explicit type instead of var, remove blank lines from #if * Finished change to use explicit type instead of var --------- Co-authored-by: Rango Meadows <v-rameadows@microsoft.com> * Replace async samples with synchronous code * Corrected reference to async samples in README.md --------- Co-authored-by: Rango Meadows <v-rameadows@microsoft.com> Co-authored-by: Michal Materna <michal.materna@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Text Translation] Replace async examples with synchronous code. Readme.MD and sample.MD files all updated with snippet update tool. From the translation service directory:
....\eng\scripts\Update-Snippets.ps1 translation