Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AzureCliCredential utilizes expires_on for token expiration #41366

Merged
merged 3 commits into from
Jan 18, 2024
Merged

AzureCliCredential utilizes expires_on for token expiration #41366

merged 3 commits into from
Jan 18, 2024

Conversation

christothes
Copy link
Member

closes #39743

@christothes christothes requested review from schaabs and a team as code owners January 17, 2024 21:00
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@christothes christothes changed the title AzureCliCredential utilizes expires_on token for expiration AzureCliCredential utilizes expires_on for token expiration Jan 17, 2024
@christothes @heaths
Update sdk/identity/Azure.Identity/tests/CredentialTestHelpers.cs
8bae283 
Co-authored-by: Heath Stewart <heaths@outlook.com>
@christothes christothes enabled auto-merge (squash) January 18, 2024 15:17
@christothes christothes merged commit ab5cf73 into Azure:main Jan 18, 2024
15 checks passed
@maorleger maorleger mentioned this pull request Jan 22, 2024
Merged
3 tasks
maorleger added a commit to Azure/azure-sdk-for-js that referenced this pull request Jan 24, 2024
@maorleger
[identity] Use expires_on if az cli credential provides it (#28333)
e7afb55 
### Packages impacted by this PR

@azure/identity

### Issues associated with this PR

Resolves #27648

### Describe the problem that is addressed by this PR

In version 2.54.0 the Azure CLI started including an `expires_on` field
containing a POSIX timestamp in seconds in addition to the existing
`expiresOn` field denoting the expiry in RFC3339 format.

We want to migrate to `expires_on` when the underlying az cli supports
it and fallback to the existing `expiresOn` otherwise.


### Provide a list of related PRs _(if any)_

Azure/azure-sdk-for-net#41366
Azure/azure-sdk-for-cpp#5075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths approved these changes

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Identity] Evaluate expires_on field in AzureCliCredential
3 participants
@christothes @azure-sdk @heaths