Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom vision C# SDK #4152

Merged
merged 5 commits into from
Mar 26, 2018
Merged

Add custom vision C# SDK #4152

merged 5 commits into from
Mar 26, 2018

Conversation

areddish
Copy link
Contributor

Description

Adding the generated C# Client SDK for Custom Vision.

Swagger PR: Azure/azure-rest-api-specs#2177

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda suggested changes Mar 21, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

src/SDKs/CognitiveServices/dataPlane/Vision/CustomVision/Prediction/generate.cmd
::

@echo off
call %~dp0..\..\..\..\..\..\..\tools\generate.cmd cognitiveservices/data-plane/CustomVision/Prediction %*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a generate.ps1 file similar to this and generate the code again

...tomVision/Prediction/Microsoft.Azure.CognitiveServices.Vision.CustomVision.Prediction.csproj Outdated
<PropertyGroup>
<PackageId>Microsoft.Azure.CognitiveServices.Vision.CustomVision.Prediction</PackageId>
<Description>This client library provides access to the Microsoft Cognitive Services CustomVision Prediction APIs.</Description>
<VersionPrefix>1.0.0-preview</VersionPrefix>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recommend starting versioning from 0.9.0-preview

...n/Training.Tests/Microsoft.Azure.CognitiveServices.Vision.CustomVision.Training.Tests.csproj Outdated
<PropertyGroup>
<Description>Microsoft.Azure.CognitiveServices.Vision.CustomVision.Training.Tests Class Library</Description>
<AssemblyName>Microsoft.Azure.CognitiveServices.Vision.CustomVision.Training.Tests</AssemblyName>
<VersionPrefix>1.0.2-preview</VersionPrefix>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test projects version should always be 1.0.0 since they are never published

...n/Training.Tests/Microsoft.Azure.CognitiveServices.Vision.CustomVision.Training.Tests.csproj Outdated
</ItemGroup>

<ItemGroup>
<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this item required?

src/SDKs/CognitiveServices/dataPlane/Vision/CustomVision/Training/generate.cmd
::

@echo off
call %~dp0..\..\..\..\..\..\..\tools\generate.cmd cognitiveservices/data-plane/CustomVision/Training %*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a generate.ps1 script similar to this and regenerate the code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the generate.ps1 command must create a .txt file, please commit this file.

...ediction.Tests/Microsoft.Azure.CognitiveServices.Vision.CustomVision.Prediction.Tests.csproj Outdated
<PropertyGroup>
<Description>Microsoft.Azure.CognitiveServices.Vision.CustomVision.Prediction.Tests Class Library</Description>
<AssemblyName>Microsoft.Azure.CognitiveServices.Vision.CustomVision.Prediction.Tests</AssemblyName>
<VersionPrefix>1.0.2-preview</VersionPrefix>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview package versioning must start with 0.9.0-preview

.../CustomVision/Training/Microsoft.Azure.CognitiveServices.Vision.CustomVision.Training.csproj Outdated

<PropertyGroup>
<TargetFrameworks>net452;netstandard1.4</TargetFrameworks>
<Version>1.0.0-preview</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the version number here

.../CustomVision/Training/Microsoft.Azure.CognitiveServices.Vision.CustomVision.Training.csproj
<PropertyGroup>
<PackageId>Microsoft.Azure.CognitiveServices.Vision.CustomVision.Training</PackageId>
<Description>This client library provides access to the Microsoft Cognitive Services CustomVision Training APIs.</Description>
<VersionPrefix>1.0.2-preview</VersionPrefix>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview package versioning must start from 0.9.0-preview

@dsgouda dsgouda self-assigned this Mar 21, 2018
@areddish areddish force-pushed the add-custom-vision branch from 804a4ce to b5b62f7 Compare March 23, 2018 21:22
dsgouda
dsgouda approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 0602d5a into Azure:psSdkJson6 Mar 26, 2018
This was referenced Mar 8, 2023
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees

@dsgouda dsgouda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@areddish @dsgouda @shahabhijeet