Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK and test for BatchAI for GA #4153

Merged
merged 5 commits into from
Mar 27, 2018
Merged

Update SDK and test for BatchAI for GA #4153

merged 5 commits into from
Mar 27, 2018

Conversation

llidev
Copy link
Contributor

@llidev llidev commented Mar 20, 2018

Description

Onboarding of .NET SDK for Azure BatchAI Service and related tests for GA. This is being generated by the following spec: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/batchai/resource-manager/Microsoft.BatchAI/stable/2018-03-01

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda suggested changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you are making some breaking changes here.
Please update the package version number in csproj file
(1.1.0-preview)
Also, please create a generate.ps1 file similar to this and generate the code again using this script

dsgouda
dsgouda suggested changes Mar 21, 2018
View reviewed changes
src/SDKs/BatchAI/Management.BatchAI/Generated/Models/JobsListOutputFilesOptions.cs
@@ -55,21 +57,27 @@ public JobsListOutputFilesOptions(string outputdirectoryid, int? linkexpiryinmin
/// OutputDirectory-->id parameter that is given by the user
/// during Create Job.
/// </summary>
[JsonProperty(PropertyName = "")]
[Newtonsoft.Json.JsonIgnore]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet Just want to confirm if this is a breaking change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a breaking change. They are query parameters not Json properties, this is not by intention for sure, maybe C# swagger generator got enhanced to understand this

@dsgouda
Copy link
Contributor

dsgouda commented Mar 21, 2018

We need to confirm whether the changes to JsonProperty is something introduced in the AutoRest generator. Will approve and merge once done.

dsgouda
dsgouda suggested changes Mar 21, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the generated code is as expected. Thanks for addressing the comments.
Looks good apart from the minor comment

src/SDKs/BatchAI/Management.BatchAI/Microsoft.Azure.Management.BatchAI.csproj
@@ -6,7 +6,7 @@
<PropertyGroup>
<PackageId>Microsoft.Azure.Management.BatchAI</PackageId>
<Description>Provides management capabilities for Azure Batch AI.</Description>
<Version>1.0.0-preview</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be a GA package? If yes, please update the PackageReleaseNotes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PackageReleaseNotes have been updated

dsgouda
dsgouda approved these changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 103e1b2 into Azure:psSdkJson6 Mar 27, 2018
This was referenced Mar 8, 2023
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llidev @dsgouda