-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate SDK.Net from swagger 'SQL database, elastic pool, and capabilities 2017-10-01-preview', and re-recording all Sql tests #4171
Conversation
@azuresdkci Can anyone from SDK-Net team review this PR? This PR is basically re-recording all sql tests to make sure the rest-api changes work. I'm not sure why the build of this PR failed. I build the following projects locally, they all work.
|
https://travis-ci.org/Azure/azure-sdk-for-net/builds/360473280#L6170
I think this is due to recent checkin of #4168. Please merge from psSdkJson6 and then it should repro on your machine. |
@jaredmoo Thanks Jared. After merge with psSdkJson6 I could repro the build error. Fix the test and redo recording on this test. Will update the PR later. |
For the record: there are some customizations that I added, the idea here is to add getters for properties that existed in the old API. Setters are generally not implemented because there are some differences in PUT behavior, so I would prefer for users to get compile errors (no setter for property) rather than weird runtime behaviour. |
I think AssemblyInfo.cs and Management.Sql.csproj need version bump (compared to latest version at https://www.nuget.org/packages/Microsoft.Azure.Management.Sql). And release notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs version bump & release notes. Otherwise approved :)
Hi reviewers, please review this PR. Thanks |
@dsgouda , @azuresdkci Can any reviewers from azuresdk team take a look at this PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please pull down the latest upstream changes and run the generate.ps1
command again
Looks good other than that
… 2017-10-01-preview. Re-recording all Sql tests
…e the release note for new features of the new version
@dsgouda Thanks Deepak! I have pull down the latest upstream and regenerated the sdk in the latest commit. waiting for the build/CI check pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM subject to builds passing
@dsgouda Thanks Deepak. It seems the default build always has errors not related with the changes. Does it matter? If yes, can you point me how to fix it? |
@payiAzure I am taking a look at the errors, kindly wait for it to be resolved. |
@dsgouda It seems the re-tried build still had the same error. What does this error mean? c:\workspace\NetCore-SdkCI\tools\SdkBuildTools\targets\common.targets(192,5): error MSB3073: The command "dotnet test -f netcoreapp1.1 c:\workspace\NetCore-SdkCI\src\AzureStack\FabricAdmin\Fabric.Admin.Tests\Fabric.Tests.csproj -l trx;LogFileName=c:\workspace\NetCore-SdkCI\TestResults\netCore11\Fabric.Tests.trx " exited with code -1073741502. [c:\workspace\NetCore-SdkCI\build.proj] |
Description
This PR is to generate SDK.Net for SQL from new swagger 'SQL database, elastic pool, and capabilities 2017-10-01-preview', and re-recording all SQL tests.
The merged Swagger PR link: Azure/azure-rest-api-specs#2734
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.