Content validation update spec #42191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaschrep-msft
requested review from
seanmcc-msft,
amnguye,
schaabs and
tg-msft
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
jalauzon-msft
approved these changes
Feb 26, 2024
| @@ -18,7 +17,7 @@ internal static class StructuredMessage | |||
| public enum Flags | |||
| { | |||
| None = 0, | |||
| CrcSegment = 1, | |||
| Crc = 1, | |||
There was a problem hiding this comment.
Sorry I didn't notice this in the first review, but do we maybe want to call this Crc64? I could envision a world where we have to add another crc algorithm in the future (like crc32c or something).
There was a problem hiding this comment.
you're right. I'll actually just match name to the existing content validation enum we have.
jaschrep-msft
merged commit 034c9cd
into
Azure:feature/storage/ContentValidation
3 of 15 checks passed
jaschrep-msft
added a commit
to jaschrep-msft/azure-sdk-for-net
that referenced
this pull request
Aug 13, 2024
* enum rename and footer read/write methods * align encode/decode tests | update encoding stream * decode stream footer * rename
jaschrep-msft
added a commit
that referenced
this pull request
Aug 20, 2024
* Structured Message Decode Stream (#42079) * Initial implementation and basic test * seek/write tests * fix test param * fix exceptions * Content validation update spec (#42191) * enum rename and footer read/write methods * align encode/decode tests | update encoding stream * decode stream footer * rename * decode tests & bugfixes (#42256) * decode tests & bugfixes * roundtrip tests * more tests * better errors | remove duplicate test * test coverage | exception message (#42363) * Structured Message Decode: Validate Content Length (#42370) * validate stream length * tests * stageblock | appendblock | putpages StructuredMessage (#42699) * regenerate and stage block uses structured message * page and append * testproxy * cleanup * fix datalake/share tests * testproxy * testproxy * re-add null-safe access * GET Blob Structured Message (#42959) * download range structured message * testproxy * throw when service fails to give back structured message * test * testproxy * PUT Blob Structured Message (#43130) * putblob structured message * testproxy * fixes * Structured Message: DataLake Append (#43275) * datalake append * null fix * fixes * Retriable decode (#44155) * retriable decode * rewind mock test * bugfix * bugfix * tests * Download retriable stream structured message (#44176) * blobs retriable structured message download * test proxy * testproxy * remove commented code * CRC: Always Structured Message (#44955) * blockblob working * revert testing change * page/append * datalake file * testfix * bug fixes | test fixes * disable new API for presenting CRC from structured message * fix nunit * whitespace * fix/test-proxy * csproj * more csproj removeals This is building fine locally idk what's up * Trigger Fresh Build * fileshare testproxy * fix mock * Update macos image from 11 to latest (#44607) * Update macos image from 11 to latest * Update eng/pipelines/templates/jobs/ci.mgmt.yml Co-authored-by: Ben Broderick Phillips <ben@benbp.net> --------- Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * Revert "Update macos image from 11 to latest (#44607)" this is causing too many problems. skipping macos tests for now. They'll run when this feature branch merges into main. This reverts commit 29e87b4. --------- Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * Enable fileshare crc (#45124) * impl * testproxy * shares fix * testproxy * block blob fix (#45129) * block blob fix * testproxy * rename and validation (#45160) * rename and validation * fix * crc tracking converted to longs (#45307) * Crc reporting pt2 (#45447) * expose crc from structured message * testproxy * undo typo * exportapi * testproxy * remove unused parameter * add `ExpectTrailingDetails` to download response * fix test inconsistency * fix auto --------- Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future PR to add more decode tests