Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AutoRest C# version to 3.0.0-beta.20240404.1 #43204

Merged
merged 11 commits into from
Apr 4, 2024
Merged

Update AutoRest C# version to 3.0.0-beta.20240404.1 #43204

merged 11 commits into from
Apr 4, 2024

Conversation

azure-sdk
Copy link
Collaborator

Update AutoRest C# version to 3.0.0-beta.20240404.1

heaths
heaths reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why, at least for Key Vault, is a method being added that's not even called? Or is it a static interface implementation with a generic return parameter? Linking these somehow to a changelog or something in Azure/autorest.csharp would help.

@AlexanderSher
Copy link
Contributor

AlexanderSher commented Apr 4, 2024 •
edited
Loading

Why, at least for Key Vault, is a method being added that's not even called? Or is it a static interface implementation with a generic return parameter? Linking these somehow to a changelog or something in Azure/autorest.csharp would help.

It will be called on the later phase of consolidation work. HLC Rest Clients will call these to serialize/deserialize models, similar to DPG

@AlexanderSher AlexanderSher merged commit f39c028 into Azure:main Apr 4, 2024
330 checks passed
@azure-sdk azure-sdk deleted the auto-update-autorest-3.0.0-beta.20240404.1 branch April 7, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths left review comments

@AlexanderSher AlexanderSher AlexanderSher approved these changes

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

@christothes christothes Awaiting requested review from christothes christothes is a code owner

@annelo-msft annelo-msft Awaiting requested review from annelo-msft annelo-msft is a code owner

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina KrzysztofCwalina is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

@jsquire jsquire Awaiting requested review from jsquire jsquire is a code owner

@pallavit pallavit Awaiting requested review from pallavit

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@archerzz archerzz Awaiting requested review from archerzz archerzz is a code owner

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@giakas giakas Awaiting requested review from giakas giakas is a code owner

@yeskarthik yeskarthik Awaiting requested review from yeskarthik yeskarthik is a code owner

@rasidhan rasidhan Awaiting requested review from rasidhan rasidhan is a code owner

@wonner wonner Awaiting requested review from wonner

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@amnguye amnguye Awaiting requested review from amnguye amnguye is a code owner

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft jaschrep-msft is a code owner

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@m-redding m-redding Awaiting requested review from m-redding m-redding is a code owner

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja ShivangiReja is a code owner

@kinelski kinelski Awaiting requested review from kinelski kinelski is a code owner

@cijothomas cijothomas Awaiting requested review from cijothomas

@reyang reyang Awaiting requested review from reyang

@rajkumar-rangaraj rajkumar-rangaraj Awaiting requested review from rajkumar-rangaraj rajkumar-rangaraj is a code owner

@TimothyMothra TimothyMothra Awaiting requested review from TimothyMothra TimothyMothra is a code owner

@vishweshbankwar vishweshbankwar Awaiting requested review from vishweshbankwar

@xiang17 xiang17 Awaiting requested review from xiang17 xiang17 is a code owner

@nisha-bhatia nisha-bhatia Awaiting requested review from nisha-bhatia nisha-bhatia is a code owner

@dubiety dubiety Awaiting requested review from dubiety dubiety is a code owner

@khmic5 khmic5 Awaiting requested review from khmic5

@andykao1213 andykao1213 Awaiting requested review from andykao1213

@ethanann-ms ethanann-ms Awaiting requested review from ethanann-ms ethanann-ms is a code owner

@vighatke vighatke Awaiting requested review from vighatke vighatke is a code owner

@Kishp01 Kishp01 Awaiting requested review from Kishp01 Kishp01 is a code owner

@jfggdl jfggdl Awaiting requested review from jfggdl

@johngallardo johngallardo Awaiting requested review from johngallardo johngallardo is a code owner

@abhinav-ghai abhinav-ghai Awaiting requested review from abhinav-ghai abhinav-ghai is a code owner

@Aashish93-stack Aashish93-stack Awaiting requested review from Aashish93-stack Aashish93-stack is a code owner

@sjiherzig sjiherzig Awaiting requested review from sjiherzig sjiherzig is a code owner

@minnieliu minnieliu Awaiting requested review from minnieliu minnieliu is a code owner

@paolamvhz paolamvhz Awaiting requested review from paolamvhz paolamvhz is a code owner

@shwali-msft shwali-msft Awaiting requested review from shwali-msft shwali-msft is a code owner

@allchiang-msft allchiang-msft Awaiting requested review from allchiang-msft allchiang-msft is a code owner

@mikehang-msft mikehang-msft Awaiting requested review from mikehang-msft mikehang-msft is a code owner

@gfeitosa-msft gfeitosa-msft Awaiting requested review from gfeitosa-msft gfeitosa-msft is a code owner

@phermanov-msft phermanov-msft Awaiting requested review from phermanov-msft phermanov-msft is a code owner

@ilyapaliakou-msft ilyapaliakou-msft Awaiting requested review from ilyapaliakou-msft ilyapaliakou-msft is a code owner

@danielav7 danielav7 Awaiting requested review from danielav7 danielav7 is a code owner

@miguhern miguhern Awaiting requested review from miguhern miguhern is a code owner

@whisper6284 whisper6284 Awaiting requested review from whisper6284 whisper6284 is a code owner

@RoyHerrod RoyHerrod Awaiting requested review from RoyHerrod

@ajpeacock0 ajpeacock0 Awaiting requested review from ajpeacock0

@nathpete-msft nathpete-msft Awaiting requested review from nathpete-msft

@AikoBB AikoBB Awaiting requested review from AikoBB AikoBB is a code owner

@maximrytych-ms maximrytych-ms Awaiting requested review from maximrytych-ms maximrytych-ms is a code owner

@mjafferi-msft mjafferi-msft Awaiting requested review from mjafferi-msft mjafferi-msft is a code owner

@LuChen-Microsoft LuChen-Microsoft Awaiting requested review from LuChen-Microsoft LuChen-Microsoft is a code owner

@minwoolee-msft minwoolee-msft Awaiting requested review from minwoolee-msft minwoolee-msft is a code owner

@MikeyMCZ MikeyMCZ Awaiting requested review from MikeyMCZ MikeyMCZ is a code owner

@joseharriaga joseharriaga Awaiting requested review from joseharriaga joseharriaga is a code owner

@quentinRobinson quentinRobinson Awaiting requested review from quentinRobinson quentinRobinson is a code owner

@anilba06 anilba06 Awaiting requested review from anilba06 anilba06 is a code owner

@gkostal gkostal Awaiting requested review from gkostal gkostal is a code owner

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@KevinBlasko KevinBlasko Awaiting requested review from KevinBlasko KevinBlasko is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@scottaddie scottaddie Awaiting requested review from scottaddie scottaddie is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@ToddKingMSFT ToddKingMSFT Awaiting requested review from ToddKingMSFT ToddKingMSFT is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@gulopesd gulopesd Awaiting requested review from gulopesd gulopesd is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

Assignees
No one assigned
Labels
Cognitive - Form Recognizer Cognitive - Language Cognitive - Metrics Advisor Cognitive - Text Analytics Cognitive - Translator Communication - Calling Server Communication - Chat Communication - Identity Communication - Network Traversal Communication - Phone Numbers Communication - Rooms Communication - Short Codes Communication - SMS Communication Container Registry Digital Twins Event Grid IoT KeyVault Maps Mgmt This issue is related to a management-plane library. Mixed Reality Monitor - Exporter Monitor OpenTelemetry Exporter Monitor - LiveMetrics Monitor - Query Quantum Schema Registry Search Storage Storage Service (Queues, Blobs, Files) Synapse Tables TimeseriesInsights VideoAnalyzer Azure Video Analyzer
Projects
Azure SDK for ACR
Status: Done
Azure SDK for Key Vault
Status: Done
Azure SDK for Search
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azure-sdk @AlexanderSher @heaths