Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting update management changes result from PR #3095 #4345

Merged
merged 3 commits into from
May 23, 2018

Conversation

finiteattractor
Copy link
Contributor

@finiteattractor finiteattractor commented May 21, 2018

Updating generated code based of swagger PR:
Azure/azure-rest-api-specs#3095

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please generate the code using generate.cmd or generate.ps1 similar to this and commit all the files modified

@finiteattractor
Copy link
Contributor Author

@dsgouda thanks! will update...

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some additive changes made here, please bump the version to 3.0.3-preview in the csproj

@dsgouda
Copy link
Contributor

dsgouda commented May 21, 2018

Looks good apart from the minor comment

@finiteattractor
Copy link
Contributor Author

cool! will add this, thanks!!

@dsgouda
Copy link
Contributor

dsgouda commented May 22, 2018

@finiteattractor Perhaps I forgot to mention but, we need to update the AssemblyInfo.cs here so that AssemblyFileVersion matches the updated nuget package version (3.0.3)
This must happen every time the nuget package version is updated

@finiteattractor
Copy link
Contributor Author

Good catch Thanks! will update.

@dsgouda dsgouda merged commit de87738 into Azure:psSdkJson6 May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants