Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bing AutoSuggest API #4434

Closed
wants to merge 0 commits into from
Closed

Add bing AutoSuggest API #4434

wants to merge 0 commits into from

Conversation

gu-wei
Copy link
Member

@gu-wei gu-wei commented Jun 9, 2018

Add bing AutoSuggest API:

  1. generated stub code from spec file
  2. add wrapper code and proj files
  3. add test code

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@gu-wei
Copy link
Member Author

gu-wei commented Jun 11, 2018

@azuresdkci, do you know who should I ping to review the PR?

@dsgouda
Copy link
Contributor

dsgouda commented Jun 14, 2018

@gu-wei Please complete the CLA process here
https://cla.opensource.microsoft.com/
This should kick off the CI builds after which we can review the PR.
Apologize for the delay

@gu-wei
Copy link
Member Author

gu-wei commented Jun 15, 2018

@dsgouda
I've clicked the "Sign In" button on page https://cla.opensource.microsoft.com, it redirected to the same page and nothing happened.:(

@dsgouda
Copy link
Contributor

dsgouda commented Jun 15, 2018

@shahabhijeet can you take a look

@dsgouda
Copy link
Contributor

dsgouda commented Jun 15, 2018

@gu-wei Can you link the related REST spec PR
and start an email thread with @shahabhijeet and I.

@gu-wei
Copy link
Member Author

gu-wei commented Jun 15, 2018

@dsgouda , @shahabhijeet
here is the related spec PR: Azure/azure-rest-api-specs#3180

@shahabhijeet shahabhijeet reopened this Jun 15, 2018
@shahabhijeet
Copy link
Member

@azuresdkci test this please

dsgouda
dsgouda suggested changes Jun 15, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run msbuild build.proj /p:Scope=SDKs/CognitiveServices/dataPlane/Search/BingAutoSuggest/BingAutoSuggest
and commit any artifacts generated.

.../BingAutoSuggest/BingAutoSuggest/Microsoft.Azure.CognitiveServices.Search.AutoSuggest.csproj Outdated
<PropertyGroup>
<PackageId>Microsoft.Azure.CognitiveServices.Search.AutoSuggest</PackageId>
<Description>This client library provides access to the Microsoft Cognitive Services AutoSuggest API.</Description>
<VersionPrefix>1.2.0</VersionPrefix>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this is a preview package or a stable package.
Versioning must start from 0.9.0-preview for preview versions and 1.0.0 for stable versions

src/SDKs/CognitiveServices/dataPlane/Search/BingAutoSuggest/BingAutoSuggest/generate.cmd Outdated
::

@echo off
call %~dp0..\..\..\..\..\..\..\tools\generate.cmd cognitiveservices/data-plane/AutoSuggest %*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace this with a generate.ps1 similar to this and regenerate the code.

...gest/BingAutoSuggest.Tests/Microsoft.Azure.CognitiveServices.Search.AutoSuggest.Tests.csproj Outdated
<PropertyGroup>
<Description>Microsoft.Azure.CognitiveServices.Search.AutoSuggest.Tests Class Library</Description>
<AssemblyName>Microsoft.Azure.CognitiveServices.Search.AutoSuggest.Tests</AssemblyName>
<VersionPrefix>1.1.0-preview</VersionPrefix>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test packages are never published and must always be set to version 1.0.0

@dsgouda
Copy link
Contributor

dsgouda commented Jun 15, 2018

@gu-wei PR still has 6 commits, if you could merge them into a single one, we are good to go here.

@gu-wei gu-wei closed this Jun 19, 2018
@gu-wei
Copy link
Member Author

gu-wei commented Jun 19, 2018

@dsgouda
combine to #4463

@gu-wei gu-wei mentioned this pull request Jun 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gu-wei @azuresdkci @dsgouda @shahabhijeet