Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ComputerVision client SDK to v2.0.0 #4452

Closed
wants to merge 0 commits into from
Closed

Upgrade ComputerVision client SDK to v2.0.0 #4452

wants to merge 0 commits into from

Conversation

cthrash
Copy link
Contributor

@cthrash cthrash commented Jun 15, 2018

  • Breaking change from 1.x for RecognizeText
  • Fix return type for AnalyzeImage with details=Landmark

REST Spec PR

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda suggested changes Jun 15, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the generate.cmd with generate.ps1 similar to this and regenerate the code
Please run msbuild build.proj /p:Scope=SDKs/CognitiveServices/dataPlane/Vision/ComputerVision/ComputerVision/ and commit all the changes generated

...ComputerVision/ComputerVision/Microsoft.Azure.CognitiveServices.Vision.ComputerVision.csproj Outdated
@@ -6,7 +6,7 @@
<PropertyGroup>
<PackageId>Microsoft.Azure.CognitiveServices.Vision.ComputerVision</PackageId>
<Description>This client library provides access to the Microsoft Cognitive Services ComputerVision APIs.</Description>
<VersionPrefix>1.1.0</VersionPrefix>
<VersionPrefix>2.0.0</VersionPrefix>
<AssemblyName>Microsoft.Azure.CognitiveServices.Vision.ComputerVision</AssemblyName>
<PackageTags>Microsoft Cognitive Services;Cognitive Services;Cognitive Services SDK;REST HTTP client;Computer Vision;Computer Vision API;Computer Vision SDK;Vision;netcore451511</PackageTags>
<PackageReleaseNotes>The Cognitive Services Computer Vision Client SDK lets users analyze images via Azure-hosted image classifiers. Classify images, generate image captions, recognize text, create smart thumbnails, and more.</PackageReleaseNotes>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the PackageReleaseNotes

@cthrash
Copy link
Contributor Author

cthrash commented Jun 18, 2018

How exactly is generate.ps1 invoked? I nuked the 'generated' directory and swagger codegen does not occur, using the steps provided.

@dsgouda
Copy link
Contributor

dsgouda commented Jun 18, 2018

@cthrash Do you see any files generated at all? Can you also check if anything was logged in the txt log file?
Also, if you could provide the text of the generate.ps1 file we can debug the issue

@cthrash cthrash closed this Jun 19, 2018
@cthrash cthrash force-pushed the cthrash/computervision-recotext branch from f4bce6b to b0d0559 Compare June 19, 2018 17:21
@cthrash
Copy link
Contributor Author

cthrash commented Jun 19, 2018

Nevermind - I misread your feedback and got it in to my head that msbuild build.proj would trigger generate.ps1. Ran it on it's own, and refreshed the PR.

@cthrash
Copy link
Contributor Author

cthrash commented Jun 19, 2018

There are more chanaged tee'd up in azure-rest-api-specs, will make a new PR when those go through

@cthrash cthrash mentioned this pull request Jun 20, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cthrash @dsgouda