[Compute] Add availability set list by subscription and standard ssd disk #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsgouda
suggested changes
Jul 2, 2018
| @@ -147,7 +166,7 @@ public partial interface IAvailabilitySetsOperations | |||
| /// <exception cref="Microsoft.Rest.ValidationException"> | |||
| /// Thrown when a required parameter is null | |||
| /// </exception> | |||
| Task<AzureOperationResponse<IEnumerable<AvailabilitySet>>> ListWithHttpMessagesAsync(string resourceGroupName, Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken)); | |||
| Task<AzureOperationResponse<IPage<AvailabilitySet>>> ListWithHttpMessagesAsync(string resourceGroupName, Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken)); | |||
There was a problem hiding this comment.
This will be a breaking change, please bump the major version for nuget package.
There was a problem hiding this comment.
@dsgouda updated the version to 21.0.0. Thanks.
hyonholee
changed the title
|
@hyonholee is this ready to be merged? |
hyonholee
changed the title
|
Thanks @hyonholee |
|
@dsgouda There is the label says |
|
@huangpf I had added the label since the title of this PR read [do not merge] |
|
@dsgouda thanks for making it consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure/azure-rest-api-specs#3302
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.