Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Added GenerateUserDelegationSasUri() for Blobs and BlobContainers #45646

Conversation

nickliu-msft
Copy link
Member

@nickliu-msft nickliu-msft commented Aug 22, 2024

Implemented the functionality to generate SAS Uri through User Delegation key
This PR is only for Blobs and BlobContainers

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Aug 22, 2024
@nickliu-msft nickliu-msft changed the base branch from main to feature/storage/stg96base2 August 22, 2024 15:43
@nickliu-msft
Copy link
Member Author

TODO: Add tests, export apis, add samples, record tests, etc.

@jaschrep-msft
Copy link
Member

@nickliu-msft I agree with Sean's comment. Additionally, suffixing a method with Internal in this codebase is really meant to convey a method is a joint sync/async implementation.

We shouldn't be suffixing Internal for every method with the internal visibility modifier. Rather, if there's an operation we need to run synchronously or asynchronously, we should be using a shared implementation suffixed this way, where the method signature ends with bool async, CancellationToken cancellationToken (in that order or the custom rules checker will yell). For public APIs, we just also need to expose the traditional sync and async methods.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Storage.Blobs

@seanmcc-msft
Copy link
Member

Resolves #44426

Copy link
Member

@amnguye amnguye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - had some minor comments

@nickliu-msft
Copy link
Member Author

Will revert the [LiveOnly] test back to [RecordedTest] after stg96base2 is merged
#45679

@seanmcc-msft seanmcc-msft merged commit 82f24fb into feature/storage/stg96base2 Sep 20, 2024
17 checks passed
@seanmcc-msft seanmcc-msft deleted the feature/storage/GenerateUserDelegationSas branch September 20, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants