Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate Azure.Security.KeyVault.Secrets for trim/AOT compat #46613

Merged
merged 2 commits into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the MIT License.

using System;
using System.Diagnostics.CodeAnalysis;
using Azure.Core.Extensions;
using Azure.Security.KeyVault.Secrets;

Expand All @@ -24,6 +25,8 @@ public static IAzureClientBuilder<SecretClient, SecretClientOptions> AddSecretCl
/// <summary>
/// Registers a <see cref="SecretClient"/> instance with connection options loaded from the provided <paramref name="configuration"/> instance.
/// </summary>
[RequiresUnreferencedCode("Binding strongly typed objects to configuration values is not supported with trimming. Use the Configuration Binder Source Generator (EnableConfigurationBindingGenerator=true) instead.")]
JonathanCrd marked this conversation as resolved.
Show resolved Hide resolved
[RequiresDynamicCode("Binding strongly typed objects to configuration values requires generating dynamic code at runtime, for example instantiating generic types. Use the Configuration Binder Source Generator (EnableConfigurationBindingGenerator=true) instead.")]
public static IAzureClientBuilder<SecretClient, SecretClientOptions> AddSecretClient<TBuilder, TConfiguration>(this TBuilder builder, TConfiguration configuration)
where TBuilder : IAzureClientFactoryBuilderWithConfiguration<TConfiguration>
{
Expand Down

This file was deleted.

2 changes: 1 addition & 1 deletion sdk/keyvault/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ extends:
CheckAOTCompat: true
AOTTestInputs:
- ArtifactName: Azure.Security.KeyVault.Secrets
ExpectedWarningsFilepath: /Azure.Security.KeyVault.Secrets/tests/compatibility/ExpectedAotWarnings.txt
ExpectedWarningsFilepath: None