Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure.Provisioning: API cleanup #46735

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Azure.Provisioning: API cleanup #46735

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7727390
Azure.Provisioning: Add Format to BicepValue (for ISO8601 durations)
Oct 21, 2024
194ae65
Azure.Provisioning: Add DeploymentScope enum
Oct 21, 2024
39c761e
Azure.Provisioning: Switch to interpolated string handler and add Bic…
Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions ...g/Azure.Provisioning.AppContainers/api/Azure.Provisioning.AppContainers.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ public static partial class ResourceVersions
public static readonly string V2022_10_01;
public static readonly string V2023_05_01;
public static readonly string V2024_03_01;
public static readonly string V2024_08_02_preview;
}
}
public enum ContainerAppAccessMode
Expand Down Expand Up @@ -112,7 +111,6 @@ public static partial class ResourceVersions
public static readonly string V2022_10_01;
public static readonly string V2023_05_01;
public static readonly string V2024_03_01;
public static readonly string V2024_08_02_preview;
}
}
public partial class ContainerAppAuthPlatform : Azure.Provisioning.Primitives.ProvisionableConstruct
Expand Down Expand Up @@ -228,7 +226,6 @@ public static partial class ResourceVersions
public static readonly string V2022_10_01;
public static readonly string V2023_05_01;
public static readonly string V2024_03_01;
public static readonly string V2024_08_02_preview;
}
}
public partial class ContainerAppConnectedEnvironmentCertificate : Azure.Provisioning.Primitives.ProvisionableResource
Expand All @@ -247,7 +244,6 @@ public static partial class ResourceVersions
public static readonly string V2022_10_01;
public static readonly string V2023_05_01;
public static readonly string V2024_03_01;
public static readonly string V2024_08_02_preview;
}
}
public partial class ContainerAppConnectedEnvironmentDaprComponent : Azure.Provisioning.Primitives.ProvisionableResource
Expand All @@ -271,7 +267,6 @@ public static partial class ResourceVersions
public static readonly string V2022_10_01;
public static readonly string V2023_05_01;
public static readonly string V2024_03_01;
public static readonly string V2024_08_02_preview;
}
}
public enum ContainerAppConnectedEnvironmentProvisioningState
Expand Down Expand Up @@ -299,7 +294,6 @@ public static partial class ResourceVersions
public static readonly string V2022_10_01;
public static readonly string V2023_05_01;
public static readonly string V2024_03_01;
public static readonly string V2024_08_02_preview;
}
}
public partial class ContainerAppContainer : Azure.Provisioning.Primitives.ProvisionableConstruct
Expand Down Expand Up @@ -632,7 +626,6 @@ public static partial class ResourceVersions
{
public static readonly string V2023_05_01;
public static readonly string V2024_03_01;
public static readonly string V2024_08_02_preview;
}
}
public partial class ContainerAppJobConfiguration : Azure.Provisioning.Primitives.ProvisionableConstruct
Expand Down Expand Up @@ -733,7 +726,6 @@ public static partial class ResourceVersions
{
public static readonly string V2023_05_01;
public static readonly string V2024_03_01;
public static readonly string V2024_08_02_preview;
}
}
public partial class ContainerAppManagedEnvironment : Azure.Provisioning.Primitives.ProvisionableResource
Expand Down Expand Up @@ -771,7 +763,6 @@ public static partial class ResourceVersions
public static readonly string V2022_10_01;
public static readonly string V2023_05_01;
public static readonly string V2024_03_01;
public static readonly string V2024_08_02_preview;
}
}
public partial class ContainerAppManagedEnvironmentCertificate : Azure.Provisioning.Primitives.ProvisionableResource
Expand All @@ -791,7 +782,6 @@ public static partial class ResourceVersions
public static readonly string V2022_10_01;
public static readonly string V2023_05_01;
public static readonly string V2024_03_01;
public static readonly string V2024_08_02_preview;
}
}
public partial class ContainerAppManagedEnvironmentDaprComponent : Azure.Provisioning.Primitives.ProvisionableResource
Expand All @@ -816,7 +806,6 @@ public static partial class ResourceVersions
public static readonly string V2022_10_01;
public static readonly string V2023_05_01;
public static readonly string V2024_03_01;
public static readonly string V2024_08_02_preview;
}
}
public enum ContainerAppManagedEnvironmentOutBoundType
Expand All @@ -839,7 +828,6 @@ public static partial class ResourceVersions
public static readonly string V2022_10_01;
public static readonly string V2023_05_01;
public static readonly string V2024_03_01;
public static readonly string V2024_08_02_preview;
}
}
public partial class ContainerAppOpenIdConnectClientCredential : Azure.Provisioning.Primitives.ProvisionableConstruct
Expand Down Expand Up @@ -990,7 +978,6 @@ public static partial class ResourceVersions
public static readonly string V2022_10_01;
public static readonly string V2023_05_01;
public static readonly string V2024_03_01;
public static readonly string V2024_08_02_preview;
}
}
public enum ContainerAppSourceControlOperationState
Expand Down
5 changes: 0 additions & 5 deletions sdk/provisioning/Azure.Provisioning.AppContainers/src/Generated/ContainerApp.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions sdk/provisioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppAuthConfig.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions ...ioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppConnectedEnvironment.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions ...e.Provisioning.AppContainers/src/Generated/ContainerAppConnectedEnvironmentCertificate.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions ...Provisioning.AppContainers/src/Generated/ContainerAppConnectedEnvironmentDaprComponent.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions ...Azure.Provisioning.AppContainers/src/Generated/ContainerAppConnectedEnvironmentStorage.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions sdk/provisioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppJob.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions ...isioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppManagedCertificate.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions ...isioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppManagedEnvironment.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions ...ure.Provisioning.AppContainers/src/Generated/ContainerAppManagedEnvironmentCertificate.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions ...e.Provisioning.AppContainers/src/Generated/ContainerAppManagedEnvironmentDaprComponent.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions ...g/Azure.Provisioning.AppContainers/src/Generated/ContainerAppManagedEnvironmentStorage.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions sdk/provisioning/Azure.Provisioning.AppContainers/src/Generated/ContainerAppSourceControl.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ...isioning.ApplicationInsights/api/Azure.Provisioning.ApplicationInsights.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ public static partial class ResourceVersions
public static readonly string V2014_08_01;
public static readonly string V2015_05_01;
public static readonly string V2020_02_02;
public static readonly string V2020_02_02_preview;
}
}
public enum ApplicationInsightsPublicNetworkAccessType
Expand Down
5 changes: 0 additions & 5 deletions ...ning/Azure.Provisioning.ApplicationInsights/src/Generated/ApplicationInsightsComponent.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 14 additions & 7 deletions sdk/provisioning/Azure.Provisioning.CloudMachine/src/CDKLevel3/CloudMachineInfrastructure.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,14 @@ public CloudMachineInfrastructure(string cmId)
UserAssignedIdentities = { { BicepFunction.Interpolate($"{Identity.Id}").Compile().ToString(), new UserAssignedIdentityDetails() } }
};

_storage = StorageResources.CreateAccount("cm_storage");
_storage =
new StorageAccount("cm_storage", StorageAccount.ResourceVersions.V2023_01_01)
{
Kind = StorageKind.StorageV2,
Sku = new StorageSku { Name = StorageSkuName.StandardLrs },
IsHnsEnabled = true,
AllowBlobPublicAccess = false
};
_storage.Identity = managedServiceIdentity;
_storage.Name = _cmid;

Expand Down Expand Up @@ -110,7 +117,7 @@ public CloudMachineInfrastructure(string cmId)
Name = "cm_servicebus_topic_private",
Parent = _serviceBusNamespace,
MaxMessageSizeInKilobytes = 256,
DefaultMessageTimeToLive = new StringLiteralExpression("P14D"),
DefaultMessageTimeToLive = TimeSpan.FromDays(14),
tg-msft marked this conversation as resolved.
Show resolved Hide resolved
RequiresDuplicateDetection = false,
EnableBatchedOperations = true,
SupportOrdering = true,
Expand All @@ -121,9 +128,9 @@ public CloudMachineInfrastructure(string cmId)
Name = SB_PRIVATE_SUB,
Parent = _serviceBusTopic_private,
IsClientAffine = false,
LockDuration = new StringLiteralExpression("PT30S"),
LockDuration = TimeSpan.FromSeconds(30),
RequiresSession = false,
DefaultMessageTimeToLive = new StringLiteralExpression("P14D"),
DefaultMessageTimeToLive = TimeSpan.FromDays(14),
DeadLetteringOnFilterEvaluationExceptions = true,
DeadLetteringOnMessageExpiration = true,
MaxDeliveryCount = 10,
Expand All @@ -135,7 +142,7 @@ public CloudMachineInfrastructure(string cmId)
Name = "cm_servicebus_default_topic",
Parent = _serviceBusNamespace,
MaxMessageSizeInKilobytes = 256,
DefaultMessageTimeToLive = new StringLiteralExpression("P14D"),
DefaultMessageTimeToLive = TimeSpan.FromDays(14),
RequiresDuplicateDetection = false,
EnableBatchedOperations = true,
SupportOrdering = true,
Expand All @@ -146,9 +153,9 @@ public CloudMachineInfrastructure(string cmId)
Name = "cm_servicebus_subscription_default",
Parent = _serviceBusTopic_default,
IsClientAffine = false,
LockDuration = new StringLiteralExpression("PT30S"),
LockDuration = TimeSpan.FromSeconds(30),
RequiresSession = false,
DefaultMessageTimeToLive = new StringLiteralExpression("P14D"),
DefaultMessageTimeToLive = TimeSpan.FromDays(14),
DeadLetteringOnFilterEvaluationExceptions = true,
DeadLetteringOnMessageExpiration = true,
MaxDeliveryCount = 10,
Expand Down
4 changes: 0 additions & 4 deletions ...g/Azure.Provisioning.Communication/api/Azure.Provisioning.Communication.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public static partial class ResourceVersions
{
public static readonly string V2023_03_31;
public static readonly string V2023_04_01;
public static readonly string V2023_06_01_preview;
}
}
public partial class CommunicationService : Azure.Provisioning.Primitives.ProvisionableResource
Expand Down Expand Up @@ -50,7 +49,6 @@ public static partial class ResourceVersions
public static readonly string V2020_08_20;
public static readonly string V2023_03_31;
public static readonly string V2023_04_01;
public static readonly string V2023_06_01_preview;
}
}
public partial class CommunicationServiceKeys : Azure.Provisioning.Primitives.ProvisionableConstruct
Expand Down Expand Up @@ -153,7 +151,6 @@ public static partial class ResourceVersions
{
public static readonly string V2023_03_31;
public static readonly string V2023_04_01;
public static readonly string V2023_06_01_preview;
}
}
public enum EmailServicesProvisioningState
Expand Down Expand Up @@ -184,7 +181,6 @@ public static partial class ResourceVersions
{
public static readonly string V2023_03_31;
public static readonly string V2023_04_01;
public static readonly string V2023_06_01_preview;
}
}
public enum UserEngagementTracking
Expand Down
5 changes: 0 additions & 5 deletions sdk/provisioning/Azure.Provisioning.Communication/src/Generated/CommunicationDomain.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions sdk/provisioning/Azure.Provisioning.Communication/src/Generated/CommunicationService.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading