Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACR 3.0 SDK (support ACR Build/Task GA Service) #4825

Merged
merged 2 commits into from
Oct 3, 2018
Merged

ACR 3.0 SDK (support ACR Build/Task GA Service) #4825

merged 2 commits into from
Oct 3, 2018

Conversation

northtyphoon
Copy link
Member

Description

Swagger: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/containerregistry/resource-manager
Swagger PR: Azure/azure-rest-api-specs#3617

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@northtyphoon
Copy link
Member Author

@djyou

dsgouda
dsgouda approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Oct 3, 2018

@northtyphoon do you need any other approvals or is this good to merge

djyou
djyou approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@djyou djyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...nerRegistry/Management.ContainerRegistry/Microsoft.Azure.Management.ContainerRegistry.csproj
1) Added support for Azure Container Registry Build service.
2) Added support for registry policy.
3) Added support for image import.
1) Added support for Azure Container Registry Task service.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: do you want to mention this is a breaking change from the 2.8.0-preview version since build is rebranded to task, although the major version bump already indicates that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@northtyphoon
Copy link
Member Author

@dsgouda, it's ready to merge.

@dsgouda
Copy link
Contributor

dsgouda commented Oct 3, 2018

Will merge once CIs pass

@dsgouda dsgouda merged commit 502fab5 into Azure:psSdkJson6 Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djyou djyou djyou approved these changes

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@northtyphoon @dsgouda @djyou