Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StorageSync ResourceProvider : Bug Fix for renaming parameter #4912

Merged
merged 3 commits into from
Oct 25, 2018
Merged

StorageSync ResourceProvider : Bug Fix for renaming parameter #4912

merged 3 commits into from
Oct 25, 2018

Conversation

ankushbindlish2
Copy link
Member

@ankushbindlish2 ankushbindlish2 commented Oct 22, 2018 •
edited
Loading

Pull Request : Azure/azure-rest-api-specs#4308

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@ankushbindlish2
Bug Fix for renaming parameter
bc743d3
@ankushbindlish2
Update src/SDKs/StorageSync/StorageSync.Tests/SessionRecords/Microsof…
0ebaf5b 
…t.Azure.Management.StorageSync.Tests.RegisteredServerTests/RegisteredServerTriggerRolloverTest.json
dsgouda
dsgouda suggested changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate code from spec merged in the remote master

src/SDKs/StorageSync/Management.StorageSync/Generated/Models/TriggerRolloverRequest.cs Show resolved Hide resolved
dsgouda
dsgouda approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit eba036e into Azure:psSdkJson6 Oct 25, 2018
v-djnisi pushed a commit to v-djnisi/azure-sdk-for-net that referenced this pull request Oct 30, 2018
@ankushbindlish2 @v-djnisi
StorageSync ResourceProvider : Bug Fix for renaming parameter (Azure#…
19d8aee 
…4912)

* Bug Fix for renaming parameter

* Update src/SDKs/StorageSync/StorageSync.Tests/SessionRecords/Microsoft.Azure.Management.StorageSync.Tests.RegisteredServerTests/RegisteredServerTriggerRolloverTest.json

* Base Uri change and Update from master spec
ahamad-MS pushed a commit to ahamad-MS/azure-sdk-for-net that referenced this pull request Oct 31, 2018
@ankushbindlish2
StorageSync ResourceProvider : Bug Fix for renaming parameter (Azure#…
89956e7 
…4912)

* Bug Fix for renaming parameter

* Update src/SDKs/StorageSync/StorageSync.Tests/SessionRecords/Microsoft.Azure.Management.StorageSync.Tests.RegisteredServerTests/RegisteredServerTriggerRolloverTest.json

* Base Uri change and Update from master spec
This was referenced Oct 17, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankushbindlish2 @dsgouda