Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logic] Sync SDK with swagger updates #5032

Conversation

refortie
Copy link
Contributor

@refortie refortie commented Nov 17, 2018

Description

Updating the Logic Apps SDK based on the newest version of the swagger. This adds 2 new endpoints which both have Get and List. Also this includes a bugfix where a user could not update a Logic App that had an attached Integration Account.

Bugfix PR
New endpoints PR


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@refortie refortie changed the title Sync Logic App SDK with API updates [Logic] Sync SDK with swagger updates Nov 17, 2018
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull latest changes from psSdkJson6, run git clean -xdff, msbuild build.proj and regenerate the code.

Add 2 new endpoints to the SDK. Also fix a bug that caused a workflow with an integration account to be unable to be updated
@refortie refortie force-pushed the bugfix-saving-logicapp-with-integrationaccount branch from 1828a65 to 4330753 Compare November 19, 2018 18:54
@refortie
Copy link
Contributor Author

Regenerated the code from a fresh pull.

@@ -8,9 +8,14 @@
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<Version>1.0.0</Version>
</PropertyGroup>
<ItemGroup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refortie remove line 11-16 you don't need it. (nit)
Please remove this next time.

@shahabhijeet shahabhijeet merged commit 41b512a into Azure:psSdkJson6 Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants