Changes based on review of pipeline. #5087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Splitting audit (test and compliance) into separate job - Directly calling sn.exe rather than searching for it - Building and packaging in a single step - Adding Linux job
|
The azure-sdk-for-net.client CI is failing because it won't resolve the scope variables I added (scope-L and scope-W). I've added them to the pipeline definitions, but it just ignores them. I'm assuming that it will start resolving them once this is merged. I can't think of another reason why it wouldn't resolve them. |
Don't need separate ones for Linux and Windows after all.
weshaggard
reviewed
Dec 14, 2018
weshaggard
reviewed
Dec 14, 2018
weshaggard
reviewed
Dec 14, 2018
weshaggard
approved these changes
Dec 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weshaggard @shahabhijeet