Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix batch changelog and test #5088

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Fix batch changelog and test #5088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/SDKs/Batch/DataPlane/Azure.Batch.IntegrationTests/JobPrepReleaseIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ public void TestOMJobPrepSchedulingError()
JobPreparationTask prep = new JobPreparationTask("cmd /c JobPrep Task");
unboundJob.JobPreparationTask = prep;

ResourceFile[] badResFiles = { ResourceFile.FromUrl("https://127.0.0.1/foo/bar/baf", "bob.txt")};
ResourceFile[] badResFiles = { ResourceFile.FromUrl("https://not.a.domain.invalid/file", "bob.txt")};

prep.ResourceFiles = badResFiles;

Expand Down Expand Up @@ -416,8 +416,8 @@ public void TestOMJobReleaseSchedulingError()
{
JobReleaseTask relTask = new JobReleaseTask("cmd /c echo Job Release Task");
unboundJob.JobReleaseTask = relTask;
ResourceFile[] badResFiles = { ResourceFile.FromUrl("https://127.0.0.1/foo/bar/baf", "bob.txt")};

ResourceFile[] badResFiles = { ResourceFile.FromUrl("https://not.a.domain.invalid/file", "bob.txt")};

relTask.ResourceFiles = badResFiles;

Expand Down
4 changes: 3 additions & 1 deletion src/SDKs/Batch/DataPlane/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,13 @@
- `ResourceFile.FromStorageContainerUrl` creates a `ResourceFile` pointing to an Azure Blob Storage container.
- `ResourceFile.FromAutoStorageContainer` creates a `ResourceFile` pointing to an Azure Blob Storage container in the Batch registered auto-storage account.
- URLs provided to `ResourceFile` via the `ResourceFile.FromUrl` method can now be any HTTP URL. Previously, these had to be an Azure Blob Storage URL.
- The `BlobPrefix` property can be used to filter downloads from a storage container to only those matching the prefix.
- **[Breaking]** Removed `OSDisk` property from `VirtualMachineConfiguration`. This property is no longer supported.
- Pools which set the `DynamicVNetAssignmentScope` on `NetworkConfiguration` to be `DynamicVNetAssignmentScope.Job` can
now dynamically assign a Virtual Network to each node the job's tasks run on. The specific Virtual Network to join the nodes to is specified in
the new `JobNetworkConfiguration` property on `CloudJob` and `JobSpecification`.
- **Note**: This feature is in public preview. It is disabled for all Batch accounts except for those
- **Note**: This feature is in public preview. It is disabled for all Batch accounts except for those which have contacted us and requested to
be in the pilot.
- The maximum lifetime of a task is now 180 days (previously it was 7).
- Added support on Windows pools for creating users with a specific login mode (either `Batch` or `Interactive`) via `WindowsUserConfiguration.LoginMode`.
- The default task retention time for all tasks is now 7 days, previously it was infinite.
Expand Down