chore) expose x-ms-client-id property in MapsAccount #5108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix failing tests |
SudhindraKovalam
force-pushed
the
psSdkJson6
branch
from
c15451f
to
c9d8c5f
Compare
|
@dsgouda , the tests have been fixed. Can you please take a look ? |
dsgouda
suggested changes
Dec 21, 2018
| @@ -7,7 +7,7 @@ | |||
| <PackageId>Microsoft.Azure.Management.Maps</PackageId> | |||
| <PackageReleaseNotes>This package replaces Microsoft.Azure.Management.LocationBasedServices. Azure Location Based Services is now Azure Maps.</PackageReleaseNotes> | |||
| <Description>Microsoft Azure Management Maps Library</Description> | |||
| <VersionPrefix>1.0.1</VersionPrefix> | |||
| <VersionPrefix>1.0.2</VersionPrefix> | |||
| <AssemblyName>Microsoft.Azure.Management.Maps</AssemblyName> | |||
| <PackageTags>Microsoft Azure Maps management;Location Services;Location Services management;REST HTTP client;windowsazureofficial;netcore451511</PackageTags> | |||
| <PackageReleaseNotes>Taking dependency on 10.0.3 version of Newtonsoft nuget package.</PackageReleaseNotes> | |||
There was a problem hiding this comment.
Please update the PackageReleaseNotes
There was a problem hiding this comment.
Updated the release notes
SudhindraKovalam
force-pushed
the
psSdkJson6
branch
from
c9d8c5f
to
ee7ca50
Compare
dsgouda
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to the rest-api-specs repo PR: Azure/azure-rest-api-specs#4946
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.