Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Postgres/MySql/ManagedInstance online migration scenarios #5120

Merged
merged 4 commits into from
Jan 9, 2019
Merged

Add Postgres/MySql/ManagedInstance online migration scenarios #5120

merged 4 commits into from
Jan 9, 2019

Conversation

ash1625
Copy link
Contributor

@ash1625 ash1625 commented Jan 8, 2019

Description

REST spec PR link to the SDK PR :
Azure/azure-rest-api-specs#4627

This PR adds the below new scenarios to Azure Database Migration Service:

  1. SQL to Azure SQL Managed Instance online migration
  2. SQL to Azure Postgres SQL online migration
  3. SQL to Azure MySQL online migration

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, needs a minor change,

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 193df78 into Azure:psSdkJson6 Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants