[KeyVault] reving package versions to republish with symbols #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahabhijeet
suggested changes
Jan 15, 2019
weshaggard
reviewed
Jan 15, 2019
| @@ -5,11 +5,11 @@ | |||
| <Description>Microsoft Azure Key Vault Core Class Library</Description> | |||
| <AssemblyTitle>Microsoft Azure Key Vault Core</AssemblyTitle> | |||
| <AssemblyName>Microsoft.Azure.KeyVault.Core</AssemblyName> | |||
| <Version>3.0.1</Version> | |||
| <Version>3.0.2</Version> | |||
There was a problem hiding this comment.
Would it make sense to make all these 3.0.3 and share this version in a common props file for all these projects? As part of my changes I was planning to do that.
weshaggard
reviewed
Jan 16, 2019
| @@ -1,17 +1,11 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.props'))" /> | |||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('KeyVault.package.props'))" /> | |||
There was a problem hiding this comment.
You can rename the file Directory.Build.props and it will get imported automatically.
weshaggard
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.