Add key vault build #5149
Merged
Add key vault build #5149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shahabhijeet @schaabs I'm going to go ahead and merge this PR to re-enable our devops build KeyVault. Please feel free to still provide feedback and I'll address it in a follow-up PR if necessary. @schaabs after this change goes in you may run into some issues using the Jenkins jobs to build KeyVault, so we will either need to build them against an older sha or move the our devops to produce the build (assuming we haven't already produced the build). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kurtzeborn @schaabs @shahabhijeet this is the follow changes needed add KeyVault to the new data-plane builds. Probably best to look at the second comment for the real changes as the first comment is just a rename with no changes.
cc @azure/azure-sdk-eng