Generate SDK for new API version #5151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsgouda
suggested changes
Jan 18, 2019
| @@ -6,17 +6,19 @@ | |||
| <PropertyGroup> | |||
| <PackageId>Microsoft.Azure.Management.Blueprint</PackageId> | |||
| <Description>Provides Microsoft Azure Blueprint management operations including the ability to create, update and delete Blueprint definition and assignment.</Description> | |||
| <Version>0.9.1-Preview</Version> | |||
| <Version>0.10.0-Preview</Version> | |||
There was a problem hiding this comment.
Since this is a new API version, the Nuget major version needs to be bumped too.
There was a problem hiding this comment.
@filizt As we discussed offline, please bump this version to 1.8.0-preview (please note the casing)
There was a problem hiding this comment.
@dsgouda after out email thread, updating the version as 0.10.0-preview
src/SDKs/Blueprint/Management.Blueprint/Microsoft.Azure.Management.Blueprint.csproj
Show resolved
Hide resolved
|
Will merge on CIs passing azure-sdk-for-net.client can be ignored |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blueprint API change PRs
Azure/azure-rest-api-specs#4590
Azure/azure-rest-api-specs#4945
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.Blueprint API change PRs
Azure/azure-rest-api-specs#4590
Azure/azure-rest-api-specs#4945