Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GuestConfiguration]Add version field to ConfigurationInfo #5199

Merged
merged 6 commits into from
Feb 1, 2019
Merged

[GuestConfiguration]Add version field to ConfigurationInfo #5199

merged 6 commits into from
Feb 1, 2019

Conversation

aashish1987
Copy link
Member

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@aashish1987
Copy link
Member Author

Azure/azure-rest-api-specs#5131

dsgouda
dsgouda suggested changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aashish1987 please regenerate the code using generate.ps1 and update the PR.
Also, please bump nuget version to 1.1.0 in the csproj and AssemblyInfo.cs and update the PackageReleaseNotes accordingly

dsgouda
dsgouda suggested changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a minor change

src/SDKs/GuestConfiguration/Management.GuestConfiguration/Properties/AssemblyInfo.cs Outdated Show resolved Hide resolved
dsgouda
dsgouda approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge once CIs pass

@dsgouda dsgouda merged commit deea705 into Azure:master Feb 1, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@aashish1987 @mentat9
[GuestConfiguration]Add version field to ConfigurationInfo (Azure#5199)
2a002f2 
* Added Version field to ConfigurationInfo object

* Updated SDK from swagger specs

* Update test cases to include version field in ConfigurationInfo class

* Update the version to 1.1.0 and generated sdk from latest swagger specs

* Updated the test json files to reflect the new version

* Reverting Assembly version back to 1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aashish1987 @dsgouda