Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network SDK version 2018-12-01 #5247

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

anton-evseev
Copy link
Contributor

@anton-evseev anton-evseev commented Feb 14, 2019

Description

Need to get Azure/azure-rest-api-specs#5202 in first and re-generate.

Re-generated Network SDK based on Azure/azure-rest-api-specs#5189


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@anton-evseev anton-evseev changed the title Network SDK version 2018-12-01 [Do not merge] Network SDK version 2018-12-01 Feb 14, 2019
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 4c3bda5 into Azure:master Feb 14, 2019
@dsgouda dsgouda changed the title [Do not merge] Network SDK version 2018-12-01 Network SDK version 2018-12-01 Feb 14, 2019
@anton-evseev anton-evseev deleted the network-january-release branch February 15, 2019 06:36
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants