Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datafactory]SDK Change for SapOpenHub and Rest #5260

Merged
merged 2 commits into from
Feb 21, 2019
Merged

[Datafactory]SDK Change for SapOpenHub and Rest #5260

merged 2 commits into from
Feb 21, 2019

Conversation

wenbof-zz
Copy link

No description provided.

dsgouda
dsgouda suggested changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this code generated? (using generate.ps1?) Please commit all changes generated including those to .txt files

@dsgouda
Copy link
Contributor

dsgouda commented Feb 21, 2019

@wenbof please link the Rest spec PR too

@hvermis
Copy link
Contributor

hvermis commented Feb 21, 2019

@dsgouda This is the spec PR for this change:
Azure/azure-rest-api-specs#5195

@shahabhijeet
Copy link
Member

@wenbof can you answer the question raised by @dsgouda? you are missing meta data in this PR.

@dsgouda
Copy link
Contributor

dsgouda commented Feb 21, 2019

@wenbof please regenerate the code using generate.ps1 and commit changes to the .txt and SdkInfo*_.cs files

dsgouda
dsgouda approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on offline conversation with @hvermis

@dsgouda dsgouda merged commit 2bc58ff into Azure:master Feb 21, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@wenbof @mentat9
[Datafactory]SDK Change for SapOpenHub and Rest (Azure#5260)
b3f9f9a 
* [Datafactory]SDK Change for SapOpenHub and Rest

* fix indention
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvermis hvermis hvermis approved these changes

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wenbof-zz @dsgouda @hvermis @shahabhijeet @wenbof